[issue7547] test_timeout should skip, not fail, when the remote host is not available

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Committed in r85931 (3.2), r85932 (3.1) and r85933 (2.7).

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7547] test_timeout should skip, not fail, when the remote host is not available

[Sandro Tosi]

Sandro Tosi  added the comment:

Hello,
as discussed on irc, I'm proposing a patch that:

- wraps the test with support.transient_internet
- limits the assert to only socket.timeout (what we want to test)

test_smptnet.py is already fixed, since it already uses 
support.transient_internet

Regards,
Sandro

--
keywords: +patch
nosy: +sandro.tosi
stage: needs patch -> patch review
Added file: http://bugs.python.org/file19416/issue7547-py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7547] test_timeout should skip, not fail, when the remote host is not available

[Mark Lawrence]

Changes by Mark Lawrence :


--
versions:  -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7547] test_timeout should skip, not fail, when the remote host is not available

[Antoine Pitrou]

New submission from Antoine Pitrou :

test_timeout uses www.python.org as a Guinea pig for its socket tests.
Unfortunately sometimes www.python.org is down, which gives the
following kind of failures (seen on a buildbot recently):

test test_timeout failed -- Traceback (most recent call last):
  File "C:\buildslave\3.x.moore-windows\build\lib\test\test_timeout.py",
line 133, in testRecvTimeout
self.sock.connect(self.addr_remote)
socket.error: [Errno 10060] A connection attempt failed because the
connected party did not properly respond after a period of time, or
established connection failed because connected host has failed to respond

test_timeout should catch the error and simply skip the test with an
appropriate message.

There's a similar problem with test_smtpnet which uses gmail as its
remote SMTP-SSL provider.

--
components: Tests
messages: 96615
nosy: pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: test_timeout should skip, not fail, when the remote host is not available
type: behavior
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com