[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Mark Dickinson]

Mark Dickinson  added the comment:

Applied the test_cmath part of the patch in r76948 (trunk) and r76950 
(py3k).  I was too lazy to backport to the maintenance releases, mostly 
because that would have involved replacing all the '{}'s in format strings 
with numbered versions. ('{0}' ...)

Thanks again, Florent!

--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Mark Dickinson]

Mark Dickinson  added the comment:

test_math changes applied in r76945 (trunk), and backported to release26-
maint in r76946 for good measure.  For the sake of ease of maintenance, I 
used code that matched the existing py3k code, rather than the exact code 
Florent provided.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Mark Dickinson]

Mark Dickinson  added the comment:

Whoops;  I didn't see your patch until too late.

--
assignee:  -> mark.dickinson
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Mark Dickinson]

Mark Dickinson  added the comment:

Thanks!  Fixed in r76941 (trunk) and r76942 (release26-maint)  (with 
tweaks in the following two revisions).

--
nosy: +mark.dickinson
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Florent Xicluna]

Florent Xicluna  added the comment:

I've done a review of this test file, and removed code duplication
between function "almostEqualF" and method "rAssertAlmostEqual".

(and changed some syntax to make "-3" happy)

--
keywords: +patch
Added file: http://bugs.python.org/file15633/issue7554_cmath.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7554] Some tests in test_cmath use rAssertAlmostEqual incorrectly

[Florent Xicluna]

Changes by Florent Xicluna :


--
title: Some tests in test_cmath should use rAssertAlmostEqual incorrectly -> 
Some tests in test_cmath use rAssertAlmostEqual incorrectly

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com