[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - duplicate stage: patch review - committed/rejected status: open - closed superseder: - PyModuleDef_HEAD_INIT does not explicitly initialize all fields of m_base ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7576 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
Stefan Behnel added the comment: This is a duplicate of issue 9518 (or the other way round) and should be closed as fixed in 3.2. -- components: +Extension Modules nosy: +scoder ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7576 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
Reid Kleckner r...@mit.edu added the comment: This patch looks good to me, after digging through the relevant module code. I was confused though for a bit as to why PyModuleDef is a PyObject with a NULL type. It turns out that import.c wants to keep them in a dictionary, so it needs to be able to cast to PyObject* and to access the refcount. It never needs the type, though, so it's safe to leave it NULL. I think it might be worth adding comments explaining that in this patch or another. -- nosy: +rnk ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7576 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
Mark Lawrence breamore...@yahoo.co.uk added the comment: This is a miniscule patch to moduleobject.h could someone with the relevant knowledge please review it, thanks. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7576 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
New submission from Ronald Oussoren ronaldousso...@mac.com: When running GCC with warnings the compiler can warn about incomplete structure initializers. This gives spurious warnings when initializing a PyModuleDef structure using PyModuleDef_HEAD_INIT The attached patchs changes PyModuleDef_HEAD_INIT to explicitly initialize all fields in PyModuleDef_Base. An example warning that is silenced by this patch: Modules/objc/test/structpointer2.m:19: warning: missing initializer Modules/objc/test/structpointer2.m:19: warning: (near initialization for ‘mod_module.m_base.m_init’) -- files: moduleobject-init-warnings.patch keywords: needs review, patch, patch messages: 96881 nosy: ronaldoussoren priority: normal severity: normal stage: patch review status: open title: Avoid warnings in PyModuleDef_HEAD_INIT type: compile error versions: Python 3.2 Added file: http://bugs.python.org/file15672/moduleobject-init-warnings.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7576 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
