[issue8280] urllib2 passes fragment identifier to server

2010-08-08 Thread Senthil Kumaran 

Senthil Kumaran orsent...@gmail.com added the comment:

Fixed in revision 83818(py3k),  83819 (release31-maint) and 83820 
(release27-maint).

David, a couple of comments on your patch.
- Request method was from urllib2, so the proper place of tests were 
test_urllib2. This already had Requests test so some additional tests were only 
required.
- Also, now the fragments are removed and sent to the server, a proper response 
could be obtained, it can tested via 'network' tests in test_urllib2net.

You might check the svn diffs to see the changes made. 
Thanks for the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-08-08 Thread Senthil Kumaran 

Changes by Senthil Kumaran orsent...@gmail.com:


--
resolution: accepted - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-08-03 Thread David Stanek 

David Stanek dsta...@dstanek.com added the comment:

Added a patch to fix this behavior.

--
keywords: +patch
nosy: +dstanek
Added file: http://bugs.python.org/file18358/fragment.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-08-03 Thread David Stanek 

David Stanek dsta...@dstanek.com added the comment:

I have also uploaded my patch to http://codereview.appspot.com/1918042 so 
easier viewing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-04-05 Thread Senthil Kumaran 

Changes by Senthil Kumaran orsent...@gmail.com:


--
assignee:  - orsenthil
resolution:  - accepted

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-04-01 Thread INADA Naoki 

New submission from INADA Naoki songofaca...@gmail.com:

 urllib2.urlopen(http://wave-robot-python-client.googlecode.com/svn/trunk/pydocs/index.html#module-wavelet;)
Traceback (most recent call last):
  File stdin, line 1, in module
  File C:\usr\Python2.6\lib\urllib2.py, line 126, in urlopen
return _opener.open(url, data, timeout)
  File C:\usr\Python2.6\lib\urllib2.py, line 398, in open
response = meth(req, response)
  File C:\usr\Python2.6\lib\urllib2.py, line 511, in http_response
'http', request, response, code, msg, hdrs)
  File C:\usr\Python2.6\lib\urllib2.py, line 436, in error
return self._call_chain(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 370, in _call_chain
result = func(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 519, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 400: Bad Request

This happens when redirected URL contains fragment.

 urllib2.urlopen(http://goo.gl/z1d5;)
Traceback (most recent call last):
  File stdin, line 1, in module
  File C:\usr\Python2.6\lib\urllib2.py, line 126, in urlopen
return _opener.open(url, data, timeout)
  File C:\usr\Python2.6\lib\urllib2.py, line 398, in open
response = meth(req, response)
  File C:\usr\Python2.6\lib\urllib2.py, line 511, in http_response
'http', request, response, code, msg, hdrs)
  File C:\usr\Python2.6\lib\urllib2.py, line 430, in error
result = self._call_chain(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 370, in _call_chain
result = func(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 606, in http_error_302
return self.parent.open(new, timeout=req.timeout)
  File C:\usr\Python2.6\lib\urllib2.py, line 398, in open
response = meth(req, response)
  File C:\usr\Python2.6\lib\urllib2.py, line 511, in http_response
'http', request, response, code, msg, hdrs)
  File C:\usr\Python2.6\lib\urllib2.py, line 436, in error
return self._call_chain(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 370, in _call_chain
result = func(*args)
  File C:\usr\Python2.6\lib\urllib2.py, line 519, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 400: Bad Request

urllib2.Request.get_selector() should be:

def get_selector(self):
return self.__r_host.split('#')[0]

--
messages: 102103
nosy: naoki
severity: normal
status: open
title: urllib2 passes fragment identifier to server

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-04-01 Thread INADA Naoki 

Changes by INADA Naoki songofaca...@gmail.com:


--
components: +Library (Lib)
type:  - behavior
versions: +Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 
3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-04-01 Thread Brian Curtin 

Changes by Brian Curtin cur...@acm.org:


--
nosy: +orsenthil
versions:  -Python 2.5, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8280] urllib2 passes fragment identifier to server

2010-04-01 Thread Éric Araujo 

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com