[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
R. David Murray rdmur...@bitdance.com added the comment: The buildbots seem happy. -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
R. David Murray rdmur...@bitdance.com added the comment: Hmm. The patch didn't apply to my current trunk checkout. I'll look into why later. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
Dave Malcolm dmalc...@redhat.com added the comment: I believe $(INSTALL_SCRIPT) was changed to $(INSTALL_DATA) in r79716 (see http://bugs.python.org/issue8032#msg102288 ) Attaching refreshed version of the patch. -- Added file: http://bugs.python.org/file16760/introduce-var-for-gdb-hooks-002.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
R. David Murray rdmur...@bitdance.com added the comment: Committed in r79778. We'll see how the buildbots fare. -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
New submission from Florent Xicluna florent.xicl...@gmail.com: The compile step fails on python-gdb.py on some buildbots. # sparc solaris 10 gcc running build_scripts [51847 refs] ./install-sh -c python-gdb.py ./install-sh: python-gdb.py does not exist *** Error code 1 make: Fatal error: Command failed for target `python-gdb.py' # x86 FreeBSD running build_scripts [53576 refs] /usr/bin/install -c python-gdb.py usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode] [-o owner] file1 file2 install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode] [-o owner] file1 ... fileN directory install -d [-v] [-g group] [-m mode] [-o owner] directory ... *** Error code 64 -- components: Build keywords: buildbot messages: 102155 nosy: doko, flox, loewis priority: high severity: normal stage: needs patch status: open title: python-gdb.py triggers compile errors on FreeBSD and Solaris type: compile error versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
Martin v. Löwis mar...@v.loewis.de added the comment: David, can you please take a look? -- assignee: - dmalcolm nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris
Dave Malcolm dmalc...@redhat.com added the comment: Sorry about this. I believe this is the expansion of these fragments from the Makefile.pre.in (indenting for clarity): gdbhooks: $(BUILDPYTHON)-gdb.py $(BUILDPYTHON)-gdb.py: Tools/gdb/libpython.py $(INSTALL_SCRIPT) $ $(BUILDPYTHON)-gdb.py It looks like the second of these is being invoked in both cases with $ as the empty string, rather than Tools/gdb/libpython.py (and each with their own expansion of INSTALL_SCRIPT). I'm guessing that the $ is a GNU Make-ism that isn't available on all implementations of make. If so, the quick fix is probably to replace $ with Tools/gdb/libpython.py in Makefile.pre.in I'm attaching a patch which introduces a variable for the path and uses this, rather than $. I only have access to Linux machines; I've tested it on one, and it works. I don't have commit rights, so I can't fix this directly myself. $ make -v GNU Make 3.81 From info make: `$' The name of the first prerequisite. If the target got its commands from an implicit rule, this will be the first prerequisite added by the implicit rule (*note Implicit Rules::). (In my defence, $ appeared to be used already in the Some make's put the object file in the current directory rule). Sorry again from breaking the build on those configurations. -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file16735/introduce-var-for-gdb-hooks.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8287 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
