[issue8594] Add a source_address option to ftplib
Roundup Robot devnull@devnull added the comment: New changeset 7f605fa1688d by Giampaolo Rodol�� in branch 'default': #8594: fix ResourceWarning in test_ftplib.py - patch by Nadeem Vawda. http://hg.python.org/cpython/rev/7f605fa1688d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Giampaolo Rodola' g.rod...@gmail.com added the comment: Committed in r68309. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Giampaolo Rodola' g.rod...@gmail.com added the comment: Ok, that wasn't r68309. =) I'm not sure what revision number is now that we're using mercurial. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Nadeem Vawda nadeem.va...@gmail.com added the comment: I'm not seeing the commit anywhere. Did you perhaps forget to hg push after committing? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Nadeem Vawda nadeem.va...@gmail.com added the comment: test_source_address_passive_connection() raises a ResourceWarning. Fix attached. -- nosy: +nvawda Added file: http://bugs.python.org/file21019/test_ftplib-leak.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Changes by Antoine Pitrou pit...@free.fr: -- status: closed - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Giampaolo Rodola' g.rod...@gmail.com added the comment: Thanks. Committed in r88761. -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Antoine Pitrou pit...@free.fr added the comment: Giampaolo, can you make your commit on the Mercurial repo instead? See http://mail.python.org/pipermail/python-dev/2011-March/108738.html -- status: closed - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Giampaolo Rodola' g.rod...@gmail.com added the comment: Committed in r88679. -- versions: +Python 3.3 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Giampaolo Rodola' g.rod...@gmail.com added the comment: Patch in attachment set source_address attribute and updates doc. It still keeps using support.find_unused_port() which is also used in test_socket.py though [1], so it shouldn't cause problems. http://svn.python.org/view/python/trunk/Lib/test/test_socket.py?r1=77263r2=77262pathrev=77263 -- Added file: http://bugs.python.org/file20920/ftplib_source_address.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Changes by Antoine Pitrou pit...@free.fr: -- assignee: - giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
New submission from Giampaolo Rodola' g.rod...@gmail.com: Similarly to issue 3972 the patch in attachment adds a new source_address option to FTP class to bind to a specific address when connecting to a remote FTP server. It must be noted that this gets done for both control and passive data connections (client connecting to server). The latter one solves issue 1661754. -- components: Library (Lib) files: ftplib_source_address.patch keywords: needs review, patch messages: 104749 nosy: giampaolo.rodola, pitrou, r.david.murray priority: normal severity: normal status: open title: Add a source_address option to ftplib type: feature request versions: Python 3.2 Added file: http://bugs.python.org/file17172/ftplib_source_address.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8594] Add a source_address option to ftplib
Antoine Pitrou pit...@free.fr added the comment: You should not use find_unused_port(), because it causes problems on some Windows buildbot. Also, there's something fishy in your patch, because you never set self.source_address. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8594 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
