[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Irit Katriel]

Irit Katriel  added the comment:

aifc is deprecated as per PEP 594, so there won't be further enhancements to it.

--
nosy: +iritkatriel
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I afraid we can't just change comptype to string. We can allow setcomptype() 
accept strings and convert them to bytes, but we can't change the type of 
getcomptype()'s result.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +serhiy.storchaka
versions: +Python 3.4 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Thomas Jollans]

New submission from Thomas Jollans tho...@jollans.com:

aifc getcomptype() and setcomptype() use bytes while the corresponding methods 
in the sunau and wave modules use str (b'NONE', b'ULAW' vs 'NONE', 'ULAW'). 
This means that programmers wanting simple format-agnostic audio file output 
will have to special-case aifc. This was not necessary in Python 2.x, where all 
three modules used str (obviously). IMHO, there is no reason for this 
incompatibility.

The solution I propose is to change aifc to use unicode str for information 
strings and bytes for raw data only, like the other two modules. This is, the 
way I see it, the most sensible behaviour.

I'm attaching a patch that does just this: it changes aifc to use str for all 
(non-data) strings: comptype, compname, and markers. I've also changed the 
testcase accordingly.

The problem is, obviously, that this could break existing code. I doubt that it 
would break a lot of code since:
 - not that many people use aifc anyway (I think), and py3k is still
   young
 - py3k code that's out there now would most likely handle both
   scenarios anyway to account for the wave and sunau modules
 - setcomptype() would still accept bytes.

On the other hand, it would, as I said, simplify writing format-agnostic code. 
Special-casing any module wouldn't have been necessary with Python 2, why 
should Python 3 be any different?

There, I've made my case. Georg, I put you on the nosy list because of
  [svn r64023] Remove cl usage from aifc and use bytes throughout.
You, apparently, made the decision I'm arguing should be reverted, if indeed 
anyone consciously made it at all.

If this is applied, it would have to be properly documented, of course.

--
components: Library (Lib)
files: aifc_use_str.diff
keywords: patch
messages: 107274
nosy: georg.brandl, tjollans
priority: normal
severity: normal
status: open
title: aifc should use str instead of bytes (wave, sunau compatibility)
type: behavior
versions: Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file17583/aifc_use_str.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[STINNER Victor]

Changes by STINNER Victor victor.stin...@haypocalc.com:


--
components: +Unicode
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8934] aifc should use str instead of bytes (wave, sunau compatibility)

[Thomas Jollans]

Thomas Jollans tho...@jollans.com added the comment:

tentative documentation patch uploaded

--
Added file: http://bugs.python.org/file17584/aifc_str_doc.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8934
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com