[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[karl]

karl  added the comment:

@gaurav The pull request 
https://github.com/python/cpython/pull/10870
has been closed in favor of 
https://github.com/python/cpython/pull/15773
which has already been merged.

So we can probably close here.

--
message_count: 7.0 -> 8.0
nosy: +karlcow
nosy_count: 7.0 -> 8.0
pull_requests: +16145
pull_request: https://github.com/python/cpython/pull/15773

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

I submitted Gaurav's patch as PR 10870.  Please review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Change by Alexander Belopolsky :


--
pull_requests: +10105
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Natal Ngétal]

Natal Ngétal  added the comment:

Please can you convert your patch to a pull request on github.

--
nosy: +hobbestigrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Paul Ganssle]

Change by Paul Ganssle :


--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Gaurav Tatke]

Gaurav Tatke added the comment:

Hi,
I am new to python and would like to contribute. I find this issue easy so 
changed the documentation of datetime module. I tested it with sphinx. 
Attaching a patch.

Please let me know if it is correct or needs changes.
Appreciate it!

Regards,
Gaurav

--
keywords: +patch
nosy: +Gaurav Tatke
Added file: http://bugs.python.org/file46050/timetuple_issue9004.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Mark Dickinson]

Changes by Mark Dickinson :


--
nosy:  -mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
versions: +Python 3.6 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Changes by Alexander Belopolsky alexander.belopol...@gmail.com:


--
nosy: +lemburg

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

Reclassifying this as a doc issue.

--
components: +Documentation -Extension Modules
stage: test needed - needs patch
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Changes by Alexander Belopolsky alexander.belopol...@gmail.com:


--
keywords: +easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

 Just recommend the astimezone use in the docs
and recommend creating tz-aware instances in the first time (i.e. calling 
now(utc) instead of utcnow()), +1.

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


--
versions: +Python 3.3 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

With timezone.utc available in datetime module, users should be encouraged to 
use dt.astimezone(timezone.utc).timetuple() instead of dt.utctimetuple().  Note 
that the later will set tm_isdst to -1.  This observation can be used to argue 
for either of two ways to resolve this issue:

1. Since utctimetuple() is no longer necessary, and the alternative works 
correctly, there is no need to fix it.  Just recommend the astimezone use in 
the docs and explain the subtle difference.

2. Having two ways to do the same thing which have a subtle difference is not a 
good idea.

I am leaning towards #1, but would like to hear from others.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9004] datetime.utctimetuple() should not set tm_isdst flag to 0

[Alexander Belopolsky]

New submission from Alexander Belopolsky belopol...@users.sourceforge.net:

I find the following quite misleading:

 from datetime import datetime
 import time
 time.strftime('%c %z %Z', datetime.utcnow().utctimetuple())
'Wed Jun 16 03:26:26 2010 -0500 EST'

As far as I can tell, the only other function that uses the tm_isdst flag is 
time.mktime, but it expect a timetuple containing local time, not UTC time.

--
assignee: belopolsky
components: Extension Modules
messages: 107906
nosy: belopolsky, mark.dickinson
priority: normal
severity: normal
stage: unit test needed
status: open
title: datetime.utctimetuple() should not set tm_isdst flag to 0
type: behavior
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9004
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com