[issue919238] Recursive variable definition causes sysconfig infinite loop

[Steve Dower]

Steve Dower  added the comment:

Distutils is now deprecated (see PEP 632) and all tagged issues are being 
closed. From now until removal, only release blocking issues will be considered 
for distutils.

If this issue does not relate to distutils, please remove the component and 
reopen it. If you believe it still requires a fix, most likely the issue should 
be re-reported at https://github.com/pypa/setuptools

--
nosy: +steve.dower
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Georg Brandl]

Change by Georg Brandl :


--
nosy:  -georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

Thank you for the patch. Review:

1) Why not raise an exception? A recursive variable definition is an error. 
Tarek, is this behavior change OK?

2) Does this apply to the new top-level sysconfig module and/or 
distutils.sysconfig?

3) I’d use a more specific name for the test method: test_bogus_variable 
instead of test_parse_makefile. I would also add a test for SELF=$(SELF) 
(currently there is only a test for cyclic definition, not recursive).

4) os.unlink(makefile) is not guaranteed to run, for example if the test is 
stopped or crashes. Put self.addCleanup(os.unlink, makefile) after the mkstemp 
call instead.

5) I didn’t know there was no “if __name__ == '__main__'” block in this test 
file, nice catch. There is no need for the intermediate test_main function, 
though: unittest.main() should be enough.

6) Minor style issues: You can use textwrap.dedent to keep the file contents in 
the os.write call indented; s/you're/your/; no need to del fd; put spaces 
around operators (here == and =); don’t add tree blank lines. See PEP 8 for 
more info.

--
assignee:  - tarek
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue919238
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
stage:  - patch review
versions: +Python 3.2 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue919238
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Akira Kitada]

Changes by Akira Kitada akit...@gmail.com:


--
nosy: +tarek
type:  - behavior
versions: +Python 2.7, Python 3.1 -Python 2.3, Python 2.4, Python 2.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue919238
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Ralf Schmitt]

Ralf Schmitt added the comment:

distutils.extension has:

if warnings is not None:
warnings.warn(msg)
else:
sys.stderr.write(msg + '\n')


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue919238

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Georg Brandl]

Georg Brandl added the comment:

Is a print really the right way to emit this warning?

--
nosy: +georg.brandl


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue919238

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Ralf Schmitt]

Ralf Schmitt added the comment:

This is still applies for trunk.

I've added the following lines to Makefile (in the top level directory).

SELF=$(SELFA)
SELFA=$(SELF)

Running make then hangs.
I'm attaching a patch, which fixes this issue (against trunk). Running
make now prints:

~/python-trunk/ make 
[EMAIL PROTECTED] ok
sysconfig.py: warning: could not resolve names from makefile (recursive
definition?): {'SELFA': '$(SELF)', 'SELF': '$(SELFA)'}
running build
running build_ext
INFO: Can't locate Tcl/Tk libs and/or headers

Failed to find the necessary bits to build these modules:
_bsddb_tkinter  bsddb185   
dbm   dlgdbm   
imageop   sunaudiodev  
To find the necessary bits, look in setup.py in detect_modules() for the
module's name.

running build_scripts

--
nosy: +schmir
versions: +Python 2.4, Python 2.5, Python 2.6


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue919238

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Ralf Schmitt]

Changes by Ralf Schmitt:


Added file: 
http://bugs.python.org/file9145/issue919238_sysconfig_recursive_definition.txt


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue919238

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue919238] Recursive variable definition causes sysconfig infinite loop

[Ralf Schmitt]

Changes by Ralf Schmitt:


Added file: 
http://bugs.python.org/file9146/issue919238_sysconfig_recursive_definition.txt


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue919238

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com