[issue985064] plistlib crashes too easily on bad files

2011-05-28 Thread Roundup Robot 

Roundup Robot devnull@devnull added the comment:

New changeset a2688e252204 by Ned Deily in branch '3.1':
Issue #985064: Make plistlib more resilient to faulty input plists.
http://hg.python.org/cpython/rev/a2688e252204

New changeset f555d959a5d7 by Ned Deily in branch '3.2':
Issue #985064: Make plistlib more resilient to faulty input plists.
http://hg.python.org/cpython/rev/f555d959a5d7

New changeset d0bc18a50bd1 by Ned Deily in branch 'default':
Issue #985064: Make plistlib more resilient to faulty input plists.
http://hg.python.org/cpython/rev/d0bc18a50bd1

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-05-28 Thread Ned Deily 

Ned Deily n...@acm.org added the comment:

Thank you for the patch and tests!  Applied in 3.1 (for 3.1.4), 3.2 (for 
3.2.1), and 3.3. (The 2.x version of plistlib differs somewhat from the 3.x 
version so the patch would need some rework and testing for 2.7; that is 
probably not worth the effort at this point.)

--
assignee:  - ned.deily
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.3 -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-04-10 Thread Terry J. Reedy 

Changes by Terry J. Reedy tjre...@udel.edu:


--
assignee: jvr - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-04-10 Thread Ezio Melotti 

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-01-12 Thread Éric Araujo 

Éric Araujo mer...@netwok.org added the comment:

See also reopened dependency #775321.

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-01-04 Thread Mher Movsisyan 

Mher Movsisyan mher.movsis...@gmail.com added the comment:

I've replaced plistlib.InvalidPlistError with ValueError

--
Added file: http://bugs.python.org/file20258/plist_validation_v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2011-01-04 Thread Georg Brandl 

Georg Brandl ge...@python.org added the comment:

LGTM.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2010-12-10 Thread Mher Movsisyan 

Mher Movsisyan mher.movsis...@gmail.com added the comment:

The attached patch fixes crashes on bad input. The patch implements validation 
for dict and array elements as well as some resource cleanup. The tests are 
included as well.

--
keywords: +patch
nosy: +mher
Added file: http://bugs.python.org/file19996/plist_validation.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2010-12-10 Thread Ned Deily 

Ned Deily n...@acm.org added the comment:

One review comment: the patch adds a new exception class that is used for the 
errors that are now additionally detected.  Elsewhere plistlib uses 
non-specific exception classes like ValueError.  If starting from scratch, it 
might be better to consistently use a specific exception class but that would 
create incompatibilities if changed now.  I don't see a compelling need to add 
one now just for these errors.  (But, if kept, it should be added to the docs.) 
 Otherwise, looks good to me.

Thanks for taking this on!

--
nosy: +ned.deily, ronaldoussoren
stage: unit test needed - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2010-07-10 Thread Mark Lawrence 

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2009-04-22 Thread Daniel Diniz 

Changes by Daniel Diniz aja...@gmail.com:


--
keywords: +easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2009-02-14 Thread Daniel Diniz 

Changes by Daniel Diniz aja...@gmail.com:


--
dependencies: +plistlib error handling

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue985064] plistlib crashes too easily on bad files

2009-02-14 Thread Daniel Diniz 

Changes by Daniel Diniz aja...@gmail.com:


--
stage:  - test needed
type:  - behavior
versions: +Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue985064
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com