[issue9859] Add tests to verify API match of modules with 2 implementations

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0316811f33b2 by Gregory P. Smith in branch 'default':
issue9859: add the missing versionadded tag to the documentation.
https://hg.python.org/cpython/rev/0316811f33b2

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Berker Peksag]

Berker Peksag added the comment:

Thanks :)

--
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Roundup Robot]

Roundup Robot added the comment:

New changeset c6df85e1d42e by Gregory P. Smith in branch 'default':
issue9859: Use an expected failure rather than a skip.
https://hg.python.org/cpython/rev/c6df85e1d42e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9903368b9d7b by Gregory P. Smith in branch 'default':
issue9859: rename CPyMatchTest to APIMismatchTest and add @support.cpython_only.
https://hg.python.org/cpython/rev/9903368b9d7b

New changeset cbdd56d07123 by Gregory P. Smith in branch 'default':
issue9859: Document test.support.detect_api_mismatch() and simplify its test.
https://hg.python.org/cpython/rev/cbdd56d07123

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Gregory P. Smith]

Gregory P. Smith added the comment:

Thanks!  Patch applied.  I reworded one doc string slightly and fixed up a few 
lines that were longer than 80 characters.  Berker's most recent comments are 
good ones and can be addressed in another patch.

Laura, can you jump through the 
https://www.python.org/psf/contrib/contrib-form/ hoop?  (it'll add the "*" next 
to your name in the bug tracker showing the contributor form has been signed)

Still TODO: fix the actual issue of the APIs being different. (issue9858)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Berker Peksag]

Berker Peksag added the comment:

I've added a couple of comments about the test: 
http://bugs.python.org/review/9859/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Roundup Robot]

Roundup Robot added the comment:

New changeset b42d1f2aa7a2 by Gregory P. Smith in branch 'default':
issue9859: Adds a test.support.detect_api_mismatch function useful to
https://hg.python.org/cpython/rev/b42d1f2aa7a2

New changeset 0b6c894c3c96 by Gregory P. Smith in branch 'default':
issue9859: Adds a CPyMatchTest test case to compare the exposed APIs
https://hg.python.org/cpython/rev/0b6c894c3c96

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Laura Rupprecht]

Laura Rupprecht added the comment:

Thanks Berker!

I've added some updates to the patch taking your suggestions into account. 
There is also a change from using "detect_module_matches" to 
"detect_api_mismatch", as it is a more general (and accurate) description.

Also, adding tests for the "detect_api_mismatch" helper function.

--
Added file: http://bugs.python.org/file39007/issue9859_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Berker Peksag]

Berker Peksag added the comment:

Thanks for the patch! I've reviewed it on Rietveld: 
http://bugs.python.org/review/9859/

--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
assignee:  -> gregory.p.smith
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Daniel Stutzbach]

Daniel Stutzbach added the comment:

With regret, I have not had time to work on patches and am unlikely to have 
time in the near future.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Laura Rupprecht]

Laura Rupprecht added the comment:

Created a patch to check whether classes define the same attributes.

This adds a test for RawIOBase, where Python and and C implementations are out 
of sync, but skips one of the tests as the issue (issue9858) is still 
outstanding.

--
keywords: +patch
nosy: +laura
Added file: http://bugs.python.org/file38993/issue9859.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Mark Lawrence]

Mark Lawrence added the comment:

@Daniel do you intend putting forward a formal patch on this issue?  I'm asking 
as I think issue9858 is effectively completed and I've just asked for a formal 
patch review on Issue9731.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +belopolsky, brett.cannon, eric.araujo, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Terry J. Reedy]

Terry J. Reedy  added the comment:

+1
I presume you can use the experience with #9858 to either refine the program to 
have fewer false positives or refine the program doc to explain the possibility 
where such are unavoidable. (And as a lint-like metatest, I think false 
positives are better than false negatives.)

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

Yes, exactly. :-)

(see also Issue9731, which has a similar flavor)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[R. David Murray]

R. David Murray  added the comment:

Shouldn't the test suite catch such discrepancies by testing all of the API?  
So your script catching something would be the equivalent of "oops, we forgot a 
test" (or "oops, this name shouldn't be public").  Which is not a bad thing to 
have as part of the test suite.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9859] Add tests to verify API match of modules with 2 implementations

[Daniel Stutzbach]

New submission from Daniel Stutzbach :

Recently it came to light that the classes in C and Python implementations of 
the io module have slightly different attributes (issue9858).  I propose the 
addition of a helper function in Lib/test/support.py to verify that the classes 
in two different implementations define the same attributes.  Then, we can add 
tests to use that function to verify that C and Python implementations define 
the same API (for the io module, but also for other modules where we have two 
implementations).  The script I added to issue9858 could serve as a starting 
point for such a function.

Since CPython's standard library is the de facto reference implementation, it's 
important that it define one API and not two slightly different ones. :-)

--
components: Tests
messages: 116445
nosy: stutzbach
priority: low
severity: normal
stage: needs patch
status: open
title: Add tests to verify API match of modules with 2 implementations
type: feature request
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com