[issue15539] Fixing Tools/scripts/pindent.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> 5. Fixed one type in help message.

Typo. Should be "Fixed one typo in help message."

Patch updated, unused experimental variable removed.

--
Added file: http://bugs.python.org/file26696/pindent.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15539] Fixing Tools/scripts/pindent.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Removed file: http://bugs.python.org/file26665/pindent.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15539] Fixing Tools/scripts/pindent.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> There is now a test_tools, so it would be great to have tests to go along 
> with this patch.

Well, I'll do it. But the tests most likely will be different for different 
versions of Python (in contrast to the pindent patch).

"pindent -d" and then "pindent -c" on pindent.py must give the original of 
pindent.py. It exposes some of the above mentioned bugs.

> I haven't looked at the patch in detail, but as long as you are modernizing 
> it please kill those "# end ..." lines.

This is done deliberately. It demonstrates the purpose of the script.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12428] functools test coverage

[Brian Thorne]

Brian Thorne added the comment:

Back to a simpler closure implementation of partial and skip the repr test for 
python implementation.

--
Added file: http://bugs.python.org/file26697/functools.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15559] Bad interaction between ipaddress addresses and the bytes constructor

[Nick Coghlan]

New submission from Nick Coghlan:

I've been tinkering with the ipaddress module as I review Eli's documentation 
and have uncovered a *very* nasty interaction between ipaddress objects and the 
bytes constructor.

Specifically, if you pass an integer to bytes() it will attempt to allocate and 
zero-initialise a buffer of that size. It uses operator.index() to check for 
integers.

This creates a problem, because ipaddress objects currently implement __index__ 
so they can be treated as integers without an explicit cast.

This does very bad things if, say, you do 
"bytes(ipaddress.IPv4Address('192.168.0.1'))"

If I remove the __index__ implementation, then you can't call hex() directly on 
ipaddress objects anymore - you have to call hex(int(addr)) instead.

I'm a *lot* happier with that approach, and will be implementing it in a moment.

--
messages: 167474
nosy: georg.brandl, ncoghlan, pmoody
priority: release blocker
severity: normal
status: open
title: Bad interaction between ipaddress addresses and the bytes constructor
type: crash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15559] Bad interaction between ipaddress addresses and the bytes constructor

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5abea8a43f19 by Nick Coghlan in branch 'default':
Close #15559: Implementing __index__ creates a nasty interaction with the bytes 
constructor. At least for 3.3, ipaddress objects must now be explicitly 
converted with int() and thus can't be passed directly to the hex() builtin.
http://hg.python.org/cpython/rev/5abea8a43f19

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1553375] Add traceback.print_full_exception()

[Florent Xicluna]

Florent Xicluna added the comment:

Changeset ba014543ed2c (3.2a4) references this issue.

--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15541] logging.exception doesn't accept 'extra'

[Florent Xicluna]

Florent Xicluna added the comment:

Python 3.2 was already fixed with changeset ba014543ed2c.

It would be nice to have some tests, though.

--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15560] _sqlite3.so is built with wrong include file on OS X when using an SDK

[Ned Deily]

New submission from Ned Deily:

setup.py supports building Python with an OS X SDK to allow building Python 
executables and libraries that will run on multiple versions of OS X.  There is 
an error in the SDK support code in detect_modules() for building the _sqlite3 
extension that has the effect of incorrectly using header files for libsqlite3 
from the build system's installed /usr/include rather than the selected SDK's 
usr/include. Depending on which SDK version and which OS X version of the build 
system, the effects of this bug can range from a few compile warning messages 
(and possible subtle execution errors) to a catastrophic build failure of the 
_sqlite3 extension.  The attached patches fix the problem.  One consequence of 
fixing the bug is that it is more important than ever to supply a local newer 
version of libsqlite3 if building with the obsolete MacOSX10.4u.sdk since the 
version of libsqlite3 in 10.4 is 3.1.3 and there are several conditional tests 
in the _sqlite modules to work around bugs and missing f
 eatures for versions that old, tests that were previously incorrectly checking 
the system libsqlite3 version.  (By contrast, the version of libsqlite3 in 
MacOSX10.5.sdk is 3.4.0, old but usable; 10.6 has 3.6.12).

--
assignee: ned.deily
components: Build, Macintosh
messages: 167478
nosy: ned.deily
priority: high
severity: normal
stage: patch review
status: open
title: _sqlite3.so is built with wrong include file on OS X when using an SDK
versions: Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15560] _sqlite3.so is built with wrong include file on OS X when using an SDK

[Ned Deily]

Changes by Ned Deily :


--
keywords: +patch
Added file: http://bugs.python.org/file26698/issue15560_sqlite3_sdk.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15560] _sqlite3.so is built with wrong include file on OS X when using an SDK

[Ned Deily]

Changes by Ned Deily :


--
stage: patch review -> commit review
Added file: http://bugs.python.org/file26699/issue15560_sqlite3_sdk_27_32.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Antoine Pitrou]

Antoine Pitrou added the comment:

> We should not convert \n with -u command line option or PYTHONUNBUFFERED was 
> set.

Why that? What do universal newlines have to do with buffering?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15077] Regexp match goes into infinite loop

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> invalid
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15239] Abandoned Tools/unicode/mkstringprep.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review -patch
priority: normal -> low
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15239] Abandoned Tools/unicode/mkstringprep.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15144] Possible integer overflow in operations with addresses and sizes.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> Ah;  were the strict aliasing problems already there before the patch?  I 
>didn't check.

Please open separate issue for this.

--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15144] Possible integer overflow in operations with addresses and sizes.

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review
priority: normal -> low

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15202] followlinks/follow_symlinks/symlinks flags unification

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Martin v . Löwis]

Martin v. Löwis added the comment:

I wonder why this is a release blocker. It's a bug in Python 3.2, so why should 
it block the release of 3.3 (it's not a regression).

If no complete solution is coming up, I recommend to revert all changes on this 
issue, and reconsider after the 3.3 release.

--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15378] Underported Tools/unicode/comparecodecs.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review
priority: normal -> low
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15379] Charmap decoding of no-BMP characters

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review
priority: normal -> low
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15379] Charmap decoding of no-BMP characters

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Antoine Pitrou]

Antoine Pitrou added the comment:

> I wonder why this is a release blocker. It's a bug in Python 3.2, so
> why should it block the release of 3.3 (it's not a regression).

It's a blocker because the fix broke a couple of tests.
And it's also a regression from 3.1 and 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15216] Support setting the encoding on a text stream after creation

[Martin v . Löwis]

Martin v. Löwis added the comment:

I fail to see why this is a release blocker; no rationale is given in the 
original message, nor in the quoted message. So unblocking.

--
nosy: +loewis
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15475] Correct __sizeof__ support for itertools

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4508] distutils compiler not handling spaces in path to output/src files

[Brian Thorne]

Brian Thorne added the comment:

I've put together a patch adding the test requested. There is no problem on my 
Ubuntu machine with python 3.3.
There is a comment in the file saying Don't load the xx module more than once, 
I am unsure whether my patch (using a renamed c file) violates this?


One extremely minor nitpick that I'll mention is inconsistency with spaces in 
the module name. One can create a python file "my file.py" and can import it 
with __import__("my file"). I couldn't do the same for a C extension.

Building a C extension with distutils:

  module_name = 'ex ample'
  example_ext = Extension(module_name, [target_c])
  dist = Distribution({'name': module_name, 'ext_modules': [example_ext]})

Doesn't work due to the import mechanism looks for a PyInit function with the 
new module name (including a space):

  ImportError: dynamic module does not define init function (PyInit_ex ample)

I don't think this is worth making a ticket over.

--
Added file: http://bugs.python.org/file26700/distutils_space_test.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15490] Correct __sizeof__ support for StringIO

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15513] Correct __sizeof__ support for pickle

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Martin v . Löwis]

Martin v. Löwis added the comment:

> It's a blocker because the fix broke a couple of tests.

That cannot possibly be the explanation why haypo declared
it a blocker on 2012-08-01; the fix was only applied on
2012-08-04.

But I agree that it should block the release now; hence I
propose to roll back the entire set of changes and revert
to the 3.2 state.

> And it's also a regression from 3.1 and 2.7.

Since 3.2 was released with this behavior, this bug cannot manage
to block 3.3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15539] Fixing Tools/scripts/pindent.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +needs review
priority: normal -> low
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4997] xml.sax.saxutils.XMLGenerator should write to io.RawIOBase.

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> duplicate
superseder:  -> Bugfix for #1470540 (XMLGenerator cannot output UTF-16)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Atsuo Ishimoto]

Atsuo Ishimoto added the comment:

Antoine Pitrou added the comment:
>
>> We should not convert \n with -u command line option or PYTHONUNBUFFERED was 
>> set.
>
> Why that? What do universal newlines have to do with buffering?

Man page of Python says 

  -u Force  stdin,  stdout  and  stderr to be totally unbuffered.  On
 systems where it matters, also put stdin, stdout and  stderr  in
 binary  mode.   

test_httpservers depends on this behavior, but was implemented as documented in 
Python 3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15381] Optimize BytesIO to so less reallocations when written, similarly to StringIO

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15424] __sizeof__ of array should include size of items

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ludwig, you can use some helpers from test.support (see issue15467) for 
__sizeof__ testing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15522] impove 27 percent performance on stringpbject.c( by prefetch and loop optimization)

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Antoine Pitrou]

Antoine Pitrou added the comment:

> Man page of Python says 
> 
>   -u Force  stdin,  stdout  and  stderr to be totally unbuffered.  On
>  systems where it matters, also put stdin, stdout and  stderr  in
>  binary  mode.   

I don't know which version it is, but current 3.3 says:

“Force the binary I/O layers of stdin, stdout and  stderr  to  be
unbuffered.  The text I/O layer will still be line-buffered.”

> test_httpservers depends on this behavior, but was implemented as
> documented in Python 3.

I would argue that test_httpservers is wrong, since it uses print() in a
CGI script where sys.stdout.buffer.write() should really be used.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13498] os.makedirs exist_ok documentation is incorrect, as is some of the behavior

[Hynek Schlawack]

Hynek Schlawack added the comment:

How about something along of:

new arg on_wrong_perm=

1. WRONG_PERM_IGNORE
2. WRONG_PERM_FAIL
3. callable that gets called with the directory name and maybe the existing 
perms to save stat call_

?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Roundup Robot]

Roundup Robot added the comment:

New changeset b513ad06d1fa by Nick Coghlan in branch 'default':
Issue 14814: Docs work showed some more cases of networks pretending to be 
addresses and highlighted the weird approach to implementing the 'is_whatever' 
properties. Impl now illustrates far more clearly that networks have a property 
if both their network and broadcast addresses have that property
http://hg.python.org/cpython/rev/b513ad06d1fa

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Eli Bendersky]

Eli Bendersky added the comment:

Nick, your commit incorporates my latest patch (ipaddr_refdoc_network.2.patch), 
right?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Nick Coghlan]

Nick Coghlan added the comment:

It actually wasn't meant to, as I only meant to commit the code changes (I was 
still working on the docs, using your patch as a starting point).

However, it makes more sense to just finish my changes and commit them rather 
than reverting anything.

(Good attempt by the way, but it was your 'networks have all the attributes of 
addresses' that got me digging deeper, since that isn't meant to be true any 
more)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15546] Iteration breaks with bz2.open(filename,'rt')

[Nadeem Vawda]

Nadeem Vawda added the comment:

Before these fixes, it looks like all three classes' peek() methods were 
susceptible
to the same problem as read1().

The fixes for BZ2File.read1() and LZMAFile.read1() should have fixed peek() as 
well;
both methods are implemented in terms of _fill_buffer().

For GzipFile, peek() is still potentially broken - I'll push a fix shortly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Roundup Robot]

Roundup Robot added the comment:

New changeset cf8d42596a44 by Nick Coghlan in branch 'default':
Issue #14814: Finish review of ipaddress network object docs (initial patch was 
by Eli Bendersky)
http://hg.python.org/cpython/rev/cf8d42596a44

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Roundup Robot]

Roundup Robot added the comment:

New changeset cf9526db1a7e by Nick Coghlan in branch 'default':
Issue #14814: Remove redundant property from interface objects - prefixlen can 
be accessed via the associated network object
http://hg.python.org/cpython/rev/cf9526db1a7e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Nick Coghlan]

Nick Coghlan added the comment:

I'm still not overjoyed with the "this isn't documented here, go read it over 
there" situation. However, duplicating the text everywhere isn't ideal either. 
So, let's finish it up with my current approach: explicitly listing the methods 
and attributes on each class where the documentation is elsewhere.

For Interface objects, there's no need to repeat the documentation for the 
corresponding Address object, since there's a real inheritance relationship 
there.

Fortunately, that makes the list of attributes still to be documented fairly 
short:

   ip (raw address with no network info)
   network (the network definition)
   with_prefixlen
   with_hostmask
   with_netmask

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15546] Iteration breaks with bz2.open(filename,'rt')

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8c07ff7f882f by Nadeem Vawda in branch 'default':
#15546: Also fix GzipFile.peek().
http://hg.python.org/cpython/rev/8c07ff7f882f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14814] Implement PEP 3144 (the ipaddress module)

[Roundup Robot]

Roundup Robot added the comment:

New changeset abbae7314b52 by Nick Coghlan in branch 'default':
Issue #14814: Attempt to clarify network address and broadcast address for less 
experienced users
http://hg.python.org/cpython/rev/abbae7314b52

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Roundup Robot]

Roundup Robot added the comment:

New changeset bc4fdb758b8c by Antoine Pitrou in branch '3.2':
Fix CGI tests to take into account the platform's line ending (issue #13119)
http://hg.python.org/cpython/rev/bc4fdb758b8c

New changeset ee185c6b2880 by Antoine Pitrou in branch 'default':
Fix CGI tests to take into account the platform's line ending (issue #13119)
http://hg.python.org/cpython/rev/ee185c6b2880

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[STINNER Victor]

STINNER Victor added the comment:

Buildbots are happy, the issue can be closed again. Thanks Antoine.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15546] Iteration breaks with bz2.open(filename,'rt')

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I have a doubts. Is it not a dead cycle if the end of the compressed data will 
happen on the end of reading block? Maybe instead of "while self.extrasize <= 
0:" worth to write "while self.extrasize <= 0 and self.fileobj is not None:"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13119] Newline for print() is \n on Windows, and not \r\n as expected

[Atsuo Ishimoto]

Atsuo Ishimoto added the comment:

> I don't know which version it is, but current 3.3 says:

Ah, sorry, I thought I was reading latest Man page.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15528] Better support for finalization with weakrefs

[Richard Oudkerk]

Richard Oudkerk added the comment:

Updated patch.

get() and put() replaced by peek() and detach().  Added isalive().  Now 
finalizer class has no state, i.e. __slots__ == ().

--
Added file: http://bugs.python.org/file26701/finalize.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15548] Mention all new os functions in What's New in Python 3.3

[Roundup Robot]

Roundup Robot added the comment:

New changeset b7b8e4ada3e5 by Victor Stinner in branch 'default':
Issue #15548: Update and complete What's New in Python 3.3, especially the "os" 
section
http://hg.python.org/cpython/rev/b7b8e4ada3e5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15546] Iteration breaks with bz2.open(filename,'rt')

[Nadeem Vawda]

Nadeem Vawda added the comment:

No, if _read() is called once the file is already at EOF, it raises an
EOFError (http://hg.python.org/cpython/file/8c07ff7f882f/Lib/gzip.py#l433),
which will then break out of the loop.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15492] textwrap.wrap expand_tabs does not behave as expected

[Chris Jerdonek]

Chris Jerdonek added the comment:

I didn't have a chance to respond before you closed this issue.  I will add 
more information later if that is okay. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15528] Better support for finalization with weakrefs

[Antoine Pitrou]

Antoine Pitrou added the comment:

I don't understand why you have two names: finalize and Finalizer. Let's keep 
only one of them.

isalive() could be a read-only property named "alive" instead.

In _make_callback, I still think the default error reporting mechanism should 
be kept. It can be improved separately.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15554] correct and clarify str.splitlines() documentation

[Chris Jerdonek]

Chris Jerdonek added the comment:

> I wasn't really happy with the addition of that sentence about split in the 
> first place.

I think the instinct to put that sentence in there is a good one.  It is a key, 
perhaps subtle difference.

> I don't understand what your splitlines examples are trying to say, they all 
> look clear to me based on the fact that we are splitting *lines*.  

I perhaps included too many examples and so clouded my point. :)  I just needed 
one.  The examples were simply to show why the existing language is not 
correct.  The current language says, "if the string ends with line boundary 
characters the returned list does not have an empty last element."

However, the examples are of strings that do end with line boundary characters 
but that *do* have an empty last element.

The point is that splitlines() does not count a terminal line break as an 
additional line, while split('\n') (for example) does.  But this is different 
from whether the returned list *has* an empty last element, which is what the 
current language says.

The returned list can have empty last elements because of line breaks at the 
end.  It's just that the one at the *very* end doesn't count towards that -- 
unlike the case for split():

>>> 'a'.splitlines()
['a']
>>> 'a\n'.splitlines()
['a']
>>> 'a\n\n'.splitlines()
['a', '']
>>> 'a\n\n\n'.splitlines()
['a', '', '']
>>> 'a\n\n\n'.split('\n')  # counts terminal line break as an extra line
['a', '', '', '']

I'm open to improving the language.  Maybe "does not count a terminal line 
break as an additional line" instead of the original "a terminal line break 
does not delimit an additional empty line"?

> There's another issue for creating a central description of universal-newline 
> parsing, perhaps this entry could link to that discussion (and that 
> discussion could perhaps mention splitlines).

I created that issue (issue 15543), and a patch is in the works along the lines 
you suggest. ;)

> The split behavior without a specified separator might actually be a bug (if 
> so, it is not a fixable one), but in any case you are right that that 
> clarification should be added if the existing sentence is kept.

Perhaps, but at least split() documents the behavior. :)

"runs of consecutive whitespace are regarded as a single separator, and the 
result will contain no empty strings at the start or end if the string has 
leading or trailing whitespace."

(from http://docs.python.org/dev/library/stdtypes.html#str.split )

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15554] correct and clarify str.splitlines() documentation

[Chris Jerdonek]

Chris Jerdonek added the comment:

Attaching patch with simplified wording in response to R. David Murray's 
feedback.

In particular, "a terminal line break does not delimit an additional empty 
line" -> "a terminal line break does not result in an extra line."

--
Added file: http://bugs.python.org/file26702/issue-15554-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15531] os.path symlink docs missing

[Dave Abrahams]

Dave Abrahams added the comment:

on Sat Aug 04 2012, Larry Hastings  wrote:

> Larry Hastings added the comment:
>
> What does the following script print out?
>
> import os
>
> os.chdir('/tmp')
> os.symlink('--success--', 'foo')
> print("this should print --success-- :")
> print(os.readlink('foo'))
> os.unlink('foo')

--8<---cut here---start->8---
this should print --success-- :
--success--
--8<---cut here---end--->8---

So, I guess I don't know what was causing the symptom I observed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15163] pydoc displays __loader__ as module data

[Brett Cannon]

Brett Cannon added the comment:

Can you still not commit this patch, Eric?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15561] update subprocess docs to reference io.TextIOWrapper

[Chris Jerdonek]

New submission from Chris Jerdonek:

This is an issue to update the subprocess module documentation after updates to 
io.TextIOWrapper's documentation here: 

http://hg.python.org/cpython/rev/f17a1410ebe5

This issue was discussed briefly on python-dev:

http://mail.python.org/pipermail/python-dev/2012-August/121239.html

Patch attached.

--
assignee: docs@python
components: Documentation
files: issue-subprocess-docs-1.patch
keywords: easy, patch
messages: 167512
nosy: cjerdonek, docs@python, haypo
priority: normal
severity: normal
stage: patch review
status: open
title: update subprocess docs to reference io.TextIOWrapper
versions: Python 3.3
Added file: http://bugs.python.org/file26703/issue-subprocess-docs-1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15531] os.path symlink docs missing

[Larry Hastings]

Larry Hastings added the comment:

Since everything is working fine, and the documentation arguably needs no 
update, I'm closing this.

--
resolution:  -> works for me
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15239] Abandoned Tools/unicode/mkstringprep.py

[Martin v . Löwis]

Martin v. Löwis added the comment:

The difference is in the reverse direction, right? I.e. the special case for 
U+0130 is removed.

This is harmless: it just means that we don't need to special-case that anymore.

I'm puzzled though that b3_exceptions doesn't become empty in 3.3. Supposedly, 
B.3 is CaseFolding.txt, and supposedly, Python 3.3 supports CaseFolding.txt. 
For example, CaseFolding maps U+00B5 to U+03BC in lower case, yet Python 3.3 
maps it to U+00B5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[Martin v . Löwis]

New submission from Martin v. Löwis:

IIUC, Python 3.3 is intended to support CaseFolding.txt. In

http://unicode.org/Public/UNIDATA/CaseFolding.txt

U+00B5 maps to U+03BC. However, in 3.3.0b1 (80a1ae3a1b39), 
ascii('\u00b5'.lower()) gives '\xb5'.

--
messages: 167515
nosy: benjamin.peterson, loewis
priority: normal
severity: normal
status: open
title: CaseFolding not working properly
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[Florent Xicluna]

Changes by Florent Xicluna :


--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[STINNER Victor]

STINNER Victor added the comment:

Hum, strange.

$ ./python 
Python 3.3.0b1 (default:b7b8e4ada3e5+, Aug  5 2012, 16:19:18) 
[GCC 4.6.3 20120306 (Red Hat 4.6.3-2)] on linux
>>> print(ascii('\xb5'.casefold()))
'\u03bc'

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[Benjamin Peterson]

Benjamin Peterson added the comment:

Naturally, you have to use casefold():

>>> hex(ord("\u00b5".casefold()))
'0x3bc'

--
resolution:  -> invalid
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[Benjamin Peterson]

Changes by Benjamin Peterson :


--
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15562] CaseFolding not working properly

[Chris Jerdonek]

Chris Jerdonek added the comment:

Yes, the documentation for str.casefold() suggests that lower() is not meant to 
casefold:

"For example, the German lowercase letter 'ß' is equivalent to "ss". Since it 
is already lowercase, lower() would do nothing to 'ß'; casefold() converts it 
to "ss"."

http://docs.python.org/dev/library/stdtypes.html#str.casefold

--
nosy: +cjerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15560] _sqlite3.so is built with wrong include file on OS X when using an SDK

[Roundup Robot]

Roundup Robot added the comment:

New changeset ef6c6d8adcf5 by Ned Deily in branch '2.7':
Issue #15560: Fix building _sqlite3 extension on OS X with an SDK.
http://hg.python.org/cpython/rev/ef6c6d8adcf5

New changeset ee0ac9a0461f by Ned Deily in branch '3.2':
Issue #15560: Fix building _sqlite3 extension on OS X with an SDK.
http://hg.python.org/cpython/rev/ee0ac9a0461f

New changeset d706a6f4724c by Ned Deily in branch 'default':
Issue #15560: null merge
http://hg.python.org/cpython/rev/d706a6f4724c

New changeset 6af33673e955 by Ned Deily in branch 'default':
Issue #15560: Fix building _sqlite3 extension on OS X with an SDK.
http://hg.python.org/cpython/rev/6af33673e955

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13072] Getting a buffer from a Unicode array uses invalid format

[Roundup Robot]

Roundup Robot added the comment:

New changeset 95da47ddebe0 by Victor Stinner in branch 'default':
Close #13072: Restore code before the PEP 393 for the array module
http://hg.python.org/cpython/rev/95da47ddebe0

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13072] Getting a buffer from a Unicode array uses invalid format

[STINNER Victor]

STINNER Victor added the comment:

Oops, the initial issue is not solved. Attached fixes the array == memoryview 
issue by using a valid format for the buffer.

--
resolution: fixed -> 
status: closed -> open
Added file: http://bugs.python.org/file26704/array_unicode_format.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13072] Getting a buffer from a Unicode array uses invalid format

[STINNER Victor]

STINNER Victor added the comment:

Hum, this issue is a regression from Python 3.2. I would like to see it fixed 
in Python 3.3. Example:

Python 3.2.3+ (3.2:243ad1a6f638+, Aug  4 2012, 01:36:41) 
[GCC 4.6.3 20120306 (Red Hat 4.6.3-2)] on linux2
>>> import array
>>> a=array.array('u', 'xyz')
>>> b=memoryview(a)
>>> a == b
True
>>> b == a
True

--
priority: normal -> release blocker
versions:  -Python 2.7, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15471] importlib's __import__() argument style nit

[Brett Cannon]

Brett Cannon added the comment:

Attached is a patch that drops all mutable default arguments to __import__() 
and updates the docs. I went with Barry's approach but made it compatible with 
PEP 8 (bad, FLUFL; no unneeded parens!). I also ignored the locals argument 
since __import__ doesn't even use it.

Assigning to Georg as a release blocker to make a call as to whether I can 
apply this to 3.3 of if I need to wait until 3.4 since this is not a critical 
fix but a good thing to do. Just assign back to me once the decision has been 
made.

--
assignee: brett.cannon -> georg.brandl
nosy: +georg.brandl
priority: low -> release blocker
stage: patch review -> commit review
Added file: http://bugs.python.org/file26705/immutable_defaults_for_import.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15560] _sqlite3.so is built with wrong include file on OS X when using an SDK

[Ned Deily]

Ned Deily added the comment:

Committed for release in 2.7.4, 3.2.4, and 3.3.0.

--
resolution:  -> fixed
stage: commit review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7897] Support parametrized tests in unittest

[Bradley Froehle]

Changes by Bradley Froehle :


--
nosy: +bfroehle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15502] Meta path finders and path entry finders are different, but share an ABC

[Brett Cannon]

Brett Cannon added the comment:

Eric's latest patch LGTM except for the missing patch for 
test.test_importlib.test_abc to fix the inheritance checks.

Nick, Eric Smith, or Barry: can you double-check the patch is good? About the 
only thing that might be questionable is having MetaPathFinder and 
PathEntryFinder not inherit from Finder itself, but that does make sense and we 
do have multiple inheritance for a reason in Python.

--
stage: needs patch -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15482] __import__() change between 3.2 and 3.3

[Brett Cannon]

Brett Cannon added the comment:

I just realized my reply was unclear; I meant changing 
Doc/library/functions.rst, not the code.

And 3.3 already has a versionchanged note about no longer accepting negative 
indexes, but I will update it to mention the new default as well explicitly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15471] importlib's __import__() argument style nit

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15482] __import__() change between 3.2 and 3.3

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3fe01f7520e2 by Brett Cannon in branch '3.2':
Issue #15482: Properly document the default 'level' parameter for
http://hg.python.org/cpython/rev/3fe01f7520e2

New changeset 05bec2e78a5c by Brett Cannon in branch 'default':
Issue #15482: Merge 78449:3fe01f7520e2 with a minor clarification.
http://hg.python.org/cpython/rev/05bec2e78a5c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15482] __import__() change between 3.2 and 3.3

[Brett Cannon]

Changes by Brett Cannon :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15522] impove 27 percent performance on stringpbject.c( by prefetch and loop optimization)

[abael]

abael added the comment:

do i need to fully maintain Python ?

2012/8/5 Serhiy Storchaka 

>
> Changes by Serhiy Storchaka :
>
>
> --
> status: open -> pending
>
> ___
> Python tracker 
> 
> ___
>

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15522] impove 27 percent performance on stringpbject.c( by prefetch and loop optimization)

[R. David Murray]

R. David Murray added the comment:

We are happy that you wish to contribute; however, our policy is that 
performance enhancements only go in to the newest version of Python, which 
means any submitted patch must be against the 'default' branch of the Python 
mercurial repository.  If you wish to propose a patch against default, we will 
be happy to review it.  If you do not wish to do so, we will close the issue, 
and your patch will remain available here on the tracker to anyone who wishes 
to apply it by hand to their own Python 2.7 installation.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15492] textwrap.wrap expand_tabs does not behave as expected

[R. David Murray]

R. David Murray added the comment:

Sure.  If you convince me we can reopen the issue :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15554] correct and clarify str.splitlines() documentation

[R. David Murray]

R. David Murray added the comment:

Ah, now I see what you are talking about.  Yes, your revision in the comment is 
clearer; but, unless I read it wrong, in the patch it now sounds like you are 
saying that ''.splitlines() does not return the same result as ''.split() when 
in fact it does.

I would also prefer that the "differences" discussion come in the separate 
paragraph after the specification of the behavior of the function, rather than 
the way you have it split up in the patch.  I would include the mention of the 
lack-of-extra-line as part of the differences discussion: as I said I think 
that behavior follows logically from the fact that the function is splitting 
lines and so doesn't belong in the basic function description.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15550] Trailing white spaces

[Terry J. Reedy]

Terry J. Reedy added the comment:

How is it more of a nuisance for C files than for .py files?
Editor 'trim trailing' tools certainly don't care.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15554] correct and clarify str.splitlines() documentation

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14182] collections.Counter equality test thrown-off by zero counts

[Stephen Webber]

Stephen Webber added the comment:

This is intentional handling of non-existant variables, and is not resticted to 
'==' operations. Returning the value of a Counter parameter that has not yet 
been set returns 0 by default.

See the documentation here:
http://docs.python.org/library/collections.html

"Counter objects have a dictionary interface except that they return a zero 
count for missing items instead of raising a KeyError:"

Since this is intended behavior, I recommend this bug become closed.

--
nosy: +ForeverBacchus

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Chris Jerdonek]

Chris Jerdonek added the comment:

Attaching a patch for review.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file26706/issue-15543-1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15550] Trailing white spaces

[Chris Jerdonek]

Chris Jerdonek added the comment:

Out of curiosity, is there a mechanism to bypass the hook on a per-file basis, 
if necessary?  FWIW, the WebKit open source project had a similar hook (for 
SVN) to prevent the inclusion of tabs in source files, and a custom SVN 
property was used to bypass the check on a per-file basis.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15471] importlib's __import__() argument style nit

[Meador Inge]

Meador Inge added the comment:

LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15554] correct and clarify str.splitlines() documentation

[Chris Jerdonek]

Chris Jerdonek added the comment:

> in the patch it now sounds like you are saying that ''.splitlines() does not 
> return the same result as ''.split() when in fact it does.

The two differences occur only when split() is passed a separator.  split() 
uses a different algorithm when no separator is specified.  For example, for 
the empty string case:

>>> ''.splitlines()
[]
>>> ''.split()
[]
>>> ''.split('\n')
['']

That is why I used the phrase "Unlike split() when passed a separator" in the 
patch:

+   Unlike :meth:`~str.split` when passed a separator, this method returns
+   an empty list for the empty string, and a terminal line break does not

I will change the language in the patch to parallel split()'s documentation 
more closely, to emphasize and make this distinction clearer: "when passed a 
separator" -> "when a delimiter string *sep* is given".

> I would also prefer that the "differences" discussion come in the separate 
> paragraph after the specification of the behavior of the function,

Good point.  I agree with you.  That occurred to me while drafting the patch, 
but I was hesitant to change the existing structure too much.

In the updated patch I am attaching, I have also made that change.  Thanks a 
lot for reviewing!

--
Added file: http://bugs.python.org/file26707/issue-15554-3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15352] importlib.h should be regenerated when the marshaling code changes

[Meador Inge]

Meador Inge added the comment:

Yup, it is still an issue.  The recent activity was mostly related to Windows 
builds (issue15431).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15471] importlib's __import__() argument style nit

[Georg Brandl]

Georg Brandl added the comment:

Looks good and safe to me. +1.

--
assignee: georg.brandl -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13072] Getting a buffer from a Unicode array uses invalid format

[Georg Brandl]

Georg Brandl added the comment:

Victor: the revert commit brought back "Python's Unicode character type" into 
the docs.  This needs to be fixed to say "legacy" somewhere, as the characters 
in a normal Unicode string are not of that type anymore.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com