Re: [python-committers] Guide to pushing to submitters' repo?

[Carol Willing]

> On May 25, 2017, at 8:59 AM, Antoine Pitrou  wrote:
> 
> 
> Le 25/05/2017 à 17:52, Carol Willing a écrit :
>>> 
>>> Thanks for the pointer.  Unfortunately, it seems that it really wants to
>>> authenticate using username and password (even though browsing a public
>>> project):
>>> 
>>> $ hub checkout https://github.com/python/cpython/pull/1785
>>> github.com username: pitrou
>>> github.com password for pitrou (never stored): ^C
>> 
>> Antoine, do you have an SSH key stored within your GitHub account settings?
> 
> Yes, I do.
> 
>> You would still use the same command for hub to checkout the pull request, 
>> but GitHub would stop nagging for username/password.
> 
> Apparently not...

Looking at the hub man page https://hub.github.com/hub.1.html 
, hub uses an OAuth token which is probably 
not set or not being found by the hub app.

See Configuration section and GitHub OAuth subsection in the man page. Hope 
that helps.


> 
> Regards
> 
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Proposing Carol Willing to become a core developer

[Eric Snow]

On Thu, May 25, 2017 at 4:16 AM, Victor Stinner
 wrote:
> Welcome Carol!

A giant +1 from me!  And a huge thank-you for how much you've already
been doing!  You are an excellent example of what makes this community
great.

-eric
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Antoine Pitrou]

Le 25/05/2017 à 17:52, Carol Willing a écrit :
>>
>> Thanks for the pointer.  Unfortunately, it seems that it really wants to
>> authenticate using username and password (even though browsing a public
>> project):
>>
>> $ hub checkout https://github.com/python/cpython/pull/1785
>> github.com username: pitrou
>> github.com password for pitrou (never stored): ^C
> 
> Antoine, do you have an SSH key stored within your GitHub account settings?

Yes, I do.

> You would still use the same command for hub to checkout the pull request, 
> but GitHub would stop nagging for username/password.

Apparently not...

Regards

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Carol Willing]

> On May 25, 2017, at 7:41 AM, Antoine Pitrou  wrote:
> 
> 
> Le 25/05/2017 à 16:05, Zachary Ware a écrit :
>> 
>> Unfortunately, GitHub does not allow pushing back to refs/pull/*.  To
>> get it to set you up to push back to the contributor's repo, you'd
>> need to provide the contributor's name and branch name, which is much
>> less convenient if you're just looking to try out a patch locally
>> without intending to push anything back.  If I can figure out a good
>> second alias for that, I'll be sure to share it.
> 
> If I knew how to do that, I certainly would :-)
> 
>> You may be interested in the `hub` tool, which has a command for
>> 'check out this PR and set up a remote for it' (though I can't
>> remember what it is at the moment).
> 
> Thanks for the pointer.  Unfortunately, it seems that it really wants to
> authenticate using username and password (even though browsing a public
> project):
> 
> $ hub checkout https://github.com/python/cpython/pull/1785
> github.com username: pitrou
> github.com password for pitrou (never stored): ^C

Antoine, do you have an SSH key stored within your GitHub account settings?

You would still use the same command for hub to checkout the pull request, but 
GitHub would stop nagging for username/password.

> 
> Regards
> 
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Antoine Pitrou]

Le 25/05/2017 à 16:05, Zachary Ware a écrit :
> 
> Unfortunately, GitHub does not allow pushing back to refs/pull/*.  To
> get it to set you up to push back to the contributor's repo, you'd
> need to provide the contributor's name and branch name, which is much
> less convenient if you're just looking to try out a patch locally
> without intending to push anything back.  If I can figure out a good
> second alias for that, I'll be sure to share it.

If I knew how to do that, I certainly would :-)

> You may be interested in the `hub` tool, which has a command for
> 'check out this PR and set up a remote for it' (though I can't
> remember what it is at the moment).

Thanks for the pointer.  Unfortunately, it seems that it really wants to
authenticate using username and password (even though browsing a public
project):

$ hub checkout https://github.com/python/cpython/pull/1785
github.com username: pitrou
github.com password for pitrou (never stored): ^C

Regards

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Zachary Ware]

On Thu, May 25, 2017 at 6:27 AM, Antoine Pitrou  wrote:
>
> Le 25/05/2017 à 15:06, Nick Coghlan a écrit :
>> On 25 May 2017 at 18:01, Antoine Pitrou  wrote:
>>> Did someone manage to make this work?  Can they post the entire
>>> instructions they used? (including local branch setup)
>>
>> The minimal set of instructions some of us worked out are at
>> https://docs.python.org/devguide/gitbootcamp.html#editing-a-pull-request-prior-to-merging
>> (the initial draft was longer, but patch review found a few
>> opportunities for simplification)
>
> Thank you.  Is it possible for the "git pr" alias to also edit the
> branch tracking information?  Currently I get:
>
> (master)$ git pr 1785
> Depuis https://github.com/python/cpython
>  * [nouvelle référence] refs/pull/1785/head -> pr_1785
> Basculement sur la branche 'pr_1785'
>
> (pr_1785)$ LANG=C git pull
> There is no tracking information for the current branch.
> Please specify which branch you want to merge with.
> See git-pull(1) for details.
>
> git pull  
>
> If you wish to set tracking information for this branch you can do so with:
>
> git branch --set-upstream-to=/ pr_1785

Unfortunately, GitHub does not allow pushing back to refs/pull/*.  To
get it to set you up to push back to the contributor's repo, you'd
need to provide the contributor's name and branch name, which is much
less convenient if you're just looking to try out a patch locally
without intending to push anything back.  If I can figure out a good
second alias for that, I'll be sure to share it.

You may be interested in the `hub` tool, which has a command for
'check out this PR and set up a remote for it' (though I can't
remember what it is at the moment).

-- 
Zach
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Mariatta Wijaya]

The git pr alias in the devguide assumes that you have origin and upstream
remote setup,
where origin is your own CPython fork, and upstream is python/CPython repo


On May 25, 2017 6:27 AM, "Antoine Pitrou"  wrote:


Le 25/05/2017 à 15:06, Nick Coghlan a écrit :
> On 25 May 2017 at 18:01, Antoine Pitrou  wrote:
>> Did someone manage to make this work?  Can they post the entire
>> instructions they used? (including local branch setup)
>
> The minimal set of instructions some of us worked out are at
> https://docs.python.org/devguide/gitbootcamp.html#
editing-a-pull-request-prior-to-merging
> (the initial draft was longer, but patch review found a few
> opportunities for simplification)

Thank you.  Is it possible for the "git pr" alias to also edit the
branch tracking information?  Currently I get:

(master)$ git pr 1785
Depuis https://github.com/python/cpython
 * [nouvelle référence] refs/pull/1785/head -> pr_1785
Basculement sur la branche 'pr_1785'

(pr_1785)$ LANG=C git pull
There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

git pull  

If you wish to set tracking information for this branch you can do so with:

git branch --set-upstream-to=/ pr_1785


Regards

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Antoine Pitrou]

Le 25/05/2017 à 15:06, Nick Coghlan a écrit :
> On 25 May 2017 at 18:01, Antoine Pitrou  wrote:
>> Did someone manage to make this work?  Can they post the entire
>> instructions they used? (including local branch setup)
> 
> The minimal set of instructions some of us worked out are at
> https://docs.python.org/devguide/gitbootcamp.html#editing-a-pull-request-prior-to-merging
> (the initial draft was longer, but patch review found a few
> opportunities for simplification)

Thank you.  Is it possible for the "git pr" alias to also edit the
branch tracking information?  Currently I get:

(master)$ git pr 1785
Depuis https://github.com/python/cpython
 * [nouvelle référence] refs/pull/1785/head -> pr_1785
Basculement sur la branche 'pr_1785'

(pr_1785)$ LANG=C git pull
There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

git pull  

If you wish to set tracking information for this branch you can do so with:

git branch --set-upstream-to=/ pr_1785


Regards

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Guide to pushing to submitters' repo?

[Nick Coghlan]

On 25 May 2017 at 18:01, Antoine Pitrou  wrote:
> Did someone manage to make this work?  Can they post the entire
> instructions they used? (including local branch setup)

The minimal set of instructions some of us worked out are at
https://docs.python.org/devguide/gitbootcamp.html#editing-a-pull-request-prior-to-merging
(the initial draft was longer, but patch review found a few
opportunities for simplification)

However, that can still fail if the submitter hasn't checked the
"Allow edits by maintainers" option on their PR.

Cheers,
Nick.

P.S. the "git pr" alias mentioned there is detailed a few entries
earlier in the cheat sheet

-- 
Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Proposing Carol Willing to become a core developer

[Carol Willing]

Thank you for developing, supporting, and growing Python. Your impact on 
science and education is so valuable, and I hope to continue encouraging users 
and learners of Python.

Thanks for all of the kind words. (Victor, I loved your summary of all the ways 
that people contribute to making the Python community and language.)

In the spirit of a Monty Python introduction...

What is your name? Carol

What is your quest? To combine Python and Jupyter to inspire and teach others.

What is the air-speed velocity of an unladen swallow? For an African or 
European swallow, you can use Python, numpy, and Jupyter to calculate, explain, 
and share this information.

A special thank you to Guido for encouragement, kindness, and conversations 
about electronics tinkering. I look forward to working with the CPython team.

Warmly,

Carol

Carol Willing

Research Software Engineer
Project Jupyter at Cal Poly SLO

Director, Python Software Foundation

Signature Strengths
Empathy - Relator - Ideation - Strategic - Learner


> On May 24, 2017, at 10:15 AM, Brett Cannon  wrote:
> 
> Done!
> 
> Carol, just accept the invitation to join the Python core team on GitHub at 
> https://github.com/python  and that's it! (I 
> already subscribed you to python-committers under your Gmail account and 
> Mariatta is taking care of recording the granting of your commit privileges.)
> 
> On Wed, 24 May 2017 at 08:16 Guido van Rossum  > wrote:
> OK, I think we have enough +1 votes... Brett, will you make it happen?
> 
> On Wed, May 24, 2017 at 12:25 AM, Nick Coghlan  > wrote:
> On 24 May 2017 at 04:15, Brett Cannon  > wrote:
> > While at the PyCon US sprints the idea came up of offering Carol Willing
> > developer privileges. Everyone at the table -- about 6 of us -- liked the
> > idea and Carol also said she would happy to become a core dev, so I'm
> > officially putting her forward for consideration.
> >
> > For those of you who don't know Carol, she basically knows our developer
> > workflow better than most of us. :) ; she's very active on the devguide and
> > core-mentorship. Carol has also attended the PyCon US language summit two
> > years in a row as a representative for the Jupyter project. She is actually
> > so good with new people that she managed to get my wife to make her first
> > open source contribution (something I never managed to do).
> >
> > As usual, if you support/object to this idea, please say so. :)
> 
> Definite +1 from me (I was actually thinking of emailing Carol about
> the idea before I saw this thread)
> 
> Cheers,
> Nick.
> 
> --
> Nick Coghlan   |   ncogh...@gmail.com    |   
> Brisbane, Australia
> ___
> python-committers mailing list
> python-committers@python.org 
> https://mail.python.org/mailman/listinfo/python-committers 
> 
> Code of Conduct: https://www.python.org/psf/codeofconduct/ 
> 
> 
> 
> 
> -- 
> --Guido van Rossum (python.org/~guido )

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Proposing Carol Willing to become a core developer

[Victor Stinner]

Welcome Carol!

Victor

Le 24 mai 2017 7:41 PM, "Brett Cannon"  a écrit :

> Done!
>
> Carol, just accept the invitation to join the Python core team on GitHub
> at https://github.com/python and that's it! (I already subscribed you to
> python-committers under your Gmail account and Mariatta is taking care of
> recording the granting of your commit privileges.)
>
> On Wed, 24 May 2017 at 08:16 Guido van Rossum  wrote:
>
>> OK, I think we have enough +1 votes... Brett, will you make it happen?
>>
>> On Wed, May 24, 2017 at 12:25 AM, Nick Coghlan 
>> wrote:
>>
>>> On 24 May 2017 at 04:15, Brett Cannon  wrote:
>>> > While at the PyCon US sprints the idea came up of offering Carol
>>> Willing
>>> > developer privileges. Everyone at the table -- about 6 of us -- liked
>>> the
>>> > idea and Carol also said she would happy to become a core dev, so I'm
>>> > officially putting her forward for consideration.
>>> >
>>> > For those of you who don't know Carol, she basically knows our
>>> developer
>>> > workflow better than most of us. :) ; she's very active on the
>>> devguide and
>>> > core-mentorship. Carol has also attended the PyCon US language summit
>>> two
>>> > years in a row as a representative for the Jupyter project. She is
>>> actually
>>> > so good with new people that she managed to get my wife to make her
>>> first
>>> > open source contribution (something I never managed to do).
>>> >
>>> > As usual, if you support/object to this idea, please say so. :)
>>>
>>> Definite +1 from me (I was actually thinking of emailing Carol about
>>> the idea before I saw this thread)
>>>
>>> Cheers,
>>> Nick.
>>>
>>> --
>>> Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
>>>
>> ___
>>> python-committers mailing list
>>> python-committers@python.org
>>> https://mail.python.org/mailman/listinfo/python-committers
>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>>
>>
>>
>>
>> --
>> --Guido van Rossum (python.org/~guido)
>>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Guide to pushing to submitters' repo?

[Antoine Pitrou]

Hi,

We now have a functionality to allow core developers to push to PR
repositories, but I can't find out how to make it work.

For example I have:

$ git remote -v
gescheitgit://github.com/gescheit/cpython.git (fetch)
gescheitgit://github.com/gescheit/cpython.git (push)
origin  https://github.com/python/cpython (fetch)
origin  https://github.com/python/cpython (push)
pitrou  g...@github.com:pitrou/cpython.git (fetch)
pitrou  g...@github.com:pitrou/cpython.git (push)

Then I try:

$ git push
fatal: remote error:
  You can't push to git://github.com/gescheit/cpython.git
  Use https://github.com/gescheit/cpython.git


So I try with the HTTPS URL instead:

$ git remote set-url gescheit https://github.com/gescheit/cpython.git
$ git push
Username for 'https://github.com': ^C


Did someone manage to make this work?  Can they post the entire
instructions they used? (including local branch setup)

(Context: trying to edit https://github.com/python/cpython/pull/1785)

Thank you

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/