Re: [python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Carol Willing 
Welcome Petr :D We're glad to have you on board.

Warmly,

Carol

On Mon, Apr 23, 2018 at 11:45 AM, Antoine Pitrou  wrote:

>
> Le 23/04/2018 à 16:39, Nick Coghlan a écrit :
> > Hi folks,
> >
> > With my recent proposal to accept Petr Viktorin as a specialist core
> > developer focusing on extension module imports receiving several +1's
> > and no concerns being raised, I'm happy to report that Brett has now
> > granted Petr his additional access on GitHub, the issue tracker, and
> > this mailing list.
>
> Welcome Petr!  You have a lot of gruesome work ahead ;-)
> (just kidding: I'm sure you'll have fun on the way)
>
> Regards
>
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>



-- 
*Carol Willing*

Research Software Engineer
Project Jupyter at Cal Poly SLO

cawil...@calpoly.edu

*Signature strengths*
*Empathy - Relator - Ideation - Strategic - Learner*
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] missing email thread [was: Welcoming Petr ...]

2018-04-23 Thread Ethan Furman 

On 04/23/2018 09:37 AM, Christian Heimes wrote:> On 2018-04-23 17:43, Ethan 
Furman wrote:
>> On 04/23/2018 07:39 AM, Nick Coghlan wrote:

>>> With my recent proposal to accept Petr Viktorin as a specialist core
>>> developer focusing on extension module imports receiving several +1's
>>> and no concerns being raised,
>>
>> Where did this conversation take place?  I see no record of it here nor
>> on the Zulip Chat channels.
>
> We discussed the matter 10 days ago on this very mailing list,
> https://mail.python.org/pipermail/python-committers/2018-April/005276.html

Huh.  I keep 30 days worth of email for Python-Committers but I don't have that 
thread.

If anybody has any ideas on what might have happened I'd love to hear them!  I use Thunderbird on Ubuntu 12.  (I'm 
pretty sure I didn't delete the thread. ;) )


--
~Ethan~
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Antoine Pitrou 

Le 23/04/2018 à 16:39, Nick Coghlan a écrit :
> Hi folks,
> 
> With my recent proposal to accept Petr Viktorin as a specialist core
> developer focusing on extension module imports receiving several +1's
> and no concerns being raised, I'm happy to report that Brett has now
> granted Petr his additional access on GitHub, the issue tracker, and
> this mailing list.

Welcome Petr!  You have a lot of gruesome work ahead ;-)
(just kidding: I'm sure you'll have fun on the way)

Regards

Antoine.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

2018-04-23 Thread Brett Cannon 
On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:

> On 4/22/2018 12:16 PM, Serhiy Storchaka wrote:
> > miss-islington is an awesome bot! It makes fixing bugs in multiple
> > versions much simpler. You need just accept automatically created
> > backporting PRs.
> >
> > But there is a downside. miss-islington makes the life so easier, that
> > sometimes you forgot about not finished backports. miss-islington can
> > fail to backport some changes for different reasons. Currently on GitHub
> > there are tens merged PRs labeled for backporting, but backports were
> > not finished. Please take attention if your PRs in one of the following
> > lists:
>
> Does github allow repository owners to send email directly to people who
> have submitted PRs or at least, people with commit privileges (in this
> case, those whose have done particular merges)?
>

No. People have to provide explicit permission to expose their email
address. Otherwise the best we have are @ mentions in a comment.

-Brett


>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed
>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed
>
> Several of these were closed without merging and should not and cannot
> be backported.  For instance, you closed
> https://github.com/python/cpython/pull/4225
> after you submitted and merged a replacement.
> https://github.com/python/cpython/pull/6259
>
> Stripping backport labels off of rejected PRs could be considered.  But
> this would toss information needed for a new PR if the bpo issue is
> open.  Expecting either the submitter or merged of a replacement to go
> back and clean up the original seems a bit much.  The submitter might
> not be able to, and the merger might not know or forget that the PR is a
> replacement.  Perhaps rejected PRs should just be ignored.
>
> Replacing 'closed' with 'merged' excludes rejected PRs.
>
>
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged
>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed
>
>
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged
>
> The 2.7 backport of https://github.com/python/cpython/pull/3639
> is yours.
>
> tjr
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Christian Heimes 
On 2018-04-23 17:43, Ethan Furman wrote:
> On 04/23/2018 07:39 AM, Nick Coghlan wrote:
> 
>> With my recent proposal to accept Petr Viktorin as a specialist core
>> developer focusing on extension module imports receiving several +1's
>> and no concerns being raised,
> 
> Where did this conversation take place?  I see no record of it here nor
> on the Zulip Chat channels.

We discussed the matter 10 days ago on this very mailing list,
https://mail.python.org/pipermail/python-committers/2018-April/005276.html

>> I'm happy to report that Brett has now
>> granted Petr his additional access on GitHub, the issue tracker, and
>> this mailing list.
>>
>> Welcome, Petr! :)
> 
> Yes, welcome, Petr!

Welcome! :)

Christian
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Ethan Furman 

On 04/23/2018 07:39 AM, Nick Coghlan wrote:


With my recent proposal to accept Petr Viktorin as a specialist core
developer focusing on extension module imports receiving several +1's
and no concerns being raised,


Where did this conversation take place?  I see no record of it here nor on the 
Zulip Chat channels.


I'm happy to report that Brett has now
granted Petr his additional access on GitHub, the issue tracker, and
this mailing list.

Welcome, Petr! :)


Yes, welcome, Petr!

--
~Ethan~

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Eric Snow 
Welcome, Petr!

-eric

On Mon, Apr 23, 2018, 08:39 Nick Coghlan  wrote:

> Hi folks,
>
> With my recent proposal to accept Petr Viktorin as a specialist core
> developer focusing on extension module imports receiving several +1's
> and no concerns being raised, I'm happy to report that Brett has now
> granted Petr his additional access on GitHub, the issue tracker, and
> this mailing list.
>
> Welcome, Petr! :)
>
> Cheers,
> Nick.
>
> P.S. When adjusting the nosy list on the issue tracker, you'll find
> there's also a new "extension modules" topic, which can be selected to
> subscribe both Petr and I to the issue :)
>
> --
> Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Welcoming Petr Viktorin as our newest core developer :)

2018-04-23 Thread Nick Coghlan 
Hi folks,

With my recent proposal to accept Petr Viktorin as a specialist core
developer focusing on extension module imports receiving several +1's
and no concerns being raised, I'm happy to report that Brett has now
granted Petr his additional access on GitHub, the issue tracker, and
this mailing list.

Welcome, Petr! :)

Cheers,
Nick.

P.S. When adjusting the nosy list on the issue tracker, you'll find
there's also a new "extension modules" topic, which can be selected to
subscribe both Petr and I to the issue :)

-- 
Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

2018-04-23 Thread Serhiy Storchaka 

22.04.18 21:27, Terry Reedy пише:

Replacing 'closed' with 'merged' excludes rejected PRs.


Thank you, this gives cleaner result.


The 2.7 backport of https://github.com/python/cpython/pull/3639
is yours.


I thought you taken it.

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/