Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Ivan Levkivskyi]

Thank you, Victor!

--
Ivan



On 8 December 2017 at 16:47, Victor Stinner 
wrote:

> 2017-12-06 17:57 GMT+01:00 Mariatta Wijaya :
> > Please add Ivan to the Developer Log in Dev Guide, and he should
> subscribe
> > to python-committers mailing list :)
>
> I added Ivan to the Devguide:
> https://github.com/python/devguide/commit/f414589365e8d3808eaef3cf9f2b73
> 70314133a1
>
> Victor
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Victor Stinner]

2017-12-06 17:57 GMT+01:00 Mariatta Wijaya :
> Please add Ivan to the Developer Log in Dev Guide, and he should subscribe
> to python-committers mailing list :)

I added Ivan to the Devguide:
https://github.com/python/devguide/commit/f414589365e8d3808eaef3cf9f2b7370314133a1

Victor
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Ivan Levkivskyi]

Thank you Mariatta, Ethan, Eric, Guido, and everyone!
I am overwhelmed by all the positive comments!

I am so glad to be the part of the team and looking forward to make more
contributions.
(Will start right now form polishing PEP 560 and PEP 562 implementation :-)

--
Ivan


On 6 December 2017 at 19:20, Mariatta Wijaya 
wrote:

> Welcome to the team, Ivan!
>
> Mariatta Wijaya
>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Ethan Furman]

Ivan,

Welcome!  Glad to have you!

--
~Ethan~
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[R. David Murray]

On Wed, 06 Dec 2017 08:43:56 -0800, Guido van Rossum  wrote:
> I think I figured it out -- I invited him to the python org on GitHub.
> Anything else?

He needs to subscribe to this mailing list, and the developers.rst in
the devguide repo should get an update.

That's all I can think of, since ssh keys are now handled by github,
but if there are other github things that need done I might not know
them ;)

Ah, it's all (or should be) in coredev.rst.  I don't see anything else
that needs done, though he should read that doc.

--David
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Ned Deily]

On Dec 6, 2017, at 11:57, Mariatta Wijaya  wrote:
> On Dec 6, 2017 8:44 AM, "Guido van Rossum"  wrote:
>> I think I figured it out -- I invited him to the python org on GitHub. 
>> Anything else?
> Please add Ivan to the Developer Log in Dev Guide, and he should subscribe to 
> python-committers mailing list :) 

It should all be here in the Devguide:

https://devguide.python.org/coredev/#gaining-commit-privileges

--
  Ned Deily
  n...@python.org -- []

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Mariatta Wijaya]

Please add Ivan to the Developer Log in Dev Guide, and he should subscribe
to python-committers mailing list :)



On Dec 6, 2017 8:44 AM, "Guido van Rossum"  wrote:

I think I figured it out -- I invited him to the python org on GitHub.
Anything else?
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Alex Gaynor]

Someone needs to invite him to this list :-)

On Dec 6, 2017 11:44 AM, "Guido van Rossum"  wrote:

> I think I figured it out -- I invited him to the python org on GitHub.
> Anything else?
>
> On Wed, Dec 6, 2017 at 8:37 AM, Guido van Rossum  wrote:
>
>> OK, let's make it so. It's been a long time since I initiated a new
>> committer -- what has to happen next? I just flipped his committer bit on
>> bpo, is there anything else that needs to happen?
>>
>> On Wed, Dec 6, 2017 at 8:27 AM, Yury Selivanov 
>> wrote:
>>
>>> +1 from me.  I first had an idea to give Ivan commit privileges when I
>>> was merging his PEP 526 implementation, so I think it's long overdue.
>>>
>>> Yury
>>>
>>> On Tue, Dec 5, 2017 at 8:00 PM, Guido van Rossum 
>>> wrote:
>>> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
>>> > (re-)written most of the typing.py module and will do so again for
>>> Python
>>> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560,
>>> 562),
>>> > is co-author on several more (483, 561) and has been acknowledged in
>>> yet
>>> > others (557, 563).
>>> >
>>> > He is responsible for at least 16 commits in master.
>>> >
>>> > I have worked with him for a long time on typing.py and on mypy (where
>>> he is
>>> > a core dev) and I can vouch for him completely.
>>> >
>>> > --
>>> > --Guido van Rossum (python.org/~guido)
>>> >
>>> > ___
>>> > python-committers mailing list
>>> > python-committers@python.org
>>> > https://mail.python.org/mailman/listinfo/python-committers
>>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>>> >
>>>
>>
>>
>>
>> --
>> --Guido van Rossum (python.org/~guido)
>>
>
>
>
> --
> --Guido van Rossum (python.org/~guido)
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Guido van Rossum]

I think I figured it out -- I invited him to the python org on GitHub.
Anything else?

On Wed, Dec 6, 2017 at 8:37 AM, Guido van Rossum  wrote:

> OK, let's make it so. It's been a long time since I initiated a new
> committer -- what has to happen next? I just flipped his committer bit on
> bpo, is there anything else that needs to happen?
>
> On Wed, Dec 6, 2017 at 8:27 AM, Yury Selivanov 
> wrote:
>
>> +1 from me.  I first had an idea to give Ivan commit privileges when I
>> was merging his PEP 526 implementation, so I think it's long overdue.
>>
>> Yury
>>
>> On Tue, Dec 5, 2017 at 8:00 PM, Guido van Rossum 
>> wrote:
>> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
>> > (re-)written most of the typing.py module and will do so again for
>> Python
>> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560,
>> 562),
>> > is co-author on several more (483, 561) and has been acknowledged in yet
>> > others (557, 563).
>> >
>> > He is responsible for at least 16 commits in master.
>> >
>> > I have worked with him for a long time on typing.py and on mypy (where
>> he is
>> > a core dev) and I can vouch for him completely.
>> >
>> > --
>> > --Guido van Rossum (python.org/~guido)
>> >
>> > ___
>> > python-committers mailing list
>> > python-committers@python.org
>> > https://mail.python.org/mailman/listinfo/python-committers
>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >
>>
>
>
>
> --
> --Guido van Rossum (python.org/~guido)
>



-- 
--Guido van Rossum (python.org/~guido)
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Guido van Rossum]

OK, let's make it so. It's been a long time since I initiated a new
committer -- what has to happen next? I just flipped his committer bit on
bpo, is there anything else that needs to happen?

On Wed, Dec 6, 2017 at 8:27 AM, Yury Selivanov 
wrote:

> +1 from me.  I first had an idea to give Ivan commit privileges when I
> was merging his PEP 526 implementation, so I think it's long overdue.
>
> Yury
>
> On Tue, Dec 5, 2017 at 8:00 PM, Guido van Rossum  wrote:
> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
> > (re-)written most of the typing.py module and will do so again for Python
> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560,
> 562),
> > is co-author on several more (483, 561) and has been acknowledged in yet
> > others (557, 563).
> >
> > He is responsible for at least 16 commits in master.
> >
> > I have worked with him for a long time on typing.py and on mypy (where
> he is
> > a core dev) and I can vouch for him completely.
> >
> > --
> > --Guido van Rossum (python.org/~guido)
> >
> > ___
> > python-committers mailing list
> > python-committers@python.org
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
>



-- 
--Guido van Rossum (python.org/~guido)
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Yury Selivanov]

+1 from me.  I first had an idea to give Ivan commit privileges when I
was merging his PEP 526 implementation, so I think it's long overdue.

Yury

On Tue, Dec 5, 2017 at 8:00 PM, Guido van Rossum  wrote:
> I'd like to propose Ivan Levkivskyi as a new core committer. He's
> (re-)written most of the typing.py module and will do so again for Python
> 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562),
> is co-author on several more (483, 561) and has been acknowledged in yet
> others (557, 563).
>
> He is responsible for at least 16 commits in master.
>
> I have worked with him for a long time on typing.py and on mypy (where he is
> a core dev) and I can vouch for him completely.
>
> --
> --Guido van Rossum (python.org/~guido)
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Carol Willing]

+1 for nice work on the PEPs

> On Dec 6, 2017, at 4:26 AM, Andrew Svetlov  wrote:
> 
> +1
> 
> On Wed, Dec 6, 2017 at 5:47 AM Nick Coghlan  > wrote:
> On 6 December 2017 at 11:00, Guido van Rossum  > wrote:
> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
> > (re-)written most of the typing.py module and will do so again for Python
> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562),
> > is co-author on several more (483, 561) and has been acknowledged in yet
> > others (557, 563).
> >
> > He is responsible for at least 16 commits in master.
> >
> > I have worked with him for a long time on typing.py and on mypy (where he is
> > a core dev) and I can vouch for him completely.
> 
> +1 from me - I found him very receptive to feedback and easy to work
> with when discuss his proposed changes to the runtime typing
> machinery.
> 
> Cheers,
> Nick.
> 
> --
> Nick Coghlan   |   ncogh...@gmail.com    |   
> Brisbane, Australia
> ___
> python-committers mailing list
> python-committers@python.org 
> https://mail.python.org/mailman/listinfo/python-committers 
> 
> Code of Conduct: https://www.python.org/psf/codeofconduct/ 
> 
> -- 
> Thanks,
> Andrew Svetlov
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Andrew Svetlov]

+1

On Wed, Dec 6, 2017 at 5:47 AM Nick Coghlan  wrote:

> On 6 December 2017 at 11:00, Guido van Rossum  wrote:
> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
> > (re-)written most of the typing.py module and will do so again for Python
> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560,
> 562),
> > is co-author on several more (483, 561) and has been acknowledged in yet
> > others (557, 563).
> >
> > He is responsible for at least 16 commits in master.
> >
> > I have worked with him for a long time on typing.py and on mypy (where
> he is
> > a core dev) and I can vouch for him completely.
>
> +1 from me - I found him very receptive to feedback and easy to work
> with when discuss his proposed changes to the runtime typing
> machinery.
>
> Cheers,
> Nick.
>
> --
> Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
-- 
Thanks,
Andrew Svetlov
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Nick Coghlan]

On 6 December 2017 at 11:00, Guido van Rossum  wrote:
> I'd like to propose Ivan Levkivskyi as a new core committer. He's
> (re-)written most of the typing.py module and will do so again for Python
> 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562),
> is co-author on several more (483, 561) and has been acknowledged in yet
> others (557, 563).
>
> He is responsible for at least 16 commits in master.
>
> I have worked with him for a long time on typing.py and on mypy (where he is
> a core dev) and I can vouch for him completely.

+1 from me - I found him very receptive to feedback and easy to work
with when discuss his proposed changes to the runtime typing
machinery.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Terry Reedy]

On 12/5/2017 8:00 PM, Guido van Rossum wrote:
I'd like to propose Ivan Levkivskyi as a new core committer. He's 
(re-)written most of the typing.py module and will do so again for 
Python 3.7, he's the sole or primary author on several PEPs (526, 544, 
560, 562), is co-author on several more (483, 561) and has been 
acknowledged in yet others (557, 563).


He is responsible for at least 16 commits in master.

I have worked with him for a long time on typing.py and on mypy (where 
he is a core dev) and I can vouch for him completely.


Please bring him on.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Ethan Furman]

On 12/05/2017 05:00 PM, Guido van Rossum wrote:


I'd like to propose Ivan Levkivskyi as a new core committer.


I thought he already was one.

+1 to bring him in!

--
~Ethan~

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Guido van Rossum]

Well he also wrote and implemented PEP 562 (overriding __getattr__ and
__dir__ on modules). I'd be happy to tell him to gain other developers'
trust before barging into other areas. But isn't that how all core devs
work by default?

On Tue, Dec 5, 2017 at 5:07 PM, Victor Stinner 
wrote:

> Hi Guido,
>
> Since the typing module is out of my interest area, I didn't notice
> Ivan contributions, so it's hard for me to give an opinion.
>
> Should I understand that he will mostly contribute to the typing
> module? If (in the beginning?) we restrict him to the typing module, I
> will simply rely on your judgment Guido. I know that you are following
> the topic closely and so are very good to estimate his skills.
>
> I'm not talking about technically restricting Ivan to the typing
> module. It's more that I expect him to request an approval by other
> core developers if he wants to touch other parts of CPython. In my
> experience, developers are already doing that naturally, but I would
> prefer to clarify this point.
>
> Victor
>
> 2017-12-06 2:00 GMT+01:00 Guido van Rossum :
> > I'd like to propose Ivan Levkivskyi as a new core committer. He's
> > (re-)written most of the typing.py module and will do so again for Python
> > 3.7, he's the sole or primary author on several PEPs (526, 544, 560,
> 562),
> > is co-author on several more (483, 561) and has been acknowledged in yet
> > others (557, 563).
> >
> > He is responsible for at least 16 commits in master.
> >
> > I have worked with him for a long time on typing.py and on mypy (where
> he is
> > a core dev) and I can vouch for him completely.
> >
> > --
> > --Guido van Rossum (python.org/~guido)
> >
> > ___
> > python-committers mailing list
> > python-committers@python.org
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
>



-- 
--Guido van Rossum (python.org/~guido)
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Eric V. Smith]

+1, without reservation. He was an immense help to me on PEP 557. 

--
Eric.

> On Dec 5, 2017, at 8:00 PM, Guido van Rossum  wrote:
> 
> I'd like to propose Ivan Levkivskyi as a new core committer. He's 
> (re-)written most of the typing.py module and will do so again for Python 
> 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562), is 
> co-author on several more (483, 561) and has been acknowledged in yet others 
> (557, 563).
> 
> He is responsible for at least 16 commits in master.
> 
> I have worked with him for a long time on typing.py and on mypy (where he is 
> a core dev) and I can vouch for him completely.
> 
> -- 
> --Guido van Rossum (python.org/~guido)
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Adding Ivan Levkivskyi as a core committer

[Victor Stinner]

Hi Guido,

Since the typing module is out of my interest area, I didn't notice
Ivan contributions, so it's hard for me to give an opinion.

Should I understand that he will mostly contribute to the typing
module? If (in the beginning?) we restrict him to the typing module, I
will simply rely on your judgment Guido. I know that you are following
the topic closely and so are very good to estimate his skills.

I'm not talking about technically restricting Ivan to the typing
module. It's more that I expect him to request an approval by other
core developers if he wants to touch other parts of CPython. In my
experience, developers are already doing that naturally, but I would
prefer to clarify this point.

Victor

2017-12-06 2:00 GMT+01:00 Guido van Rossum :
> I'd like to propose Ivan Levkivskyi as a new core committer. He's
> (re-)written most of the typing.py module and will do so again for Python
> 3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562),
> is co-author on several more (483, 561) and has been acknowledged in yet
> others (557, 563).
>
> He is responsible for at least 16 commits in master.
>
> I have worked with him for a long time on typing.py and on mypy (where he is
> a core dev) and I can vouch for him completely.
>
> --
> --Guido van Rossum (python.org/~guido)
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Adding Ivan Levkivskyi as a core committer

[Guido van Rossum]

I'd like to propose Ivan Levkivskyi as a new core committer. He's
(re-)written most of the typing.py module and will do so again for Python
3.7, he's the sole or primary author on several PEPs (526, 544, 560, 562),
is co-author on several more (483, 561) and has been acknowledged in yet
others (557, 563).

He is responsible for at least 16 commits in master.

I have worked with him for a long time on typing.py and on mypy (where he
is a core dev) and I can vouch for him completely.

-- 
--Guido van Rossum (python.org/~guido)
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/