[python-committers] Re: GitHub pull requests
On 7/9/2020 3:29 PM, Mariatta wrote: If you want the associated bpo ticket to be closed when the PR is merged, you have to add the commit message saying "closes " (Note that we should document this: https://github.com/python/devguide/issues/502) If there are backports, which is nearly always for me, I prefer to not close until the issue is really done. Once could edit the commit message of the last one, but cannot know which of two will be last until one is merged. ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/ZALDQ4LRXLASWBZSRGKYU2SJ7MPPN2P5/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
On 7/9/2020 3:24 PM, Mariatta wrote: is it closed automatically ? What is "it"? The PR itself? yes the PR becomes closed if it is merged. The branch in your github fork is not automatically deleted. There is a button on the PR to do so. I don't know if the devguide mentions this. The branch on your local repository is not automatically deleted when the branch on your fork is deleted. I try to remember to do it manually after hitting the button. I occassionally look through the fork branches for those that are obsolete. ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/ETWSV2GJJX6YK2PAL3RKMBFEOL53GUUG/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
On 7/9/2020 4:01 PM, Mariatta wrote: Is there a way to do this if you have automerge set? I don't see a way to control the commit message in that case, but I could easily be missing something. Yes, you need to edit the PR description. Automerge will take the PR description as the commit message. Ah. Thanks! Eric ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/PBFHRMR7HBF2HBN6NOVHWG5KFXP4DYXI/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
> > Is there a way to do this if you have automerge set? I don't see a way to > control the commit message in that case, but I could easily be missing > something. Yes, you need to edit the PR description. Automerge will take the PR description as the commit message. ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/OV5Q3UA4LMGIWSIBQFBJBLBMX75JJFCM/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
On 7/9/2020 3:29 PM, Mariatta wrote: If you want the associated bpo ticket to be closed when the PR is merged, you have to add the commit message saying "closes " (Note that we should document this: https://github.com/python/devguide/issues/502) Is there a way to do this if you have automerge set? I don't see a way to control the commit message in that case, but I could easily be missing something. Eric If you want the the associated GitHub Issue to be closed, it is similar, you have to add to the commit message or the PR description: "closes " Documentation: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/ZQJKTDWXL2SMVVNPIJJN4HX7SG4Q6NPU/ Code of Conduct: https://www.python.org/psf/codeofconduct/ ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/JYE3EBQLYB5J5MKNDMDECGTS5M54IONQ/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
If you want the associated bpo ticket to be closed when the PR is merged, you have to add the commit message saying "closes " (Note that we should document this: https://github.com/python/devguide/issues/502) If you want the the associated GitHub Issue to be closed, it is similar, you have to add to the commit message or the PR description: "closes " Documentation: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/ZQJKTDWXL2SMVVNPIJJN4HX7SG4Q6NPU/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: GitHub pull requests
> > is it closed automatically ? What is "it"? The PR itself? yes the PR becomes closed if it is merged. ___ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-le...@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/77HEHSO33T72T25NKRGKRNHOS2HATD6G/ Code of Conduct: https://www.python.org/psf/codeofconduct/
