Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Nick Coghlan 
On 2 August 2017 at 07:09, Christian Heimes  wrote:
> I suggested teams to make the file a bit easier to maintain. The rule
> format works differently than the old mentionbot format. In the old
> format we had a relationship user -> files. The new CODEOWNERS format
> has files -> users mapping with last rules trumps all semantic. We have
> to be careful to not override parts of a previous rules. I believe teams
> reduce the burden.

+1 for setting up teams, and +1 for an importlib-team :)

Cheers,
Nick.

-- 
Nick Coghlan   |   [email protected]   |   Brisbane, Australia
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Terry Reedy 

On 8/2/2017 10:37 AM, Nick Coghlan wrote:

On 2 August 2017 at 07:09, Christian Heimes  wrote:

I suggested teams to make the file a bit easier to maintain. The rule
format works differently than the old mentionbot format. In the old
format we had a relationship user -> files. The new CODEOWNERS format
has files -> users mapping with last rules trumps all semantic. We have
to be careful to not override parts of a previous rules. I believe teams
reduce the burden.


+1 for setting up teams, and +1 for an importlib-team :)


Do people on a team have to be core-developers?

Terry

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Steve Dower 
Should we seed the teams from the experts list?

I have no strong opinion about core vs non-core dev, but I think part of the 
point of the distinction is reflected here. Why would we notify someone about 
every PR in an area if we don’t want them to be committers?

Top-posted from my Windows phone

From: Terry Reedy
Sent: Wednesday, August 2, 2017 11:21
To: [email protected]
Subject: Re: [python-committers] mention-bot is dead,long live the (misnamed) 
CODEOWNERS file!

On 8/2/2017 10:37 AM, Nick Coghlan wrote:
> On 2 August 2017 at 07:09, Christian Heimes  wrote:
>> I suggested teams to make the file a bit easier to maintain. The rule
>> format works differently than the old mentionbot format. In the old
>> format we had a relationship user -> files. The new CODEOWNERS format
>> has files -> users mapping with last rules trumps all semantic. We have
>> to be careful to not override parts of a previous rules. I believe teams
>> reduce the burden.
> 
> +1 for setting up teams, and +1 for an importlib-team :)

Do people on a team have to be core-developers?

Terry

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Senthil Kumaran 
Only committers can merge stuff. So, that would make a requirement that
reviewers  (and @team-of-reviwers)should be core-dev / committers.

On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower  wrote:

> Should we seed the teams from the experts list?
>
>
>
> I have no strong opinion about core vs non-core dev, but I think part of
> the point of the distinction is reflected here. Why would we notify someone
> about every PR in an area if we don’t want them to be committers?
>
>
>
> Top-posted from my Windows phone
>
>
>
> *From: *Terry Reedy 
> *Sent: *Wednesday, August 2, 2017 11:21
> *To: *[email protected]
> *Subject: *Re: [python-committers] mention-bot is dead,long live the
> (misnamed) CODEOWNERS file!
>
>
>
> On 8/2/2017 10:37 AM, Nick Coghlan wrote:
>
> > On 2 August 2017 at 07:09, Christian Heimes 
> wrote:
>
> >> I suggested teams to make the file a bit easier to maintain. The rule
>
> >> format works differently than the old mentionbot format. In the old
>
> >> format we had a relationship user -> files. The new CODEOWNERS format
>
> >> has files -> users mapping with last rules trumps all semantic. We have
>
> >> to be careful to not override parts of a previous rules. I believe teams
>
> >> reduce the burden.
>
> >
>
> > +1 for setting up teams, and +1 for an importlib-team :)
>
>
>
> Do people on a team have to be core-developers?
>
>
>
> Terry
>
>
>
> ___
>
> python-committers mailing list
>
> [email protected]
>
> https://mail.python.org/mailman/listinfo/python-committers
>
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
>
> ___
> python-committers mailing list
> [email protected]
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Terry Reedy 

Rearranging things in order. I asked
> Do people on a team have to be core-developers?

The broader question is whether active people who want notifications 
have to be a committer to get automatic notifications of a PR and in 
particular a review request.  It appears that anyone with a github 
account can review python PRs and that anyone who does submit a review, 
as opposed to comments, gets listed under Reviews.


Moreover, we *want* more reviews from non-committer contributors.  To 
encourage this, Martin Loewis once offered to review any patch in 
exchange for 5 reviews by such people, even if brief.  I understood that 
the hope of getting more such reviews was one of the reasons for the switch.


On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower > wrote:



I have no strong opinion about core vs non-core dev, but I think
part of the point of the distinction is reflected here. Why would we
notify someone about every PR in an area if we don’t want them to be
committers?


I not sure what 'them' you are speaking of.  I am thinking about active 
contributors who are potential committers.  Part of becoming a committer 
is demonstrating the ability to do committer-qualify reviews.


On 8/2/2017 7:06 PM, Senthil Kumaran wrote:
> Only committers can merge stuff. So, that would make a requirement that
> reviewers  (and @team-of-reviwers)should be core-dev / committers.

If we were using the list as an actual 'code owner' list, I would not 
have asked.  But it was said that we are not using it that way and that 
there is no plan to turn on the 'owner' feature.


--
Terry Jan Reedy


___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Please edit the commit message when merge a PR

2017-08-02 Thread Serhiy Storchaka 

11.07.17 19:39, Brett Cannon пише:
There's isn't a way to block a merge at that stage. But one thing I've 
been thinking about is adding a check to Bedevere post-merge that sees 
if the commit message was left unchanged (not quite sure  if I can come 
up with a reliable heuristic, though). In instances where the committers 
forgot, Bedevere would simply leave a message saying something like, 
"Hey, thanks for taking the time to merge a PR, but please don't forget 
to clean up the commit message before merging." Basically a friendly 
reminder to not forget next time (I'm also thinking of doing something 
similar for the formatting of the PR title after merging).


+1 for adding a post-merge check and a friendly reminder. I still see 
merged commits containing messages from all intermediate changes. I'm 
afraid that it would be rough from my side to remind about this every 
time, but the bot is impartial.


___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/