Re: [python-committers] AppVeyor is now required to pass on PRs
Hi, AppVeyor usually takes between 30 min and 1 hour to check a PR, whereas Travis CI takes between 10 and 20 minutes (in average, ignoring rare cases when it's broken). AppVeyor queue is regulary busy. Sometimes, I know that my PR is right, because the fix is obvious. Sometimes, the PR has no impact on Windows. In these cases, the slow AppVeyor CI can be annoying since it prevents me to merge a PR. What do you think of making AppVeyor optional again? Careful core developers should wait for AppVeyor, except if they know that Windows doesn't matter for a specific PR. Victor 2018-01-10 21:45 GMT+01:00 Brett Cannon : > I just switched it on to help make sure we don't break on Windows just > before hitting beta. If it turns out AppVeyor isn't stable enough I will > switch it back off. > > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Python workflow quirks with mercurial and hg-git extension
On 01/20/2018 11:19 AM, Jesus Cea wrote: I plan to come back to python development (about time!) but I truly hates git. I am experimenting with mercurial + hg-git extension and it is quite usable (after the initial painfully slow clone time), but I am having small quirks that I would like to iron out with a fellow more experienced or also interested in this approach. Anybody out there?. Not experienced, but interested! -- ~Ethan~ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Let's give commit privileges to Nathaniel J. Smith
Hi, I want to propose granting commit privileges to Nathaniel J. Smith. He's interested in the idea of becoming a core developer, and given the quality of his contributionsI think he won't need any extensive mentoring (although I'll be happy to assist Nathaniel in the beginning). Nathaniel has been a prolific PEP author: * Single-authored: PEP 465 Matrix Multiplication (accepted), PEP 521, PEP 533, PEP 568; * Co-authored: PEP 513 (active), PEP 516, PEP 517 (accepted), PEP 518 (accepted), PEP 522. * Many PEPs mention his name in acknowledgements. He also has a few sufficiently complex patches committed, some of which touch complex areas like ceval loop and signals handling: * bpo-32591: Add native coroutine origin tracking * bpo-30579: Allow TracebackType creation and tb_next mutation from Python * bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd * bpo-30039: Don't run signal handlers while resuming a yield from stack * bpo-30038: fix race condition in signal delivery + wakeup fd * etc He's been very active on python-dev, python-ideas, bugs.python.org and github. Here's an example where Nathaniel's research helped us to make a right decision to fix a broken socket object API: https://bugs.python.org/msg308450. He helped me quite a bit with the design of PEP 550 and PEP 567, and he's doing some interesting work in the async/await area. So... let's make it happen? :) Yury ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
On 1/24/2018 6:23 PM, Yury Selivanov wrote: Hi, I want to propose granting commit privileges to Nathaniel J. Smith. He's interested in the idea of becoming a core developer, and given the quality of his contributionsI think he won't need any extensive mentoring (although I'll be happy to assist Nathaniel in the beginning). +1. I actually thought he was a committer already. Eric ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
+1 from me as well. Le 25/01/2018 à 00:23, Yury Selivanov a écrit : > Hi, > > I want to propose granting commit privileges to Nathaniel J. Smith. > He's interested in the idea of becoming a core developer, and given > the quality of his contributionsI think he won't need any extensive > mentoring (although I'll be happy to assist Nathaniel in the > beginning). > > Nathaniel has been a prolific PEP author: > > * Single-authored: PEP 465 Matrix Multiplication (accepted), PEP 521, > PEP 533, PEP 568; > > * Co-authored: PEP 513 (active), PEP 516, PEP 517 (accepted), PEP 518 > (accepted), PEP 522. > > * Many PEPs mention his name in acknowledgements. > > He also has a few sufficiently complex patches committed, some of > which touch complex areas like ceval loop and signals handling: > > * bpo-32591: Add native coroutine origin tracking > * bpo-30579: Allow TracebackType creation and tb_next mutation from Python > * bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd > * bpo-30039: Don't run signal handlers while resuming a yield from stack > * bpo-30038: fix race condition in signal delivery + wakeup fd > * etc > > He's been very active on python-dev, python-ideas, bugs.python.org and > github. Here's an example where Nathaniel's research helped us to make > a right decision to fix a broken socket object API: > https://bugs.python.org/msg308450. > > He helped me quite a bit with the design of PEP 550 and PEP 567, and > he's doing some interesting work in the async/await area. > > So... let's make it happen? :) > > Yury > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
+1, Nathaniel would be a nice addition. > On Jan 24, 2018, at 3:32 PM, Antoine Pitrou wrote: > > > +1 from me as well. > > > Le 25/01/2018 à 00:23, Yury Selivanov a écrit : >> Hi, >> >> I want to propose granting commit privileges to Nathaniel J. Smith. >> He's interested in the idea of becoming a core developer, and given >> the quality of his contributionsI think he won't need any extensive >> mentoring (although I'll be happy to assist Nathaniel in the >> beginning). >> >> Nathaniel has been a prolific PEP author: >> >> * Single-authored: PEP 465 Matrix Multiplication (accepted), PEP 521, >> PEP 533, PEP 568; >> >> * Co-authored: PEP 513 (active), PEP 516, PEP 517 (accepted), PEP 518 >> (accepted), PEP 522. >> >> * Many PEPs mention his name in acknowledgements. >> >> He also has a few sufficiently complex patches committed, some of >> which touch complex areas like ceval loop and signals handling: >> >> * bpo-32591: Add native coroutine origin tracking >> * bpo-30579: Allow TracebackType creation and tb_next mutation from Python >> * bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd >> * bpo-30039: Don't run signal handlers while resuming a yield from stack >> * bpo-30038: fix race condition in signal delivery + wakeup fd >> * etc >> >> He's been very active on python-dev, python-ideas, bugs.python.org and >> github. Here's an example where Nathaniel's research helped us to make >> a right decision to fix a broken socket object API: >> https://bugs.python.org/msg308450. >> >> He helped me quite a bit with the design of PEP 550 and PEP 567, and >> he's doing some interesting work in the async/await area. >> >> So... let's make it happen? :) >> >> Yury >> ___ >> python-committers mailing list >> [email protected] >> https://mail.python.org/mailman/listinfo/python-committers >> Code of Conduct: https://www.python.org/psf/codeofconduct/ >> > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
Indeed! On Wed, Jan 24, 2018 at 3:43 PM, Carol Willing wrote: > +1, Nathaniel would be a nice addition. > > > On Jan 24, 2018, at 3:32 PM, Antoine Pitrou wrote: > > > > > > +1 from me as well. > > > > > > Le 25/01/2018 à 00:23, Yury Selivanov a écrit : > >> Hi, > >> > >> I want to propose granting commit privileges to Nathaniel J. Smith. > >> He's interested in the idea of becoming a core developer, and given > >> the quality of his contributionsI think he won't need any extensive > >> mentoring (although I'll be happy to assist Nathaniel in the > >> beginning). > >> > >> Nathaniel has been a prolific PEP author: > >> > >> * Single-authored: PEP 465 Matrix Multiplication (accepted), PEP 521, > >> PEP 533, PEP 568; > >> > >> * Co-authored: PEP 513 (active), PEP 516, PEP 517 (accepted), PEP 518 > >> (accepted), PEP 522. > >> > >> * Many PEPs mention his name in acknowledgements. > >> > >> He also has a few sufficiently complex patches committed, some of > >> which touch complex areas like ceval loop and signals handling: > >> > >> * bpo-32591: Add native coroutine origin tracking > >> * bpo-30579: Allow TracebackType creation and tb_next mutation from > Python > >> * bpo-30050: Allow disabling full buffer warnings in > signal.set_wakeup_fd > >> * bpo-30039: Don't run signal handlers while resuming a yield from stack > >> * bpo-30038: fix race condition in signal delivery + wakeup fd > >> * etc > >> > >> He's been very active on python-dev, python-ideas, bugs.python.org and > >> github. Here's an example where Nathaniel's research helped us to make > >> a right decision to fix a broken socket object API: > >> https://bugs.python.org/msg308450. > >> > >> He helped me quite a bit with the design of PEP 550 and PEP 567, and > >> he's doing some interesting work in the async/await area. > >> > >> So... let's make it happen? :) > >> > >> Yury > >> ___ > >> python-committers mailing list > >> [email protected] > >> https://mail.python.org/mailman/listinfo/python-committers > >> Code of Conduct: https://www.python.org/psf/codeofconduct/ > >> > > ___ > > python-committers mailing list > > [email protected] > > https://mail.python.org/mailman/listinfo/python-committers > > Code of Conduct: https://www.python.org/psf/codeofconduct/ > > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > -- --Guido van Rossum (python.org/~guido) ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
On Jan 24, 2018, at 18:23, Yury Selivanov wrote: > > I want to propose granting commit privileges to Nathaniel J. Smith. Wait, he’s not already?! +1 of course. -Barry signature.asc Description: Message signed with OpenPGP ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
+1. On Thu, Jan 25, 2018 at 1:47 AM Barry Warsaw wrote: > On Jan 24, 2018, at 18:23, Yury Selivanov wrote: > > > > I want to propose granting commit privileges to Nathaniel J. Smith. > > Wait, he’s not already?! +1 of course. > > -Barry > > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > -- Thanks, Andrew Svetlov ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
+1 Impressive list of contributions! Victor 2018-01-25 0:23 GMT+01:00 Yury Selivanov : > Hi, > > I want to propose granting commit privileges to Nathaniel J. Smith. > He's interested in the idea of becoming a core developer, and given > the quality of his contributionsI think he won't need any extensive > mentoring (although I'll be happy to assist Nathaniel in the > beginning). > > Nathaniel has been a prolific PEP author: > > * Single-authored: PEP 465 Matrix Multiplication (accepted), PEP 521, > PEP 533, PEP 568; > > * Co-authored: PEP 513 (active), PEP 516, PEP 517 (accepted), PEP 518 > (accepted), PEP 522. > > * Many PEPs mention his name in acknowledgements. > > He also has a few sufficiently complex patches committed, some of > which touch complex areas like ceval loop and signals handling: > > * bpo-32591: Add native coroutine origin tracking > * bpo-30579: Allow TracebackType creation and tb_next mutation from Python > * bpo-30050: Allow disabling full buffer warnings in signal.set_wakeup_fd > * bpo-30039: Don't run signal handlers while resuming a yield from stack > * bpo-30038: fix race condition in signal delivery + wakeup fd > * etc > > He's been very active on python-dev, python-ideas, bugs.python.org and > github. Here's an example where Nathaniel's research helped us to make > a right decision to fix a broken socket object API: > https://bugs.python.org/msg308450. > > He helped me quite a bit with the design of PEP 550 and PEP 567, and > he's doing some interesting work in the async/await area. > > So... let's make it happen? :) > > Yury > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
+1 I have been following the discussions in python-dev and find his contributions very productive. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
On 1/24/2018 6:29 PM, Eric V. Smith wrote: On 1/24/2018 6:23 PM, Yury Selivanov wrote: Hi, I want to propose granting commit privileges to Nathaniel J. Smith. He's interested in the idea of becoming a core developer, and given the quality of his contributionsI think he won't need any extensive mentoring (although I'll be happy to assist Nathaniel in the beginning). +1. I actually thought he was a committer already. +1 I definitely thought he might be. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith
On 01/24/2018 03:23 PM, Yury Selivanov wrote: I want to propose granting commit privileges to Nathaniel J. Smith. I also thought he was already. Definitely +1 ! -- ~Ethan~ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Python workflow quirks with mercurial and hg-git extension
On 25Jan2018 0547, Ethan Furman wrote: > On 01/20/2018 11:19 AM, Jesus Cea wrote: >> I plan to come back to python development (about time!) but I truly >> hates git. I am experimenting with mercurial + hg-git extension and it >> is quite usable (after the initial painfully slow clone time), but I am >> having small quirks that I would like to iron out with a fellow more >> experienced or also interested in this approach. >> >> Anybody out there?. > > Not experienced, but interested! Experienced enough to have given up on using hg-git for CPython and now I just suffer git. (Those who have ever discussed workflow with me know that's a really big deal!) The main thing that annoyed me was the different EOL handling: Mercurial applies the correction on update/checkout, while git does it on commit (or perhaps the other way around, either way, it broke many PRs). Perhaps this affects me more than most because I'm using Windows, but commits through hg-git would leave CRLF endings in files that git would have already translated to LF, and so the CRLF endings would show up as changes in the PR. The excessive clone time was also painful. I suspect dulwich could do with some optimisation. Perhaps these are issues that could be fixed in hg-git? If so, I'd happily switch back to it. But at least with the backport bot doing a great job (thanks Mariatta!) I don't have to deal with too much switching in git. I suspect your quirks are different from these, but feel free to give me the details and I'll let you know if I saw them and/or worked around them. I still use hg-git for many of my other repos. Cheers, Steve ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
