Re: [python-committers] trivial tag on GitHub?
On 1/26/2018 1:28 AM, Ethan Furman wrote: I created a new pull request to add a forgotten news entry, and now it's going through all the pre-checks, etc. I seem to recall we could add a "trivial" tag to an issue to skip those. Is that still true, and if so, how? 'trivial' was replaced by 'skip issue', to skip the bpo issue number check, and 'skip news', to skip the news check. A PR to provide forgotten news entry should pass the news check and should have a bpo number (the same one in the news entry). ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
On 01/26/2018 12:45 AM, Terry Reedy wrote: On 1/26/2018 1:28 AM, Ethan Furman wrote: I created a new pull request to add a forgotten news entry, and now it's going through all the pre-checks, etc. I seem to recall we could add a "trivial" tag to an issue to skip those. Is that still true, and if so, how? 'trivial' was replaced by 'skip issue', to skip the bpo issue number check, and 'skip news', to skip the news check. A PR to provide forgotten news entry should pass the news check and should have a bpo number (the same one in the news entry). So when the original PR didn't have a news entry, what should I have seen to alert me to that? And should this thread be on the Workflow list? -- ~Ethan~ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
> So when the original PR didn't have a news entry, what should I have seen > to alert me to that? If a news entry is missing from the PR, the CI check at the bottom of the PR will fail. You should see the following: bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label found An example can be seen here (at least at the time I write this email) https://github.com/python/cpython/pull/5347 ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] ssl module will require OpenSSL 1.0.2
For your information, my ssl module improvement "Let OpenSSL verify hostname and IP address" will land either today or tomorrow. I'm just waiting for Alex to give me the final ACK on PR https://github.com/python/cpython/pull/3462. Once the PR has landed, several issues with hostname and IP address verification will be solved. Python 3.7 will use OpenSSL's recommended API to match hostnames. The API is OpenSSL 1.0.2+ only. OpenSSL 0.9.8 and 1.0.1 are no longer supported. LibreSSL does not yet implement these APIs yet, see https://github.com/libressl-portable/portable/issues/381 for my upstream bug and https://mail.python.org/pipermail/python-dev/2018-January/151824.html for Python-dev discussion. I also like to get https://github.com/python/cpython/pull/5259 into 3.7. The PR adds support for OpenSSL's new API to set minimum and maximum TLS protocol version. It's require for compatibility with future versions of Debian. Debian has used the new APIs to disable TLS 1.0 and 1.1, see https://bugs.python.org/issue31453. PR https://github.com/python/cpython/pull/5162 implements PEP 543 Certificate and PrivateKey classes, but it's not finished yet. The code works but it lacks tests and documentation. My remaining TLS PRs are either bug fixes or can wait for 3.8. I'll merge them after beta 1 has been released. Christian ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
On 01/26/2018 09:28 AM, Mariatta Wijaya wrote: So when the original PR didn't have a news entry, what should I have seen to alert me to that? If a news entry is missing from the PR, the CI check at the bottom of the PR will fail. You should see the following: bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label found An example can be seen here (at least at the time I write this email) https://github.com/python/cpython/pull/5347 Okay, I see it in your example. Here's the PR I'm talking about: https://github.com/python/cpython/pull/5103 I see no NEWS commit, and no "missing news" alert. Did I misstep somewhere? -- ~Ethan~ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
On Jan 26, 2018, at 16:05, Ethan Furman wrote: > On 01/26/2018 09:28 AM, Mariatta Wijaya wrote: > >>So when the original PR didn't have a news entry, what should I have seen >> to alert me to that? >> >> If a news entry is missing from the PR, the CI check at the bottom of the PR >> will fail. >> You should see the following: >> >> bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label >> found >> >> An example can be seen here (at least at the time I write this email) >> https://github.com/python/cpython/pull/5347 > > Okay, I see it in your example. Here's the PR I'm talking about: > > https://github.com/python/cpython/pull/5103 > > I see no NEWS commit, and no "missing news" alert. Did I misstep somewhere? It's all the way at the bottom, generated by blurb: Misc/NEWS.d/next/Library/2018-01-04-14-45-33.bpo-29237.zenYA6.rst https://github.com/python/cpython/pull/5103/files -- Ned Deily [email protected] -- [] ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
On 01/26/2018 01:09 PM, Ned Deily wrote: On Jan 26, 2018, at 16:05, Ethan Furman wrote: On 01/26/2018 09:28 AM, Mariatta Wijaya wrote: So when the original PR didn't have a news entry, what should I have seen to alert me to that? If a news entry is missing from the PR, the CI check at the bottom of the PR will fail. You should see the following: bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label found An example can be seen here (at least at the time I write this email) https://github.com/python/cpython/pull/5347 Okay, I see it in your example. Here's the PR I'm talking about: https://github.com/python/cpython/pull/5103 I see no NEWS commit, and no "missing news" alert. Did I misstep somewhere? It's all the way at the bottom, generated by blurb: Misc/NEWS.d/next/Library/2018-01-04-14-45-33.bpo-29237.zenYA6.rst https://github.com/python/cpython/pull/5103/files Ah, thanks Ned, and everyone. So the takeaway is if I see something totally incomprehensible, it's probably the NEWS file. Also, I can't merge without a NEWS file. Good things. ;) -- ~Ethan~ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
2018-01-26 20:47 GMT+01:00 Christian Heimes : > LibreSSL does not yet implement these APIs yet Does it mean that Python 3.7 will not support OpenBSD anymore? Well, it's not like OpenBSD support is perfect, but there are only few issues on OpenBSD. Does other operating systems use LibreSSL as their system SSL library (instead of OpenSSL)? Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
On 2018-01-26 23:03, Victor Stinner wrote: > 2018-01-26 20:47 GMT+01:00 Christian Heimes : >> LibreSSL does not yet implement these APIs yet > > Does it mean that Python 3.7 will not support OpenBSD anymore? Well, > it's not like OpenBSD support is perfect, but there are only few > issues on OpenBSD. > > Does other operating systems use LibreSSL as their system SSL library > (instead of OpenSSL)? OpenBSD is still supported. But you either have to install OpenSSL, live without SSL support or get LibreSSL fixed. Python's test suite is passing without ssl available. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
2018-01-26 23:09 GMT+01:00 Christian Heimes : > OpenBSD is still supported. But you either have to install OpenSSL, live > without SSL support or get LibreSSL fixed. Python's test suite is > passing without ssl available. (Sure, if LibreSSL is fixed, the issue goes away, but right now https://github.com/libressl-portable/portable/issues/381 is still open.) I'm not sure that it's possible to easily install OpenSSL on OpenBSD. OpenBSD is linked to the team who wrote LibreSSL and OpenBSD replaced OpenSSL with LibreSSL. Python without ssl also means Python without pip. Python without pip... well, it's more limited than Python with pip :-) Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
On 2018-01-26 23:13, Victor Stinner wrote: > 2018-01-26 23:09 GMT+01:00 Christian Heimes : >> OpenBSD is still supported. But you either have to install OpenSSL, live >> without SSL support or get LibreSSL fixed. Python's test suite is >> passing without ssl available. > > (Sure, if LibreSSL is fixed, the issue goes away, but right now > https://github.com/libressl-portable/portable/issues/381 is still > open.) > > I'm not sure that it's possible to easily install OpenSSL on OpenBSD. > OpenBSD is linked to the team who wrote LibreSSL and OpenBSD replaced > OpenSSL with LibreSSL. > > Python without ssl also means Python without pip. Python without > pip... well, it's more limited than Python with pip :-) We never officially supported LibreSSL, so we aren't breaking any promise. I supported LibreSSL as a best-effort approach. You can still have TLS support with extra packages. Python requests and pip can also use PyOpenSSL. Christian ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
On 2018-01-26 23:09, Christian Heimes wrote: > On 2018-01-26 23:03, Victor Stinner wrote: >> 2018-01-26 20:47 GMT+01:00 Christian Heimes : >>> LibreSSL does not yet implement these APIs yet >> >> Does it mean that Python 3.7 will not support OpenBSD anymore? Well, >> it's not like OpenBSD support is perfect, but there are only few >> issues on OpenBSD. >> >> Does other operating systems use LibreSSL as their system SSL library >> (instead of OpenSSL)? > > OpenBSD is still supported. But you either have to install OpenSSL, live > without SSL support or get LibreSSL fixed. Python's test suite is > passing without ssl available. According to https://en.wikipedia.org/wiki/LibreSSL#Adoption Alpine Linux, DragonFly BSD and OpenBSD are affected. https://distrowatch.com/table.php?distribution=openbsd still suggests that OpenBSD ships with OpenSSL 1.0.2l. Not sure if that is true, though. All other distributions either have only OpenSSL (CentOS, Debian, Fedora, RHEL, Ubuntu), OpenSSL as default (Gentoo, FreeBSD) or none (Windows, macOS). NetBSD seems to support both. Christian ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
2018-01-26 23:25 GMT+01:00 Christian Heimes : > We never officially supported LibreSSL, so we aren't breaking any > promise. I supported LibreSSL as a best-effort approach. > > You can still have TLS support with extra packages. Python requests and > pip can also use PyOpenSSL. I have no opinion on OpenBSD support. It's good to know that the pip issue can be worked around (if PyOpenSSL can be easily installed on OpenBSD? I mean... without pip ;-))). At least, if Python 3.7 doesn't work on OpenBSD anymore because of this issue, maybe LibreSSL will be more motivated to fix the issue? :-) Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] trivial tag on GitHub?
On Fri, 26 Jan 2018 at 13:04 Ethan Furman wrote: > On 01/26/2018 09:28 AM, Mariatta Wijaya wrote: > > > So when the original PR didn't have a news entry, what should I have > seen to alert me to that? > > > > If a news entry is missing from the PR, the CI check at the bottom of > the PR will fail. > > You should see the following: > > > > bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label > found > > > > An example can be seen here (at least at the time I write this email) > > https://github.com/python/cpython/pull/5347 > > Okay, I see it in your example. Here's the PR I'm talking about: > >https://github.com/python/cpython/pull/5103 > > I see no NEWS commit, and no "missing news" alert. Did I misstep > somewhere? > No, you just missed the news entry: https://github.com/python/cpython/pull/5103/files#diff-b1662ec7a5e858b21ea9fe160546636f . ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] AppVeyor is now required to pass on PRs
On 26 January 2018 at 07:31, Victor Stinner wrote: > Each time I approve a backport PR created by miss-ilington with "LGTM, > good bot", I hope secretly that the PR will be merged automatically > once CI tests pass ;-) > > Is it possible to write a bot which merges a PR? > The last time we looked at this, the main technical problem was that there wasn't a native way to pre-edit the commit message before hitting the "Squash & Merge" button, and emulating that capability via a formatted comment misses out on a lot of UI niceties. So for a first pass, I think a comment from the bot saying "Approved PR ready for merge" and mentioning the committers that left approving reviews would be a good way to go (I know Sanyam had to ping me on a couple of issues because I'd approved them, but switched to doing something else because CI was still running, and then never got back to actually merge them). Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] ssl module will require OpenSSL 1.0.2
On 27 January 2018 at 09:23, Victor Stinner wrote: > At least, if Python 3.7 doesn't work on OpenBSD anymore because of > this issue, maybe LibreSSL will be more motivated to fix the issue? > :-) > Anyone using the Alpine Linux based Docker images (including Docker themselves) will also have a fair incentive to solve the problem (although in that case, their resolution might be "switch back to using OpenSSL given the improvement over the past couple of years"). Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
