Re: [python-committers] cherry picking, miss islington, and generated files
On Feb 3, 2018, at 23:16, Mariatta Wijaya wrote: > > I found the related thread in core mentorship mailing list: > https://mail.python.org/mm3/archives/list/[email protected]/thread/CNK7EWWZTDIRID7MTWLTWXU4H7IH3UIE/ FYI, core-mentorship’s archives can’t be read without a subscription. > Guido and Victor answered, I guess I got distracted with other things and > forgot to do any sort of follow up :P > > If I understand it right, they both suggested running "make regen-all" at > each backport. > But you seem to indicate that you rather do that manually? Not necessarily. I think the only option right now is to run it manually, but if the bot can do that automatically (and probably add a comment that it’s done so), that would be great. > For the first pass, I think it can detect that when a changeset includes > importlib.h, we'll make miss-islington leave a comment about needing to > regenerate files. +1 -Barry signature.asc Description: Message signed with OpenPGP ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] [RELEASED] Python 3.4.8 and Python 3.5.5 are now available
On behalf of the Python development community, I'm happy to announce the availability of Python 3.4.8 and Python 3.5.5. Both Python 3.4 and 3.5 are in "security fixes only" mode. Both versions only accept security fixes, not conventional bug fixes, and both releases are source-only. You can find Python 3.4.8 here: https://www.python.org/downloads/release/python-348/ And you can find Python 3.5.5 here: https://www.python.org/downloads/release/python-355/ Happy Pythoning, //arry/ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] cherry picking, miss islington, and generated files
On 4 February 2018 at 00:54, Barry Warsaw wrote: > On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: >> >> Sure, I sort of asked this in the past: what are the generated files, how to >> identify them, is there a pattern? > > I’m not sure there’s going to be a pattern so much as a list of such files. - all C files may potentially contain Argument Clinic headers that modify them in place - build input files (configure.ac, etc) may change the other build artifacts At the moment, I think we're still relying on humans to notice those problematic cases, but we may be able to at least have CI fail if "make regen-all" actually changes any file contents for checked in files. Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] cherry picking, miss islington, and generated files
We already have Travis checking 'make regen-all' and 'make clinic' (assuming it's working correctly). -- Zach (On a phone) On Feb 4, 2018 9:09 PM, "Nick Coghlan" wrote: On 4 February 2018 at 00:54, Barry Warsaw wrote: > On Feb 2, 2018, at 20:40, Mariatta Wijaya wrote: >> >> Sure, I sort of asked this in the past: what are the generated files, how to identify them, is there a pattern? > > I’m not sure there’s going to be a pattern so much as a list of such files. - all C files may potentially contain Argument Clinic headers that modify them in place - build input files (configure.ac, etc) may change the other build artifacts At the moment, I think we're still relying on humans to notice those problematic cases, but we may be able to at least have CI fail if "make regen-all" actually changes any file contents for checked in files. Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] cherry picking, miss islington, and generated files
> > We already have Travis checking 'make regen-all' and 'make clinic' > (assuming it's working correctly). The CI in https://github.com/python/cpython/pull/5498 were all passing, but I think we expected it to fail? In the end Barry regenerated the files manually. Mariatta Wijaya ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
