[python-committers] Re: A urlparse regression in minor version
Le 13/02/2020 à 03:27, Senthil Kumaran a écrit : > Thanks for sharing your thoughts. > > I was originally thinking that if the problem is contained only to 3.8.1 > and 3.7.6 and, reverted 3.8.2. I would say it depends what the "revert" means: - revert to pre-bugfix behavior? - revert then apply a safer fix to the original bug? Regards Antoine. ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/OWAUVY6CASRWQPVAEP5XJVX7SDBCVFJN/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: A urlparse regression in minor version
On Thu, Feb 13, 2020 at 1:57 AM Antoine Pitrou wrote: > > > I would say it depends what the "revert" means: > - revert to pre-bugfix behavior? > This. Because the bug-fix was a bringing in backward-incompatible change that certain users are not happy with. https://github.com/mozilla/bleach/issues/503 > - revert then apply a safer fix to the original bug? No. The change introduced (bug-fix) was helpful in terms of consistent parsing and further improvement from maintainers pov. A safer fix might essentially mean revert to the old behavior. The original bug(s) were about parsing expectations of an ill-defined 'scheme-less' URLs. Developers who relied on older behavior are surprised. ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/OGGPZWPH2ZJDGZI3VPVVAFRS4PFDYOC2/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: A urlparse regression in minor version
On Feb 11, 2020, at 05:26, Łukasz Langa wrote: > > I'll let others voice their opinions but my intuition for 3.8.x is to leave > your patch be. True, it should not have been backported but it was, and it > was already released as part of 3.8.1 and now 3.8.2rc1. I don’t think you should worry about 3.8.2rc1. That’s not a release version so shouldn’t impact the decision IMHO. Whether 3.8.1 is important enough not to revert this change is an RM decision. -Barry signature.asc Description: Message signed with OpenPGP ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/A3OWT4ZPL3V233DXNULCF4AZE25QMSZ5/ Code of Conduct: https://www.python.org/psf/codeofconduct/
