[python-committers] Travis CI is no longer mandatory on Python pull requests
Hi, Python has no mandatory Linux CI job on pull requests anymore. Right now Windows (x64) remains the only mandatory job. Please be careful to manually check other CI before merging a PR. -- We had to deal with at least 3 different issues on the Travis CI over the last 6 months. The latest one (3rd issue) is on the Travis CI side and is known for months. Sometimes, a Travis CI build completes but the GitHub pull request is never updated. Since Travis CI was mandatory, it was never possible to merge some pull requests. I also noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR for the same Travis CI build, only one is updated, and so again, the PR cannot be merged. For all these reasons, Travis CI was made optional. I would be nice to have a mandatory Linux job: "Tests / Ubuntu (pull_request)" is a good candidate. But I didn't check if it's reliable or not. See https://github.com/python/core-workflow/issues/377 for the discussion. Note: if someone manages to fix all Travis CI issues, we can reconsider making it mandatory again. But it seems like most people who tried (included me) are tired or bored by Travis CI. Victor -- Night gathers, and now my watch begins. It shall not end until my death. ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: Travis CI is no longer mandatory on Python pull requests
Should we consider dropping Travis CI as a CI provider if it continues to be so flaky? Otherwise isn't it becoming just noise on a PR? On Fri, Oct 16, 2020 at 1:42 AM Victor Stinner wrote: > Hi, > > Python has no mandatory Linux CI job on pull requests anymore. Right > now Windows (x64) remains the only mandatory job. Please be careful to > manually check other CI before merging a PR. > > -- > > We had to deal with at least 3 different issues on the Travis CI over > the last 6 months. The latest one (3rd issue) is on the Travis CI side > and is known for months. Sometimes, a Travis CI build completes but > the GitHub pull request is never updated. Since Travis CI was > mandatory, it was never possible to merge some pull requests. I also > noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR > for the same Travis CI build, only one is updated, and so again, the > PR cannot be merged. > > For all these reasons, Travis CI was made optional. > > I would be nice to have a mandatory Linux job: "Tests / Ubuntu > (pull_request)" is a good candidate. But I didn't check if it's > reliable or not. > > See https://github.com/python/core-workflow/issues/377 for the discussion. > > Note: if someone manages to fix all Travis CI issues, we can > reconsider making it mandatory again. But it seems like most people > who tried (included me) are tired or bored by Travis CI. > > Victor > -- > Night gathers, and now my watch begins. It shall not end until my death. > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/VMOSHFBG3XWZCX2EK5R6MFKXEBSMSGGA/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: Travis CI is no longer mandatory on Python pull requests
On Fri, Oct 16, 2020 at 1:42 AM Victor Stinner wrote: > Hi, > > Python has no mandatory Linux CI job on pull requests anymore. Right > now Windows (x64) remains the only mandatory job. Please be careful to > manually check other CI before merging a PR. > > -- > > We had to deal with at least 3 different issues on the Travis CI over > the last 6 months. The latest one (3rd issue) is on the Travis CI side > and is known for months. Sometimes, a Travis CI build completes but > the GitHub pull request is never updated. Since Travis CI was > mandatory, it was never possible to merge some pull requests. I also > noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR > for the same Travis CI build, only one is updated, and so again, the > PR cannot be merged. > > For all these reasons, Travis CI was made optional. > > I would be nice to have a mandatory Linux job: "Tests / Ubuntu > (pull_request)" is a good candidate. But I didn't check if it's > reliable or not. > We should simply mark the github actions "Tests / Ubuntu" CI as required. If we wind up not liking the behavior we can go back on it while we work something else out. But it seems dangerous to not have any blocking Linux CI. Linux is our most important platform. With our dev sprint next week we'll discover if it gets in our way more often than helps rather quickly. I cannot rightfully apply an automerge label to a code PR so long as we lack Linux CI to block a merge. -gps > > See https://github.com/python/core-workflow/issues/377 for the discussion. > > Note: if someone manages to fix all Travis CI issues, we can > reconsider making it mandatory again. But it seems like most people > who tried (included me) are tired or bored by Travis CI. > > Victor > -- > Night gathers, and now my watch begins. It shall not end until my death. > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/7YTWVS5OXH3NJQBSG55QBSXOMD6RECFG/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: Travis CI is no longer mandatory on Python pull requests
> We should simply mark the github actions "Tests / Ubuntu" CI as required. +1 I completely agree with everything Gregory said. On Fri, 16 Oct 2020 at 19:36, Gregory P. Smith wrote: > > > On Fri, Oct 16, 2020 at 1:42 AM Victor Stinner > wrote: > >> Hi, >> >> Python has no mandatory Linux CI job on pull requests anymore. Right >> now Windows (x64) remains the only mandatory job. Please be careful to >> manually check other CI before merging a PR. >> >> -- >> >> We had to deal with at least 3 different issues on the Travis CI over >> the last 6 months. The latest one (3rd issue) is on the Travis CI side >> and is known for months. Sometimes, a Travis CI build completes but >> the GitHub pull request is never updated. Since Travis CI was >> mandatory, it was never possible to merge some pull requests. I also >> noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR >> for the same Travis CI build, only one is updated, and so again, the >> PR cannot be merged. >> >> For all these reasons, Travis CI was made optional. >> >> I would be nice to have a mandatory Linux job: "Tests / Ubuntu >> (pull_request)" is a good candidate. But I didn't check if it's >> reliable or not. >> > > We should simply mark the github actions "Tests / Ubuntu" CI as required. > > If we wind up not liking the behavior we can go back on it while we work > something else out. But it seems dangerous to not have any blocking Linux > CI. Linux is our most important platform. With our dev sprint next week > we'll discover if it gets in our way more often than helps rather quickly. > > I cannot rightfully apply an automerge label to a code PR so long as we > lack Linux CI to block a merge. > > -gps > > >> >> See https://github.com/python/core-workflow/issues/377 for the >> discussion. >> >> Note: if someone manages to fix all Travis CI issues, we can >> reconsider making it mandatory again. But it seems like most people >> who tried (included me) are tired or bored by Travis CI. >> >> Victor >> -- >> Night gathers, and now my watch begins. It shall not end until my death. >> ___ >> python-committers mailing list -- [email protected] >> To unsubscribe send an email to [email protected] >> https://mail.python.org/mailman3/lists/python-committers.python.org/ >> Message archived at >> https://mail.python.org/archives/list/[email protected]/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/ >> Code of Conduct: https://www.python.org/psf/codeofconduct/ >> > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/7YTWVS5OXH3NJQBSG55QBSXOMD6RECFG/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/PRZ6USPKAEVZHBO5MUWYDK37O3PYBSG4/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: Travis CI is no longer mandatory on Python pull requests
On Fri, Oct 16, 2020 at 11:58 AM Pablo Galindo Salgado wrote: > > We should simply mark the github actions "Tests / Ubuntu" CI as > required. > > +1 I completely agree with everything Gregory said. > +1 from me as well. -Brett > > > On Fri, 16 Oct 2020 at 19:36, Gregory P. Smith wrote: > >> >> >> On Fri, Oct 16, 2020 at 1:42 AM Victor Stinner >> wrote: >> >>> Hi, >>> >>> Python has no mandatory Linux CI job on pull requests anymore. Right >>> now Windows (x64) remains the only mandatory job. Please be careful to >>> manually check other CI before merging a PR. >>> >>> -- >>> >>> We had to deal with at least 3 different issues on the Travis CI over >>> the last 6 months. The latest one (3rd issue) is on the Travis CI side >>> and is known for months. Sometimes, a Travis CI build completes but >>> the GitHub pull request is never updated. Since Travis CI was >>> mandatory, it was never possible to merge some pull requests. I also >>> noticed a 4th bug, sometimes a PR gets *two* Travis CI jobs on a PR >>> for the same Travis CI build, only one is updated, and so again, the >>> PR cannot be merged. >>> >>> For all these reasons, Travis CI was made optional. >>> >>> I would be nice to have a mandatory Linux job: "Tests / Ubuntu >>> (pull_request)" is a good candidate. But I didn't check if it's >>> reliable or not. >>> >> >> We should simply mark the github actions "Tests / Ubuntu" CI as required. >> >> If we wind up not liking the behavior we can go back on it while we work >> something else out. But it seems dangerous to not have any blocking Linux >> CI. Linux is our most important platform. With our dev sprint next week >> we'll discover if it gets in our way more often than helps rather quickly. >> >> I cannot rightfully apply an automerge label to a code PR so long as we >> lack Linux CI to block a merge. >> >> -gps >> >> >>> >>> See https://github.com/python/core-workflow/issues/377 for the >>> discussion. >>> >>> Note: if someone manages to fix all Travis CI issues, we can >>> reconsider making it mandatory again. But it seems like most people >>> who tried (included me) are tired or bored by Travis CI. >>> >>> Victor >>> -- >>> Night gathers, and now my watch begins. It shall not end until my death. >>> ___ >>> python-committers mailing list -- [email protected] >>> To unsubscribe send an email to [email protected] >>> https://mail.python.org/mailman3/lists/python-committers.python.org/ >>> Message archived at >>> https://mail.python.org/archives/list/[email protected]/message/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/ >>> Code of Conduct: https://www.python.org/psf/codeofconduct/ >>> >> ___ >> python-committers mailing list -- [email protected] >> To unsubscribe send an email to [email protected] >> https://mail.python.org/mailman3/lists/python-committers.python.org/ >> Message archived at >> https://mail.python.org/archives/list/[email protected]/message/7YTWVS5OXH3NJQBSG55QBSXOMD6RECFG/ >> Code of Conduct: https://www.python.org/psf/codeofconduct/ >> > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/PRZ6USPKAEVZHBO5MUWYDK37O3PYBSG4/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/FWLOA2SCCKB4RUMDOCTNVIMHNKMEPTYD/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: Travis CI is no longer mandatory on Python pull requests
On Fri, Oct 16, 2020 at 12:26 PM Brett Cannon wrote: > > On Fri, Oct 16, 2020 at 11:58 AM Pablo Galindo Salgado < > [email protected]> wrote: > >> > We should simply mark the github actions "Tests / Ubuntu" CI as >> required. >> >> +1 I completely agree with everything Gregory said. >> > > +1 from me as well. > +1 vote too. If Github Actions were perceived to be too slow or there are some limitations, I am willing to help experiment with a different CI system for Linux builds. Thank you! ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/ZR46CLTGBRFASBHEU4SKEINM5WED6TZI/ Code of Conduct: https://www.python.org/psf/codeofconduct/
