Re: [jira] Commented: (MODPYTHON-70) Add configure --with-max-locks option to set MAX_LOCKS.

2005-08-09 Thread Nicolas Lehuen
This raise this issue : under Win32, the preferred way to build mod_python is to run :

python setup.py.in bdist_wininst --install-script win32_postinstall.py

This leaves no room to specify a MAX_LOCK definition override, but I
guess we could put it in setup.py, since extension modules can have
custome macro definitions.

My question is : should we keep on with ./configure ; make ; make install or try to do everything in setup.py ?

Regards,
Nicolas
2005/8/9, Jim Gallacher (JIRA) [EMAIL PROTECTED]:
[ http://issues.apache.org/jira/browse/MODPYTHON-70?page=comments#action_12318192 ]Jim Gallacher commented on MODPYTHON-70:
Changes committed. This issue can be closed. Add configure --with-max-locks option to set MAX_LOCKS. ---
Key: MODPYTHON-70URL: http://issues.apache.org/jira/browse/MODPYTHON-70Project: mod_python Type: New Feature
 Components: core Versions: 3.2.0Environment: All Reporter: Jim Gallacher Priority: Trivial MAX_LOCKS in src/include/mod_python.h is currently hard coded (currently 32).

Since the number of mutexes on some systems is limited, users may
prefer to use a different number when compiling mod_python. The now configure would be--with-max-locks=INTERGER. eg. $ ./configure --with-max-locks=4 The default should also be lower than 32. Grisha has suggested 8.
 I'll commit the changes shortly.--This message is automatically generated by JIRA.-If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa-For more information on JIRA, see: http://www.atlassian.com/software/jira



Re: [jira] Commented: (MODPYTHON-70) Add configure --with-max-locks option to set MAX_LOCKS.

2005-08-09 Thread Gregory (Grisha) Trubetskoy


On Tue, 9 Aug 2005, Jim Gallacher wrote:

My question is : should we keep on with ./configure ; make ; make install 
or try to do everything in setup.py ?




As long as we can put setup.py in a Makefile. ;)

Seriously though, ./configure --help; ./configure; make; make install; is 
just such second nature to me I never even thought of the alternative.


Yep, and I think setup.py isn't smart enough to deal with the Apache side 
of mod_python which is C-centric. But in any event, I think ./configure is 
the way to go.


Grisha