Re: [Python-Dev] How is the GitHub workflow working for people?

[Guido van Rossum]

It's easy to only analyze the files in the diff (these linters don't do
cross-file analysis anyways, typically) and it's possible to write a filter
that only keeps warnings about lines that are changed, but I don't know of
a standard solution for the latter (places where I worked where I've seen
this always had their own custom implementation).

On Sat, Feb 24, 2018 at 7:35 PM, Mariatta Wijaya 
wrote:

> Can any of these said linters analyze only the diff in the PR, instead of
> the entire CPython codebase?
>
> Mariatta Wijaya
>
> ᐧ
>
> ___
> Python-Dev mailing list
> Python-Dev@python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: https://mail.python.org/mailman/options/python-dev/
> guido%40python.org
>
>


-- 
--Guido van Rossum (python.org/~guido)
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] How is the GitHub workflow working for people?

[Mariatta Wijaya]

Can any of these said linters analyze only the diff in the PR, instead of
the entire CPython codebase?

Mariatta Wijaya

ᐧ
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] The `for y in [x]` idiom in comprehensions

[Mike Miller]

I'm not sure, I found the "with f(x) as y" form previously mentioned the most 
readable despite it being a new use case, while not needing new keywords.


-Mike


On 2018-02-23 22:07, David Mertz wrote:
FWIW, the nested loop over a single item is already in the language for 15 years 
or something. It's not that ugly, certainly not enough to need a new 'let' or 
'where' keyword that basically does exactly the same thing with 3 fewer characters.


On Feb 23, 2018 10:04 PM, David Mertz > 
wrote:


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] How is the GitHub workflow working for people?

[Nick Coghlan]

On 24 February 2018 at 16:45, Barry Warsaw  wrote:

> On Feb 21, 2018, at 19:03, Dan Stromberg  wrote:
> >
> > Is flake8 that much better than pylint, that pylint wouldn't even be
> discussed?
>
> I honestly don’t use pylint all that much these days, but when I was
> evaluating them years ago, I found pylint to be too noisy about
> not-incorrect code.  I also liked how flake8 has a very nice plugin system,
> and I use that on my personal projects to enforce a consistent style.  It’s
> certainly possible that both tools have advanced significantly since I last
> made my personal decision.
>

When I recommend pylint, I try to make it clear that the command I
personally recommend is `pylint -E`, as that's the level that automates
checking for outright bugs (name errors, attribute errors, etc), as well as
effectively checking for clever dynamic variable and attribute injection
code that is likely to confuse human readers in addition to confusing
static analysers.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncogh...@gmail.com   |   Brisbane, Australia
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com