Re: [Python-Dev] Standardize error message for non-pickleable types
On 2018-10-30 08:12, Serhiy Storchaka wrote: 29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.: "ZeroDivisionError: division by zero" "ValueError: invalid literal for int() with base 10: 'foo'" 3. If it's failing on an object (singular), then it's clearer to say "object". 4. Articles tend to be omitted. 5. Error messages tend to have quotes around the type name. Therefore, my preference is for: "cannot pickle 'XXX' object" Thank you Matthew, I'll use your variant. Will something change the fact that in all these cases the pickling will be failed not just for specific object, but for all instances of the specified type? Well, the other examples you gave did not say explicitly that all instances of that type would fail. If you look at what 'hash' says: >>> hash(()) 3527539 >>> hash(([])) Traceback (most recent call last): File "", line 1, in TypeError: unhashable type: 'list' that would suggest "TypeError: unpicklable type: 'list'", but I'm not sure I'd like too much of "unpicklable", "unmarshallable", "unserializable", etc. :-) ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Standardize error message for non-pickleable types
On 10/30/2018 1:12 AM, Serhiy Storchaka wrote: 29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.: "ZeroDivisionError: division by zero" "ValueError: invalid literal for int() with base 10: 'foo'" 3. If it's failing on an object (singular), then it's clearer to say "object". 4. Articles tend to be omitted. 5. Error messages tend to have quotes around the type name. Therefore, my preference is for: "cannot pickle 'XXX' object" Thank you Matthew, I'll use your variant. Will something change the fact that in all these cases the pickling will be failed not just for specific object, but for all instances of the specified type? That's why I suggested "object of type 'XXX'", to leave the type in a more prominent position, as it is generally more important to the issue than the object. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Rename Include/internals/ to Include/pycore/
Le mar. 30 oct. 2018 à 02:59, Benjamin Peterson a écrit : > > To me, it seems wrong that a function or macro defined in > > Include/objimpl.h requires an explicit #include "internal/pystate.h". > > objimpl.h should be self-sufficient. > > I agree. I would say nothing in Include/*.h should be including > Include/internal/*.h. We should move things into the "public" headers as > required to fix this. Hum. It seems like I'm trying to fix too many issues at the same time, and I'm confused by different constraints which may be incompatible. I started to cleanup and fix header files with the most "straightforward" changes: https://bugs.python.org/issue35081 I will see later if Include/internal/ still has to be rename or moved (Serhiy Storchaka proposed to move internal/*.h header files out of the Include/ directory, I'm not sure that it's really needed). Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Custom AIX build last week...
I used a custom build to check if a fix repaired a buildbot. It's unrelated to AIX, but inlining on Visual Studio in Debug mode, so specific to Windows. Victor Le mar. 30 oct. 2018 à 07:11, Michael Felt a écrit : > > I noticed that there was a "custom" build queued for my AIX build-bot last > week. (https://buildbot.python.org/all/#/builders/159/builds/1). > > It failed, but I hope that was due to the issue with install.sh. > > If it could be run again - and if it fails again, please let me know what the > test was, and I'll look at it on my server manually. > > If it succeeds - I would also appreciate a heads-up! > > Thanks, > > Michael > > ___ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/vstinner%40redhat.com ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Standardize error message for non-pickleable types
Le lun. 29 oct. 2018 à 22:20, MRAB a écrit : > 1. If you're pickling, then saying "pickle" is more helpful. I'm not sure that it's really possible to know if the error occurs while pickle is trying to serialize an object, or if it's a different serialization protocol. We are talking about the very generic __getstate__() method. I'm in favor of being more general and say "cannot serialize". Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Standardize error message for non-pickleable types
29.10.18 23:17, MRAB пише: 1. If you're pickling, then saying "pickle" is more helpful. 2. In English the usual long form is "cannot". Error messages tend to avoid abbreviations, and also tend to have lowercase after the colon, e.g.: "ZeroDivisionError: division by zero" "ValueError: invalid literal for int() with base 10: 'foo'" 3. If it's failing on an object (singular), then it's clearer to say "object". 4. Articles tend to be omitted. 5. Error messages tend to have quotes around the type name. Therefore, my preference is for: "cannot pickle 'XXX' object" Thank you Matthew, I'll use your variant. Will something change the fact that in all these cases the pickling will be failed not just for specific object, but for all instances of the specified type? ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Julien Palard joins the Python Release Team as Documentation Expert
On 30/10/2018 04.04, Ned Deily wrote: > https://discuss.python.org/t/julien-palard-joins-the-python-release-team-as-documentation-expert/313 Welcome on board, Julien! Thank you very much for helping out. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Custom AIX build last week...
I did a bit of digging and it seems this is related to issue35059, and something about "inline" processing. Besides learning how to clone a PR manually (which I will need to do) - what are you hoping to find? As my bot is not using gcc ( but xlc) I could look at manually compiling a single file and add some extra flags (-qsource or -qlist) which generates a .lst file and shows what the compiler did (macro expansion, etc..) If you would like me to attempt this - just let me know. Although it may take 24 hours from that request before I can fulfill it. Regards, Michael > On 10/30/2018 8:08 AM, Michael Felt wrote: > I noticed that there was a "custom" build queued for my AIX build-bot last > week. (https://buildbot.python.org/all/#/builders/159/builds/1). > > It failed, but I hope that was due to the issue with install.sh. > > If it could be run again - and if it fails again, please let me know what the > test was, and I'll look at it on my server manually. > > If it succeeds - I would also appreciate a heads-up! > > Thanks, > > Michael > > > ___ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/aixtools%40felt.demon.nl ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Custom AIX build last week...
I noticed that there was a "custom" build queued for my AIX build-bot last week. (https://buildbot.python.org/all/#/builders/159/builds/1). It failed, but I hope that was due to the issue with install.sh. If it could be run again - and if it fails again, please let me know what the test was, and I'll look at it on my server manually. If it succeeds - I would also appreciate a heads-up! Thanks, Michael ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
