[Python-Dev] Re: [Python-checkins] bpo-9949: Enable symlink traversal for ntpath.realpath (GH-15287)
On 21Aug2019 1626, Jeremy Kloth wrote: On Wed, Aug 21, 2019 at 2:43 PM Steve Dower wrote: https://github.com/python/cpython/commit/75e064962ee0e31ec19a8081e9d9cc957baf6415 commit: 75e064962ee0e31ec19a8081e9d9cc957baf6415 branch: master author: Steve Dower committer: GitHub date: 2019-08-21T13:43:06-07:00 summary: bpo-9949: Enable symlink traversal for ntpath.realpath (GH-15287) files: A Misc/NEWS.d/next/Windows/2019-08-14-13-40-15.bpo-9949.zW45Ks.rst M Doc/library/os.path.rst M Doc/whatsnew/3.8.rst M Lib/ntpath.py M Lib/test/test_ntpath.py M Lib/test/test_os.py M Lib/test/test_shutil.py M Lib/unittest/test/test_discovery.py This change seems to have broken the windows buildbots. The main fix is already merged and a second (for Windows 7/8) is on its way. Cheers, Steve ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/HTAFNMNGNIN2XWTONJC4EKDHDYIVF4HA/
[Python-Dev] Re: [Python-checkins] bpo-9949: Enable symlink traversal for ntpath.realpath (GH-15287)
On Wed, Aug 21, 2019 at 2:43 PM Steve Dower wrote: > > https://github.com/python/cpython/commit/75e064962ee0e31ec19a8081e9d9cc957baf6415 > commit: 75e064962ee0e31ec19a8081e9d9cc957baf6415 > branch: master > author: Steve Dower > committer: GitHub > date: 2019-08-21T13:43:06-07:00 > summary: > > bpo-9949: Enable symlink traversal for ntpath.realpath (GH-15287) > > files: > A Misc/NEWS.d/next/Windows/2019-08-14-13-40-15.bpo-9949.zW45Ks.rst > M Doc/library/os.path.rst > M Doc/whatsnew/3.8.rst > M Lib/ntpath.py > M Lib/test/test_ntpath.py > M Lib/test/test_os.py > M Lib/test/test_shutil.py > M Lib/unittest/test/test_discovery.py > This change seems to have broken the windows buildbots. -- Jeremy Kloth ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/LUFONBYB3B2A7Q6RR7CCYO7PVMPOHLNE/
[Python-Dev] Re: Announcing the new Python triage team on GitHub
Thanks for doing this. I hope it encourages more participation. The capabilities of a triager mostly look good except for "closing PRs and issues". This is a superpower that has traditionally been reserved for more senior developers because it grants the ability to shut-down the work of another aspiring contributor. Marking someone else's suggestion as rejected is the most perilous and least fun aspect of core development. Submitters tend to expect their idea won't be rejected without a good deal of thought and expert consideration. Our bar for becoming a triager is somewhat low, so I don't think it makes sense to give the authority to reject a PR or close an issue. ISTM the primary value of having triager is to tag issues appropriately, summon the appropriate experts, and make a first pass at review and/or improvements. FWIW, the definition of the word triage is "in medical use: the assignment of degrees of urgency to wounds or illnesses to decide the order of treatment of a large number of patients or casualties." That doesn't imply making a final disposition. Put another way, the only remaining distinction between a "triager" and a "core developer" is the ability to push the "commit" button. In a way, that is the least interesting part of the process and is often a foregone conclusion by the time it happens. Raymond ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/CIBKJSXQX5DZDKPA6TYTKNLHS4TA2LXM/
[Python-Dev] Announcing the new Python triage team on GitHub
We have a new Python triage team on GitHub to help improve our workflow. GitHub has a nice table that shows what a triager can or cannot do in general: https://help.github.com/en/articles/repository-permission-levels-for-an-organization#repository-access-for-each-permission-level More specific roles and responsibilities of the Python triage team are described in devguide: https://devguide.python.org/triaging/#python-triage-team The responsibilities are a little different than the Developer role that we currently have on b.p.o. On GitHub, triage team members have access to triage issues and pull requests not only in CPython repo, but also all the repositories owned by Python core team, including: devguide repo and all the bots' repos. Existing b.p.o Developers are not automatically added to Python triage team, but they can opt-in and request membership. Several reasons: - we don't know if the triager is still active or not - we don't know if the triager wants the added responsibilities or not Other contributors are also welcome to request the Python triage membership. All it takes is one core developer to approve the request. The process is fully documented in https://devguide.python.org/triaging/#becoming-a-member-of-the-python-triage-team, and there is an issue template for requesting membership in core-workflow https://github.com/python/core-workflow/issues/new/choose The first two triage team members are Kyle Stanley and Jeroen Demeyer. Their requests were handled in: https://github.com/python/core-workflow/issues/353 https://github.com/python/core-workflow/issues/354 If you'd like more background on Python triage team and how we came to this stage, all of these have been discussed in discourse: - https://discuss.python.org/t/proposal-create-bug-triage-team-on-github/ - https://discuss.python.org/t/creating-the-python-triage-team-on-github/ - https://discuss.python.org/t/criteria-for-promoting-people-to-the-python-triage-team/ - https://discuss.python.org/t/who-should-be-able-to-change-what-labels-on-github/2000 We also have a project board in core-workflow: https://github.com/python/core-workflow/projects/3 This is a new thing for us, and we're all still learning and getting use to it. Suggestions and ideas for improving the workflow can be discussed in Core Workflow category in discourse. Devguide improvements are also welcome. Thanks contributors, core devs, and The PSF infra team for all the help in getting this off the ground. And also thanks GitHub for giving us early access to the beta triage role! ᐧ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/YHDDRBEE2LPMBZNKJO5U6ERFIZC7FTIG/
[Python-Dev] Re: Missing license for file Modules/ossaudiodev.c
That's perfect! Thank you for clarifying this. On Tuesday, August 20, 2019, 5:09:43 PM GMT+2, Guido van Rossum wrote: The LICENSE file at the top is all you need. There is no need to contact inidividual contributors. That's the whole point of how Python licensing is set up. On Tue, Aug 20, 2019 at 7:48 AM mihaela olteanu via Python-Dev wrote: Is it possible to contact the contributors and have their explicit agreement or is the LICENSE file at the top level of the repo already covering this scenario? Thank you,Mihaela On Tuesday, August 20, 2019, 12:22:04 AM GMT+3, Ivan Pozdeev via Python-Dev wrote: On 19.08.2019 23:30, Terry Reedy wrote: > On 8/19/2019 3:19 PM, Jeff Allen wrote: >> This is undoubtedly the right answer for someone wanting to *use* code >> *from* CPython. >> >> When one signs up to contribute code to the PSF, one is asked to write on >> contributed software that it has been "Licensed to the PSF >> under a Contributor Agreement" (see >> https://www.python.org/psf/contrib/contrib-form/). The XXX comment may >> signal an intention to return >> and insert such words. > > The form says specifically "adjacent to Contributor's valid copyright > notice". *If* the contribution comes with a separate explicit > copyright notice (most do not), then it should be followed by the > contribution notice. > > ossaudiodev.c has 3 copyright notices, the last being by PSF in 2002, long > before he current Contributor Agreement, and apparently never > challenged. Hence Guido's claim that the module is covered by the general > PSF license. > The text has "All rights reserved" in all three lines which is _not_ a copyright notice but a license grant. It's those license grants, including PSF's, that are untrue. Compare with e.g. Tools/msi/bundle/bootstrap/pch.h and Modules/_hashopenssl.c in which a copyright notice correctly comes bare and is followed by a license grant compatible with PSFLA. -- Regards, Ivan ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/NX2IJXGR4S6N6X6EW2J2Z3U3XGOYBKVY/ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/WL4LKYTCEABYNRXN3VQV2NHFD4EMGRN5/ -- --Guido van Rossum (python.org/~guido)Pronouns: he/him/his (why is my pronoun here?)___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/VWJBFGF6WG4H4P3ETTG4DY2NTOJGDO7H/ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/37ISB5PI7EM6JKAO7B4TYMQ7DEWMPDQ5/
