[Python-Dev] Re: unable to create PR on github
And even more data: I added a body to the PR I was originally having trouble with: button stayed gray I went away for a while, say 5 - 10 minutes, and when I went back to that screen the button was green. I created the PR. -- ~Ethan~ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/WUD6CIZLGWOND36HMQPB7JRLIZSJAVCS/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: unable to create PR on github
On 9/21/20 6:09 PM, Ethan Furman wrote: The green "create pull request" button is greyed out. I've tried reselecting the repos and branches, logging out and in, navigating to that screen via my own repository -- nothing is working. I have more data: I pushed another branch and opened the link to create a PR: the button was green I changed the title: the button stayed green I removed the body comment (the template instructions) the button stayed green I clicked back into the title the button grayed out I hit to restore the body the button went green I removed the body the button stayed green I switched screens to type the last sentence, then went back the button grayed out (ARGH!) I restored the body (again with ), removed the body, clicked on the button while it was still green it went grey and nothing happened I restored the body and hit the button the PR was created, and the body was gone Hopefully that helps somebody. -- ~Ethan~ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/AL7KQ2J4RZIY7AXG7VEABAYC3S3LTCMA/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: unable to create PR on github
Is this still problem? Which fork/branch did you did you want to create to the PR with? On Mon, Sep 21, 2020, 6:14 PM Ethan Furman wrote: > The green "create pull request" button is greyed out. > > I've tried reselecting the repos and branches, logging out and in, > navigating to that screen via my own repository -- nothing is working. > > Any ideas? > > Thanks. > > -- > ~Ethan~ > ___ > Python-Dev mailing list -- python-dev@python.org > To unsubscribe send an email to python-dev-le...@python.org > https://mail.python.org/mailman3/lists/python-dev.python.org/ > Message archived at > https://mail.python.org/archives/list/python-dev@python.org/message/CTJTPEWLIFVV5G5HJZPURJC5T5LWW3BM/ > Code of Conduct: http://python.org/psf/codeofconduct/ > ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/YG7NJ5JFS4QQVEVS6OQHTVGLQNUI3BOM/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: unable to create PR on github
On Sep 21, 2020, at 21:09, Ethan Furman wrote: > The green "create pull request" button is greyed out. > > I've tried reselecting the repos and branches, logging out and in, navigating > to that screen via my own repository -- nothing is working. > > Any ideas? I tried creating a PR from a branch on my fork to master on python/cpython. The first time I tried it, after pressing the create PR button, the button dimmed and just sat there. Then, I tried to create a PR again and this time it seemed to work OK. No problems reported on https://www.githubstatus.com Try again? -- Ned Deily n...@python.org -- [] ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/TZO462DL7FEU67YJFYA5Y6PPIPYTVHAX/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] unable to create PR on github
The green "create pull request" button is greyed out. I've tried reselecting the repos and branches, logging out and in, navigating to that screen via my own repository -- nothing is working. Any ideas? Thanks. -- ~Ethan~ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/CTJTPEWLIFVV5G5HJZPURJC5T5LWW3BM/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Enum and the Standard Library
On Fri, Sep 18, 2020 at 10:42 PM Guido van Rossum wrote: > At the same time it's as old as Python -- for most builtins other than > strings, repr() and str() are the same, and modeled after repr(). > Historically, I only introduced the difference between str() and repr() > because of strings -- I wanted the REPL to clearly show the difference > between the number 42 and the string '42', but at the same time I wanted both > to print as just '42'. Of course numpy took a different fork in that road... That's an interesting history tidbit, thanks for sharing, Guido. Like Ethan, I also find that distinction invaluable! While researching the first edition of Fluent Python, I found the 1996 paper "How to Display an Object as a String: printString and displayString" [1]. In it, the author Bobby Woolf explains that VisualWorks Smalltalk's `Object` class provides two methods: """ • printString—Displays the object the way the developer wants to see it. • displayString—Displays the object the way the user wants to see it. """ I love these simple definitions, and they are followed by most Python classes that have distinct __repr__ and __str__. [1] http://esug.org/data/HistoricalDocuments/TheSmalltalkReport/ST07/04wo.pdf Developers or users rarely care about the numeric value of an Enum, so I am for __repr__ providing a "more qualified name" and __str__ providing a "less qualified name", but still qualified with at least one dot in it—eg. Color.RED and not RED). In the rare cases where someone cares about the underlying integer, let them get the value. Cheers, Luciano -- Luciano Ramalho | Author of Fluent Python (O'Reilly, 2015) | http://shop.oreilly.com/product/0636920032519.do | Technical Principal at ThoughtWorks | Twitter: @ramalhoorg ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/TW3CH3BFGUAPXJ34H5QSXWLK3BVTWZ3R/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Enum and the Standard Library
On 9/19/20 2:08 PM, Guido van Rossum wrote: I'm just trying to present an argument that if the str() of an enum was its name and the repr() was its "full name" (at least including the class) that would be pretty sweet. Well, we're still early enough in the 3.10 cycle we can make that change and see if anybody hollers. ;-) -- ~Ethan~ ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/EUCFEWGGOK3MFX44AN6BRW7GYAKA627W/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Re: Tagged pointer experiment: need help to optimize
On Mon, 21 Sep 2020 20:35:33 +0200 Victor Stinner wrote: > > When I proposed my PEP 620 "Hide implementation details from the C > API", I was asked about a proof that the PEP unlocks real optimization > possibilities. So I wrote an implementation of tagged pointers: > https://github.com/vstinner/cpython/pull/6 > > The main benefit is the memory usage. For example, list(range(200)) > uses 1656 bytes instead of 7262 (4x less memory). Hmm, how come? Aren't those tiny integers singletons already? I suppose you're thinking of something like `list(range(2000, 2200))`. > Sadly, my current simple implementation is 1.1x slower than the > reference. I suspect that adding a condition to Py_INCREF() and > Py_DECREF() explains a large part of this overhead. And adding a condition in every place an object is inspected. Even something as simple as Py_TYPE() is not a mere lookup anymore. > It would be nice to use tagged pointers for a wide range of integer > numbers, but I wrote a simple implementation: _Py_TAGPTR_UNBOX() has > to return a borrowed reference. This function should return a strong > reference to support a larger range. Hmm, it sounds a bit weird. The point of tagged pointers, normally, is to avoid creating objects at all. If you create an object dynamically each time a tagged pointer is "dereferenced", then I suspect you won't gain anything. Regards Antoine. ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/HFPMKQEY5LCWW6VCE27KGQWTVNZCNRRQ/ Code of Conduct: http://python.org/psf/codeofconduct/
[Python-Dev] Tagged pointer experiment: need help to optimize
Hi, I need to help to attempt to optimize my experimental CPython fork which uses tagged pointers. When I proposed my PEP 620 "Hide implementation details from the C API", I was asked about a proof that the PEP unlocks real optimization possibilities. So I wrote an implementation of tagged pointers: https://github.com/vstinner/cpython/pull/6 The main benefit is the memory usage. For example, list(range(200)) uses 1656 bytes instead of 7262 (4x less memory). Sadly, my current simple implementation is 1.1x slower than the reference. I suspect that adding a condition to Py_INCREF() and Py_DECREF() explains a large part of this overhead. My implementation uses tagged pointers for: * integers in the range: [-5; 256] * None, True and False singletons It would be nice to use tagged pointers for a wide range of integer numbers, but I wrote a simple implementation: _Py_TAGPTR_UNBOX() has to return a borrowed reference. This function should return a strong reference to support a larger range. More information in the document: https://github.com/vstinner/cpython/blob/tagged_ptr/TAGGED_POINTERS.rst Victor -- Night gathers, and now my watch begins. It shall not end until my death. ___ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/4ETF7H5COIZWTCXDRTITVMU4P5DLRDLU/ Code of Conduct: http://python.org/psf/codeofconduct/
