Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
I reported this: http://code.google.com/p/support/issues/detail?id=1006 The tracker is here: http://code.google.com/p/support/issues Thanks! On Mon, May 5, 2008 at 10:56 AM, Georg Brandl <[EMAIL PROTECTED]> wrote: > Guido van Rossum schrieb: > > > > On Mon, May 5, 2008 at 9:46 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> > wrote: > > > > > > This code is now open source! Browse it here: > > > > > > > > http://code.google.com/p/rietveld/source/browse > > > > > > Are you also going to call it Rietveld then? Sounds better > > > to me than "the open source code review tool". > > > > > > > I've been reluctant to use the Rietveld name too much since Americans > > can't spell it. :-) But the open source project *is* called Rietveld, > > so I suppose I should start using that name... > > > > BTW, Google code's Python highlighting is broken, look at > http://code.google.com/p/rietveld/source/browse/trunk/views.py line 205ff. > > Where can this be reported? > > Georg > > > > ___ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/guido%40python.org > -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
There is a google code support project where google code issues are tracked. http://code.google.com/p/support/ On Mon, May 5, 2008 at 2:56 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > That's a good question. I'll find out. > > > > On Mon, May 5, 2008 at 10:56 AM, Georg Brandl <[EMAIL PROTECTED]> wrote: > > Guido van Rossum schrieb: > > > > > > > On Mon, May 5, 2008 at 9:46 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> > > wrote: > > > > > > > > This code is now open source! Browse it here: > > > > > > > > > > http://code.google.com/p/rietveld/source/browse > > > > > > > > Are you also going to call it Rietveld then? Sounds better > > > > to me than "the open source code review tool". > > > > > > > > > > I've been reluctant to use the Rietveld name too much since Americans > > > can't spell it. :-) But the open source project *is* called Rietveld, > > > so I suppose I should start using that name... > > > > > > > BTW, Google code's Python highlighting is broken, look at > > http://code.google.com/p/rietveld/source/browse/trunk/views.py line 205ff. > > > > Where can this be reported? > > > > Georg > > > > > > > > ___ > > Python-Dev mailing list > > Python-Dev@python.org > > http://mail.python.org/mailman/listinfo/python-dev > > Unsubscribe: > > http://mail.python.org/mailman/options/python-dev/guido%40python.org > > > > > > > -- > --Guido van Rossum (home page: http://www.python.org/~guido/) > ___ > > > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/dberlin%40dberlin.org > ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
That's a good question. I'll find out. On Mon, May 5, 2008 at 10:56 AM, Georg Brandl <[EMAIL PROTECTED]> wrote: > Guido van Rossum schrieb: > > > > On Mon, May 5, 2008 at 9:46 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> > wrote: > > > > > > This code is now open source! Browse it here: > > > > > > > > http://code.google.com/p/rietveld/source/browse > > > > > > Are you also going to call it Rietveld then? Sounds better > > > to me than "the open source code review tool". > > > > > > > I've been reluctant to use the Rietveld name too much since Americans > > can't spell it. :-) But the open source project *is* called Rietveld, > > so I suppose I should start using that name... > > > > BTW, Google code's Python highlighting is broken, look at > http://code.google.com/p/rietveld/source/browse/trunk/views.py line 205ff. > > Where can this be reported? > > Georg > > > > ___ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > http://mail.python.org/mailman/options/python-dev/guido%40python.org > -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
Guido van Rossum schrieb: On Mon, May 5, 2008 at 9:46 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > This code is now open source! Browse it here: > > http://code.google.com/p/rietveld/source/browse Are you also going to call it Rietveld then? Sounds better to me than "the open source code review tool". I've been reluctant to use the Rietveld name too much since Americans can't spell it. :-) But the open source project *is* called Rietveld, so I suppose I should start using that name... BTW, Google code's Python highlighting is broken, look at http://code.google.com/p/rietveld/source/browse/trunk/views.py line 205ff. Where can this be reported? Georg ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Mon, May 5, 2008 at 10:32 AM, <[EMAIL PROTECTED]> wrote: > > Guido> I've been reluctant to use the Rietveld name too much since > Guido> Americans can't spell it. :-) But the open source project *is* > Guido> called Rietveld, so I suppose I should start using that name... > > Which reminds me... What's it mean? All I saw was a Dutch city and > (maybe?) a Dutch architect by that name. > > Skip > http://code.google.com/p/rietveld/wiki/CodeReviewBackground -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
Guido> I've been reluctant to use the Rietveld name too much since Guido> Americans can't spell it. :-) But the open source project *is* Guido> called Rietveld, so I suppose I should start using that name... Which reminds me... What's it mean? All I saw was a Dutch city and (maybe?) a Dutch architect by that name. Skip ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Mon, May 5, 2008 at 9:46 AM, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > > This code is now open source! Browse it here: > > > > http://code.google.com/p/rietveld/source/browse > > Are you also going to call it Rietveld then? Sounds better > to me than "the open source code review tool". I've been reluctant to use the Rietveld name too much since Americans can't spell it. :-) But the open source project *is* called Rietveld, so I suppose I should start using that name... -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
> This code is now open source! Browse it here: > > http://code.google.com/p/rietveld/source/browse Are you also going to call it Rietveld then? Sounds better to me than "the open source code review tool". Regards, Martin ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Sat, May 3, 2008 at 2:28 PM, Brett Cannon <[EMAIL PROTECTED]> wrote: ... > > I'd be great to integrate this with the bug tracker so that all submitted > > patches automagically show up in codereview with links to one another. > > Yeah, or a simple button to move it over there. Either way some > integration would be cool. > > Since this is being open-sourced we could probably have a python-dev > instance installed that has all this bonus functionality for us if we > can get an appspot account for the tracker team and there is some API > we can tap into in order to create new issues. Given the app engine model, I guess any "API" to an app engine-hosted service would have to be of the RESTful kind, i.e., some URLs to which client-code can POST appropriately. Alex ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Sat, May 3, 2008 at 1:20 PM, Gregory P. Smith <[EMAIL PROTECTED]> wrote: > > > > > > To try it out, go here: > > > >http://codereview.appspot.com > > > > Please use the Help link in the top right to read more on how to use > > the app. Please sign in using your Google Account (either a Gmail > > address or a non-Gmail address registered with Google) to interact > > more with the app (you need to be signed in to create new issues and > > to add comments to existing issues). > > > > Don't hesitate to drop me a note with feedback -- note though that > > there are a few known issues listed at the end of the Help page. The > > Help page is really a wiki, so feel free to improve it! > > I'd be great to integrate this with the bug tracker so that all submitted > patches automagically show up in codereview with links to one another. Yeah, or a simple button to move it over there. Either way some integration would be cool. Since this is being open-sourced we could probably have a python-dev instance installed that has all this bonus functionality for us if we can get an appspot account for the tracker team and there is some API we can tap into in order to create new issues. -Brett ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
> > To try it out, go here: > >http://codereview.appspot.com > > Please use the Help link in the top right to read more on how to use > the app. Please sign in using your Google Account (either a Gmail > address or a non-Gmail address registered with Google) to interact > more with the app (you need to be signed in to create new issues and > to add comments to existing issues). > > Don't hesitate to drop me a note with feedback -- note though that > there are a few known issues listed at the end of the Help page. The > Help page is really a wiki, so feel free to improve it! I'd be great to integrate this with the bug tracker so that all submitted patches automagically show up in codereview with links to one another. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Fri, May 2, 2008 at 2:28 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > One more question: What's the number on the upper right hand corner by > my username? It's a debugging counter. It gets reset each time a new service instance is created. -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Fri, May 2, 2008 at 4:25 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > My request at the moment is to let people use their real names for > > display; my email address does not at all resemble my name. > > I've noticed. Surely there's an interesting story there. :-) Maybe I tell you why next PyCon... One more question: What's the number on the upper right hand corner by my username? -- Cheers, Benjamin Peterson ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Fri, May 2, 2008 at 2:09 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > On Thu, May 1, 2008 at 11:41 AM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > Some of you may have seen a video recorded in November 2006 where I > > showed off Mondrian, a code review tool that I was developing for > > Google (http://www.youtube.com/watch?v=sMql3Di4Kgc). I've always hoped > > that I could release Mondrian as open source, but it was not to be: > > due to its popularity inside Google, it became more and more tied to > > proprietary Google infrastructure like Bigtable, and it remained > > limited to Perforce, the commercial revision control system most used > > at Google. > > I was salivating over that video, so I'm really excited be able to try > out something like it now. > > > > Don't hesitate to drop me a note with feedback -- note though that > > there are a few known issues listed at the end of the Help page. The > > Help page is really a wiki, so feel free to improve it! > > My request at the moment is to let people use their real names for > display; my email address does not at all resemble my name. I've noticed. Surely there's an interesting story there. :-) The feature request is on my TODO list. The design is a bit involved, since I'd have to ask people to register and maintain a userid -> nickname mapping; the Google Account API we're piggybacking on only gives you the email address. Once it's open sourced (Monday?) I'd love to see contributions like this! -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Thu, May 1, 2008 at 11:41 AM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > Some of you may have seen a video recorded in November 2006 where I > showed off Mondrian, a code review tool that I was developing for > Google (http://www.youtube.com/watch?v=sMql3Di4Kgc). I've always hoped > that I could release Mondrian as open source, but it was not to be: > due to its popularity inside Google, it became more and more tied to > proprietary Google infrastructure like Bigtable, and it remained > limited to Perforce, the commercial revision control system most used > at Google. I was salivating over that video, so I'm really excited be able to try out something like it now. > Don't hesitate to drop me a note with feedback -- note though that > there are a few known issues listed at the end of the Help page. The > Help page is really a wiki, so feel free to improve it! My request at the moment is to let people use their real names for display; my email address does not at all resemble my name. -- Cheers, Benjamin Peterson ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Thu, 1 May 2008, Neal Becker wrote: > It would be really nice to see support for some other backends, such as Hg > or bzr (which are both written in python), in addition to svn. /me starts the clamour for git -- Cheers, Leif ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Thu, May 1, 2008 at 4:37 PM, Neal Becker <[EMAIL PROTECTED]> wrote: > It would be really nice to see support for some other backends, such as Hg > or bzr (which are both written in python), in addition to svn. Once it's open source feel free to add those! -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Thu, May 1, 2008 at 4:24 PM, Terry Reedy <[EMAIL PROTECTED]> wrote: > > "Guido van Rossum" <[EMAIL PROTECTED]> wrote in message > news:[EMAIL PROTECTED] > > | On Thu, May 1, 2008 at 2:42 PM, Terry Reedy <[EMAIL PROTECTED]> wrote: > | > As I understood this,one needs a diff to comment on. > | > I can imagine wanting, or wanting others, to be able to comment on a > file > | > or lines of files without making a fake diff (of the file versus > itself or > | > a blank file). Then only one column would be needed. > | > | Yeah, this use case is not well supported. In my experience with the > | internal tool at Google, I don't think that anybody has ever requested > | that feature, so perhaps in practice it's not so common. I mean, who > | wants to review a 5000-line file once it's checked in? :-) The right > | point for such a review (certainly this is the case at Google) is when > | it goes in. > > I am thinking of an entirely different scenario: a package of modules that > are maybe a few hundred lines each and that accompany a book and are meant > for human reading as much or more than for machine execution. > > Or this: 15 minutes ago I was reading a PEP and discovered that a link did > not work. So I find the non-clickable author email at the top and notify > the author with my email program. But how much nicer to double click an > adjacent line and stick the comment in place (and let your system do the > emailing). (I presume the sponsor of an item in your system can remove > no-longer-needed comments.) So I guess I am thinking of your system as one > for collaborative online editing rather than just patch review. I agree that those are all great use cases. Eventually we'll be able to support these; right now though, I'd like to focus on the more immediate need (IMO) of patch reviews. -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Invitation to try out open source code review tool
On Thu, May 1, 2008 at 2:42 PM, Terry Reedy <[EMAIL PROTECTED]> wrote: > As I understood this,one needs a diff to comment on. > I can imagine wanting, or wanting others, to be able to comment on a file > or lines of files without making a fake diff (of the file versus itself or > a blank file). Then only one column would be needed. Yeah, this use case is not well supported. In my experience with the internal tool at Google, I don't think that anybody has ever requested that feature, so perhaps in practice it's not so common. I mean, who wants to review a 5000-line file once it's checked in? :-) The right point for such a review (certainly this is the case at Google) is when it goes in. > I presume the current site is for trial purposes. Actually I'm hoping to keep it alive forever, just evolving the functionality based on feedback. > You obviously don't want > hundreds of repositories listed. Repository management is a bit of an open problem. Fortunately, when you use upload.py, you don't need to have a repository listed -- upload.py will specify the correct base URL, especially for repositories hosted at Google. (I should probably figure out how to support SourceForge as well...) > Are you planning, for instance, to > suggest that Google project hosting add a Review tab or link to the project > pages? They've been following my release with interest... > And I followed the link to pages about Rietveld ;-) Thanks. :-) -- --Guido van Rossum (home page: http://www.python.org/~guido/) ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
