Re: [Python-Dev] [Python-checkins] cpython: Fixes test_getargs2 to get the buildbots working again.

[Steve Dower]

On 11Sep2016 1959, Martin Panter wrote:

On 12 September 2016 at 02:48, Steve Dower  wrote:

  Fixes test_getargs2 to get the buildbots working again.


I'm not sure this is the fix we want to keep here, but it was sufficient to
get the test going and unblock all the buildbots.

I'm not entirely sure when the break appeared (essentially we seem to not be
copying *args into a new tuple), but I'd guess it's to do with the fast
calling improvements.


That seems to be everyone else’s guess too. See
https://bugs.python.org/issue28086 (bug about this failure)
https://bugs.python.org/issue27213 (bisected cause)



Huh, I searched and didn't find anything. Maybe I typo'd my search query?

Looking at the bisected cause, it seems like the intent is to allow 
subclasses of tuple to pass through. Considering this is seriously going 
to hold up beta 1, I'd rather assume that's the intent and unblock the 
release.


Cheers,
Steve
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] cpython: Fixes test_getargs2 to get the buildbots working again.

[Martin Panter]

On 12 September 2016 at 02:48, Steve Dower  wrote:
>>   Fixes test_getargs2 to get the buildbots working again.
>
> I'm not sure this is the fix we want to keep here, but it was sufficient to
> get the test going and unblock all the buildbots.
>
> I'm not entirely sure when the break appeared (essentially we seem to not be
> copying *args into a new tuple), but I'd guess it's to do with the fast
> calling improvements.

That seems to be everyone else’s guess too. See
https://bugs.python.org/issue28086 (bug about this failure)
https://bugs.python.org/issue27213 (bisected cause)
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] [Python-checkins] cpython: Fixes test_getargs2 to get the buildbots working again.

[Steve Dower]

On 11Sep2016 1944, steve.dower wrote:

https://hg.python.org/cpython/rev/7793d34609cb
changeset:   103679:7793d34609cb
user:Steve Dower 
date:Sun Sep 11 19:43:51 2016 -0700
summary:
  Fixes test_getargs2 to get the buildbots working again.

files:
  Lib/test/test_getargs2.py |  2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/Lib/test/test_getargs2.py b/Lib/test/test_getargs2.py
--- a/Lib/test/test_getargs2.py
+++ b/Lib/test/test_getargs2.py
@@ -471,7 +471,7 @@

 ret = get_args(*TupleSubclass([1, 2]))
 self.assertEqual(ret, (1, 2))
-self.assertIs(type(ret), tuple)
+self.assertIsInstance(ret, tuple)

 ret = get_args()
 self.assertIn(ret, ((), None))


I'm not sure this is the fix we want to keep here, but it was sufficient 
to get the test going and unblock all the buildbots.


I'm not entirely sure when the break appeared (essentially we seem to 
not be copying *args into a new tuple), but I'd guess it's to do with 
the fast calling improvements.


Cheers,
Steve


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com