Re: [Python-Dev] [wwwsearch-general] 2.5: recently introduced sgmllib regexp bug hangs Python

2006-08-17 Thread Anthony Baxter
On Thursday 17 August 2006 12:13, John J Lee wrote:
 On Thu, 17 Aug 2006, John J Lee wrote:
 [...]

  If nobody has time to fix this, perhaps rev 47154 should be reverted?

 I should have put it more strongly: I think it *should* in fact be
 reverted if nobody has time to fix it before the release candidate / final
 release of 2.5.  The revision in question is the most recent commit to
 sgmllib.py and certainly appears completely localised to that module.
 And a hung interpreter is worse than failing to parse some HTML, IMHO.

Well, it's a bit late for the release candidate :-) but I agree - if it can't 
be fixed before 2.5 final, it should be reverted.

Anthony

-- 
Anthony Baxter [EMAIL PROTECTED]
It's never too late to have a happy childhood.
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] [wwwsearch-general] 2.5: recently introduced sgmllib regexp bug hangs Python

2006-08-17 Thread Benji York
John J Lee wrote:
 Looks like revision 47154 introduced a regexp that hangs Python

Revision 47155 was a similar change to the 2.4 branch.
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] [wwwsearch-general] 2.5: recently introduced sgmllib regexp bug hangs Python

2006-08-16 Thread John J Lee
On Thu, 17 Aug 2006, John J Lee wrote:
[...]
 If nobody has time to fix this, perhaps rev 47154 should be reverted?

I should have put it more strongly: I think it *should* in fact be 
reverted if nobody has time to fix it before the release candidate / final 
release of 2.5.  The revision in question is the most recent commit to 
sgmllib.py and certainly appears completely localised to that module. 
And a hung interpreter is worse than failing to parse some HTML, IMHO.


[...]
 commit message for -r47154:

 
 SF bug #1504333: sgmlib should allow angle brackets in quoted values
 (modified patch by Sam Ruby; changed to use separate REs for start and end
  tags to reduce matching cost for end tags; extended tests; updated to
 avoid
  breaking previous changes to support IPv6 addresses in unquoted attribute
  values)
 
[...]

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com