Re: [Python-Dev] Merging the implementation of PEP 563

[Yury Selivanov]

I looked at the PR and I think the code is fine.

Yury

On Thu, Jan 25, 2018 at 4:39 PM, Victor Stinner
 wrote:
> Hi,
>
> If nobody is available to review your PR, I suggest to push it anyway,
> to get it merged before the feature freeze. The code can be reviewed
> later. Merging it sooner gives more time to test it and spot bugs. It
> also gives more time to fix bugs ;-) Well, at the end, it's up to you.
>
> Victor
>
> 2018-01-25 22:07 GMT+01:00 Lukasz Langa :
>> Hi all,
>> Serhiy looks busy these days. I'd appreciate somebody looking at and
>> hopefully merging https://github.com/python/cpython/pull/4390. Everything
>> there was reviewed by Serhiy except for the latest commit.
>>
>> This should be ready to merge and maybe tweak in the beta stage. I'd like to
>> avoid merging it myself but I'd really hate missing the deadline.
>>
>> - Ł
>>
>> ___
>> Python-Dev mailing list
>> Python-Dev@python.org
>> https://mail.python.org/mailman/listinfo/python-dev
>> Unsubscribe:
>> https://mail.python.org/mailman/options/python-dev/victor.stinner%40gmail.com
>>
> ___
> Python-Dev mailing list
> Python-Dev@python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: 
> https://mail.python.org/mailman/options/python-dev/yselivanov.ml%40gmail.com
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Re: [Python-Dev] Merging the implementation of PEP 563

[Victor Stinner]

Hi,

If nobody is available to review your PR, I suggest to push it anyway,
to get it merged before the feature freeze. The code can be reviewed
later. Merging it sooner gives more time to test it and spot bugs. It
also gives more time to fix bugs ;-) Well, at the end, it's up to you.

Victor

2018-01-25 22:07 GMT+01:00 Lukasz Langa :
> Hi all,
> Serhiy looks busy these days. I'd appreciate somebody looking at and
> hopefully merging https://github.com/python/cpython/pull/4390. Everything
> there was reviewed by Serhiy except for the latest commit.
>
> This should be ready to merge and maybe tweak in the beta stage. I'd like to
> avoid merging it myself but I'd really hate missing the deadline.
>
> - Ł
>
> ___
> Python-Dev mailing list
> Python-Dev@python.org
> https://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> https://mail.python.org/mailman/options/python-dev/victor.stinner%40gmail.com
>
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

[Python-Dev] Merging the implementation of PEP 563

[Lukasz Langa]

Hi all,
Serhiy looks busy these days. I'd appreciate somebody looking at and hopefully 
merging https://github.com/python/cpython/pull/4390 
. Everything there was reviewed by 
Serhiy except for the latest commit.

This should be ready to merge and maybe tweak in the beta stage. I'd like to 
avoid merging it myself but I'd really hate missing the deadline.

- Ł


signature.asc
Description: Message signed with OpenPGP
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com