[Python-Dev] Re: 1 PR, multiple issues

[Mariatta]

Thanks Jeffrey Kintscher for asking this question.
It is one of those "less obvious way to triage CPython issues" kind of
thing.
I think it would be great if this workflow can be documented and clarified
in the devguide.
I've opened https://github.com/python/devguide/issues/494
ᐧ
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/T2VY2IQRRLJ4WQGBOAAIBTOC7GBESNI2/

[Python-Dev] Re: 1 PR, multiple issues

[Terry Reedy]

This was more of a core-mentorship question (tracker management) than a 
pydev question (Python development).  But since we are here...


On 6/10/2019 11:41 PM, Mariatta wrote:
Hmm, I personally would still consider the additional issues as 
duplicates. So I would make note in each of the duplicate issue saying 
"this is caused by the same problem as bpo-X", and close them, and 
attach the PR only to one bpo ticket.
To decide which one I would keep open, perhaps the oldest one, but maybe 
it depends. Perhaps whichever that seems to contain most detailed info?


Maybe other core devs have other preferences?


No me.  The general rule/convention has been to keep the oldest open and 
close others.  I put a note on the one kept open as to others closed.


If it is discovered after the fact that a patch for A fixed B, B can be 
closed as 'out-of-date' with a comment 'fixed by ...'


--
Terry Jan Reedy
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/XKPMAEDXKUSOK6VPQXYRAP6JY4JYL37W/

[Python-Dev] Re: 1 PR, multiple issues

[Ned Deily]

On Jun 10, 2019, at 23:41, Mariatta  wrote:
> On Mon, Jun 10, 2019 at 8:19 PM Jeffrey Kintscher  
> wrote:
>> A hypothetical example would be two different issues whose descriptions 
>> appear to be for different behaviors, but are actually caused by the same 
>> underlying chunk of problematic code being called in different ways. It 
>> could be something trivial like a corner case not being handled.
> Hmm, I personally would still consider the additional issues as duplicates. 
> So I would make note in each of the duplicate issue saying "this is caused by 
> the same problem as bpo-X", and close them, and attach the PR only to one bpo 
> ticket.
> To decide which one I would keep open, perhaps the oldest one, but maybe it 
> depends. Perhaps whichever that seems to contain most detailed info? 

I agree.  If it seems better to solve everything in one PR, I would generally 
associate the PR with one issue and close the others as duplicates with 
explanations why.

--
  Ned Deily
  n...@python.org -- []
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/LGOT7ID2QQC5FPY77YVX3MH3N3WZUEY2/

[Python-Dev] Re: 1 PR, multiple issues

[Mariatta]

Hmm, I personally would still consider the additional issues as duplicates.
So I would make note in each of the duplicate issue saying "this is caused
by the same problem as bpo-X", and close them, and attach the PR only to
one bpo ticket.
To decide which one I would keep open, perhaps the oldest one, but maybe it
depends. Perhaps whichever that seems to contain most detailed info?

Maybe other core devs have other preferences?

On Mon, Jun 10, 2019 at 8:19 PM Jeffrey Kintscher 
wrote:

> A hypothetical example would be two different issues whose descriptions
> appear to be for different behaviors, but are actually caused by the same
> underlying chunk of problematic code being called in different ways. It
> could be something trivial like a corner case not being handled.
>
> //Jeff
>
> ᐧ
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/6LYS2FPQXIYUAQKIATA2ZUAPNYR6OIAL/

[Python-Dev] Re: 1 PR, multiple issues

[Jeffrey Kintscher]

A hypothetical example would be two different issues whose descriptions 
appear to be for different behaviors, but are actually caused by the 
same underlying chunk of problematic code being called in different 
ways. It could be something trivial like a corner case not being handled.


//Jeff

On 6/10/19 7:57 PM, Mariatta wrote:
Usually we prefer 1 PR per 1 bpo ticket. The smaller the PR is, the 
easier it is for us to review, and less likely to cause conflict when 
it comes to auto-backporting.


When you say it resolves multiple issues, are these the same issue 
reported multiple times?

ᐧ

On Mon, Jun 10, 2019 at 7:52 PM Jeffrey Kintscher 
mailto:websur...@surf2c.net>> wrote:


When I create a PR that resolves multiple issues, should I add it
to each issue, or just to one issue and add relevant comments to
the others?

//Jeff

-- 
-

 From there to here, from here to there,
funny things are everywhere.
-- Theodore Geisel

___
Python-Dev mailing list -- python-dev@python.org

To unsubscribe send an email to python-dev-le...@python.org

https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at

https://mail.python.org/archives/list/python-dev@python.org/message/74FS2DW2L4MDJXRREAABXYRWNI6INMBA/



--
-
From there to here, from here to there,
funny things are everywhere.
   -- Theodore Geisel

___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/2UWQJWABSSJZD2YRJGMHZQ5WD64HV3UM/

[Python-Dev] Re: 1 PR, multiple issues

[Mariatta]

Usually we prefer 1 PR per 1 bpo ticket. The smaller the PR is, the easier
it is for us to review, and less likely to cause conflict when it comes to
auto-backporting.

When you say it resolves multiple issues, are these the same issue reported
multiple times?
ᐧ

On Mon, Jun 10, 2019 at 7:52 PM Jeffrey Kintscher 
wrote:

> When I create a PR that resolves multiple issues, should I add it to each
> issue, or just to one issue and add relevant comments to the others?
>
> //Jeff
>
> --
> -
> From there to here, from here to there,
> funny things are everywhere.
>-- Theodore Geisel
>
> ___
> Python-Dev mailing list -- python-dev@python.org
> To unsubscribe send an email to python-dev-le...@python.org
> https://mail.python.org/mailman3/lists/python-dev.python.org/
> Message archived at
> https://mail.python.org/archives/list/python-dev@python.org/message/74FS2DW2L4MDJXRREAABXYRWNI6INMBA/
>
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/34H2ECYKINM4ATVJU5YLIBXP5CEMXU3G/