[Python-Dev] Re: unable to create PR on github

2020-09-23 Thread Mats Wichmann
On 9/22/20 1:20 AM, Antoine Pitrou wrote:
> On Mon, 21 Sep 2020 20:56:18 -0700
> Ethan Furman  wrote:
>> And even more data:
>>
>> I added a body to the PR I was originally having trouble with:
>>button stayed gray
>>
>> I went away for a while, say 5 - 10 minutes, and when I went back to 
>> that screen the button was green.  I created the PR.
> 
> Recently, I had to add a body text to create a PR (on another repo),
> otherwise the button would be grayed out.  So that seems to be the
> reason.

I've had the same with the title... github has some heuristic about when
a PR is ready to proceed with, which includes certain fields plus maybe
requirements a project may have imposed, and in what's probably a
gigabyte of hairy javascript, it appears to be confusable.

The commandline client (gh pr create ) might avoid some of that mess?

___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/SV3DPIZCXPRLTA67PRIIPWU7KHFGKQZT/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: unable to create PR on github

2020-09-22 Thread Antoine Pitrou
On Mon, 21 Sep 2020 20:56:18 -0700
Ethan Furman  wrote:
> And even more data:
> 
> I added a body to the PR I was originally having trouble with:
>button stayed gray
> 
> I went away for a while, say 5 - 10 minutes, and when I went back to 
> that screen the button was green.  I created the PR.

Recently, I had to add a body text to create a PR (on another repo),
otherwise the button would be grayed out.  So that seems to be the
reason.

Regards

Antoine.

___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/SAT6OGCSQEEKU6Y47AECSNW7OS43RT4Z/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: unable to create PR on github

2020-09-21 Thread Ethan Furman

And even more data:

I added a body to the PR I was originally having trouble with:
  button stayed gray

I went away for a while, say 5 - 10 minutes, and when I went back to 
that screen the button was green.  I created the PR.


--
~Ethan~
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/WUD6CIZLGWOND36HMQPB7JRLIZSJAVCS/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: unable to create PR on github

2020-09-21 Thread Ethan Furman

On 9/21/20 6:09 PM, Ethan Furman wrote:


The green "create pull request" button is greyed out.

I've tried reselecting the repos and branches, logging out and in, 
navigating to that screen via my own repository -- nothing is working.


I have more data:

I pushed another branch and opened the link to create a PR:
  the button was green

I changed the title:
  the button stayed green

I removed the body comment (the template instructions)
  the button stayed green

I clicked back into the title
  the button grayed out

I hit  to restore the body
  the button went green

I removed the body
  the button stayed green

I switched screens to type the last sentence, then went back
  the button grayed out  (ARGH!)

I restored the body (again with ), removed the body, clicked on 
the button while it was still green

  it went grey and nothing happened

I restored the body and hit the button
  the PR was created, and the body was gone

Hopefully that helps somebody.

--
~Ethan~
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/AL7KQ2J4RZIY7AXG7VEABAYC3S3LTCMA/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: unable to create PR on github

2020-09-21 Thread Mariatta
Is this still  problem? Which fork/branch did you did you want to create to
the PR with?



On Mon, Sep 21, 2020, 6:14 PM Ethan Furman  wrote:

> The green "create pull request" button is greyed out.
>
> I've tried reselecting the repos and branches, logging out and in,
> navigating to that screen via my own repository -- nothing is working.
>
> Any ideas?
>
> Thanks.
>
> --
> ~Ethan~
> ___
> Python-Dev mailing list -- python-dev@python.org
> To unsubscribe send an email to python-dev-le...@python.org
> https://mail.python.org/mailman3/lists/python-dev.python.org/
> Message archived at
> https://mail.python.org/archives/list/python-dev@python.org/message/CTJTPEWLIFVV5G5HJZPURJC5T5LWW3BM/
> Code of Conduct: http://python.org/psf/codeofconduct/
>
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/YG7NJ5JFS4QQVEVS6OQHTVGLQNUI3BOM/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: unable to create PR on github

2020-09-21 Thread Ned Deily
On Sep 21, 2020, at 21:09, Ethan Furman  wrote:
> The green "create pull request" button is greyed out.
> 
> I've tried reselecting the repos and branches, logging out and in, navigating 
> to that screen via my own repository -- nothing is working.
> 
> Any ideas?

I tried creating a PR from a branch on my fork to master on python/cpython. The 
first time I tried it, after pressing the create PR button, the button dimmed 
and just sat there.  Then, I tried to create a PR again and this time it seemed 
to work OK.

No problems reported on https://www.githubstatus.com

Try again?

--
  Ned Deily
  n...@python.org -- []
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/TZO462DL7FEU67YJFYA5Y6PPIPYTVHAX/
Code of Conduct: http://python.org/psf/codeofconduct/