Re: [Python-Dev] Refactoring test.support into a subpackage
On 15 July 2013 20:22, Nick Coghlan ncogh...@gmail.com wrote: At the PyCon AU sprints, some of the sprinters worked on a plan Chris Jerdonek and I came up with months ago to convert test.support from a module into a subpackage. This plan arose from some nasty test suite hacks in the lead up to the release of Python 3.3, where some of the pkgutil tests ended up in test.test_runpy so they could use the package creation infrastructure I have in there without needing to extract a helper module with a release imminent. The scope of the plan covers a few distinct steps: 1. Move Lib/test/support.py to Lib/test/support/__init__.py (http://bugs.python.org/issue15494) 2. Add a new (documented) test.support.pkg_helper submodule with the package creation support code (http://bugs.python.org/issue15403 and http://bugs.python.org/issue15376) 3. Move the pkgutil tests to test.test_pkgutil where they belong (http://bugs.python.org/issue15358) Just a heads up that I'm working on these first three steps this evening, so the Lib/test/support.py - Lib/test/support/__init__.py move will happen shortly. I'll also be landing the patch to add test.support.temp_dir() and test.support.change_cwd() This shouldn't affect any other patches, unless they're adding or change things in test.support. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Refactoring test.support into a subpackage
On 28 July 2013 20:20, Nick Coghlan ncogh...@gmail.com wrote: The scope of the plan covers a few distinct steps: 1. Move Lib/test/support.py to Lib/test/support/__init__.py (http://bugs.python.org/issue15494) 2. Add a new (documented) test.support.pkg_helper submodule with the package creation support code (http://bugs.python.org/issue15403 and http://bugs.python.org/issue15376) 3. Move the pkgutil tests to test.test_pkgutil where they belong (http://bugs.python.org/issue15358) Just a heads up that I'm working on these first three steps this evening, so the Lib/test/support.py - Lib/test/support/__init__.py move will happen shortly. I'll also be landing the patch to add test.support.temp_dir() and test.support.change_cwd() The test.support switch (#15494) and the factoring out of the temporary directory helpers to test.support (#15415) are done for both 3.3 and default (so it should be OK to rely on them without causing merge conflicts in the tests). #15403, #15376 and #15358 (the package testing cleanups) are still open, but are also simpler to deal with now that test.support is a package. I also created #18576 to cover moving and documenting script_helper, and #18578 to cover moving and documenting bytecode_helper. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Refactoring test.support into a subpackage
At the PyCon AU sprints, some of the sprinters worked on a plan Chris Jerdonek and I came up with months ago to convert test.support from a module into a subpackage. This plan arose from some nasty test suite hacks in the lead up to the release of Python 3.3, where some of the pkgutil tests ended up in test.test_runpy so they could use the package creation infrastructure I have in there without needing to extract a helper module with a release imminent. The scope of the plan covers a few distinct steps: 1. Move Lib/test/support.py to Lib/test/support/__init__.py (http://bugs.python.org/issue15494) 2. Add a new (documented) test.support.pkg_helper submodule with the package creation support code (http://bugs.python.org/issue15403 and http://bugs.python.org/issue15376) 3. Move the pkgutil tests to test.test_pkgutil where they belong (http://bugs.python.org/issue15358) 4. Move the existing test.script_helper and test.bytecode_helper support modules into the test.support subpackage and document them (no issue for that as yet) These changes would be made on both 3.3 and default, to avoid future merge conflicts (note that Indra also posted an updated patch for one pending test suite update to cope with the relocation: http://bugs.python.org/issue15415) My main motivation for doing this is to give a bit more visibility to the helpers that already exist, as well as making them easier to find when we want to look into the details of what a test is doing. At the moment, they tend to get lost in the sea of actual test files in the main test directory. (Chris and I initially held off on this while waiting for the final 3.2 release, and then that got delayed and it wasn't until Indra, Michael and Stephen started looking into it at the sprints that I started paying attention again) Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Refactoring test.support into a subpackage
On 7/15/2013 6:22 AM, Nick Coghlan wrote: At the PyCon AU sprints, some of the sprinters worked on a plan Chris Jerdonek and I came up with months ago to convert test.support from a module into a subpackage. This plan arose from some nasty test suite hacks in the lead up to the release of Python 3.3, where some of the pkgutil tests ended up in test.test_runpy so they could use the package creation infrastructure I have in there without needing to extract a helper module with a release imminent. The scope of the plan covers a few distinct steps: 1. Move Lib/test/support.py to Lib/test/support/__init__.py (http://bugs.python.org/issue15494) 2. Add a new (documented) test.support.pkg_helper submodule with the package creation support code (http://bugs.python.org/issue15403 and http://bugs.python.org/issue15376) 3. Move the pkgutil tests to test.test_pkgutil where they belong (http://bugs.python.org/issue15358) 4. Move the existing test.script_helper and test.bytecode_helper support modules into the test.support subpackage and document them (no issue for that as yet) These changes would be made on both 3.3 and default, to avoid future merge conflicts (note that Indra also posted an updated patch for one pending test suite update to cope with the relocation: http://bugs.python.org/issue15415) My main motivation for doing this is to give a bit more visibility to the helpers that already exist, as well as making them easier to find Bundling together all the support code I should know about sounds good to me. I only became aware of script_helper, recently, when I saw it imported in a test_xxx file. I still have no idea what it does. when we want to look into the details of what a test is doing. At the moment, they tend to get lost in the sea of actual test files in the main test directory. -- Terry Jan Reedy ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
