Re: [Python-Dev] Running the unit test as root/administrator

2013-12-05 Thread Martin v. Löwis
Am 05.12.13 02:04, schrieb Vajrasky Kok:
 Cool. What about Linux/Unix/BSD with root account? If we have
 something similar, I may plan to write unit test for spwd module.

Can you please phrase your question more explicit? What is it that
you want to be done before writing unit tests for the spwd module?

Anybody could run the test suite, and somebody might run it as root -
so you must be asking for something else.

Regards,
Martin


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-05 Thread Martin v. Löwis
Am 05.12.13 16:21, schrieb Vajrasky Kok:
 On Thu, Dec 5, 2013 at 11:06 PM, Martin v. Löwis mar...@v.loewis.de wrote:

 Can you please phrase your question more explicit? What is it that
 you want to be done before writing unit tests for the spwd module?
 
 I am asking buildbot of Linux/Unix/BSD with root account. Do we have it now?

Ah. I don't think we have one. If somebody would want to donate one, I
suggest to run it in a VM, to reduce the (valid) security concerns that
Guido has voiced. If a snapshot of the VM is made, it would be easy to
restore in case a commit performs serious damage.

Regards,
Martin
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-05 Thread Chris Angelico
On Fri, Dec 6, 2013 at 2:29 AM, Martin v. Löwis mar...@v.loewis.de wrote:
 Am 05.12.13 16:21, schrieb Vajrasky Kok:
 On Thu, Dec 5, 2013 at 11:06 PM, Martin v. Löwis mar...@v.loewis.de 
 wrote:

 Can you please phrase your question more explicit? What is it that
 you want to be done before writing unit tests for the spwd module?

 I am asking buildbot of Linux/Unix/BSD with root account. Do we have it now?

 Ah. I don't think we have one. If somebody would want to donate one, I
 suggest to run it in a VM, to reduce the (valid) security concerns that
 Guido has voiced. If a snapshot of the VM is made, it would be easy to
 restore in case a commit performs serious damage.

Are we worried about malicious or accidental damage, here?

I might be able to offer a buildbot VM, though I don't know what the
requirements are.

ChrisA
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-05 Thread Vajrasky Kok
On Thu, Dec 5, 2013 at 11:06 PM, Martin v. Löwis mar...@v.loewis.de wrote:

 Can you please phrase your question more explicit? What is it that
 you want to be done before writing unit tests for the spwd module?

I am asking buildbot of Linux/Unix/BSD with root account. Do we have it now?


 Anybody could run the test suite, and somebody might run it as root -
 so you must be asking for something else.


Of course, I can write unit test for spwd module right now and mark it
only to be run with root account and skipped with regular user
account. But I would argue that it would be hard to find people
running test suite with root account. That's why buildbot is helping
much in this case.

--Vajrasky
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-05 Thread Martin v. Löwis
Am 05.12.13 16:31, schrieb Chris Angelico:
 Ah. I don't think we have one. If somebody would want to donate one, I
 suggest to run it in a VM, to reduce the (valid) security concerns that
 Guido has voiced. If a snapshot of the VM is made, it would be easy to
 restore in case a commit performs serious damage.
 
 Are we worried about malicious or accidental damage, here?

Accidental damage is a serious risk, IMO. Malicious damage is a risk
for the paranoid: it might be that an SSH key gets stolen, and is then
used to commit a trojan. Of course, that would affect all build slaves
(but less so if they run in a restricted account), and we would disable
the key as soon as we notice, but some damage might have happened.

 I might be able to offer a buildbot VM, though I don't know what the
 requirements are.

The machine should be up most of the time, including internet
connectivity. A fixed IP address is no requirement (although I'm
unsure how resilient the slaves are when the IP changes). The
admin (i.e. you) needs to set up the box initially, and then care
for it in case of problems; a response time of a few days for
most of the year would be appreciated (although we can also deal
with operators that leave for longer periods of time - we just
disable the slave then, and reenable it when the admin brings
it back up). The commitment should be for a long period, i.e.
a few years.

Regards,
Martin


___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-04 Thread Brian Curtin
On Tue, Dec 3, 2013 at 8:14 PM, Ryan Gonzalez rym...@gmail.com wrote:

 Just don't run it on Windows...


Not helpful.

I'm in meetings/training/traveling all week, but I'll get another Windows
build slave up within the next few days. I used to have a spare desktop box
that ran a build slave as admin so it would exercise the os.symlink code,
but I moved, then the box died, etc.
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-04 Thread Vajrasky Kok
On Thu, Dec 5, 2013 at 7:07 AM, Brian Curtin br...@python.org wrote:

 Not helpful.

 I'm in meetings/training/traveling all week, but I'll get another Windows
 build slave up within the next few days. I used to have a spare desktop box
 that ran a build slave as admin so it would exercise the os.symlink code,
 but I moved, then the box died, etc.



Cool. What about Linux/Unix/BSD with root account? If we have
something similar, I may plan to write unit test for spwd module.

--Vajrasky
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] Running the unit test as root/administrator

2013-12-03 Thread Vajrasky Kok
Greetings, comrades!

Having handled these two issues personally:

http://bugs.python.org/issue19877
- test related with symlink fails on Windows Vista with administrator
account (in Windows NT 6, only account in administrator group can
create symlink)
http://bugs.python.org/issue18678
- bug in spwd module, which can be used only by root

I believe there is a virtue of running the unit test as
root/administrator to catch these errors automatically. Currently
there is no unit test for spwd module.

What do you say, comrades?

--Vajrasky
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-03 Thread Guido van Rossum
I would be rather worried about some accidental Trojen running that way.
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-03 Thread Cameron Simpson
On 03Dec2013 08:25, Guido van Rossum gu...@python.org wrote:
 I would be rather worried about some accidental Trojen running that way.

Or even just a badly framed clean-up-temp-files step.
-- 
Cameron Simpson c...@zip.com.au

manual, n.:
A unit of documentation. There are always three or more on a given item.
One is on the shelf; someone has the others.
The information you need is in the others.   - Ray Simard
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] Running the unit test as root/administrator

2013-12-03 Thread Ryan Gonzalez
Just don't run it on Windows...


On Tue, Dec 3, 2013 at 10:25 AM, Guido van Rossum gu...@python.org wrote:

 I would be rather worried about some accidental Trojen running that way.

 ___
 Python-Dev mailing list
 Python-Dev@python.org
 https://mail.python.org/mailman/listinfo/python-dev
 Unsubscribe:
 https://mail.python.org/mailman/options/python-dev/rymg19%40gmail.com




-- 
Ryan
When your hammer is C++, everything begins to look like a thumb.
___
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com