[Python-Dev] Extendability of C vs Python pickle
On Mon, 10 Jul 2017 02:35:37 +0200 Victor Stinner wrote: > > I already proposed to remove this benchmark: > https://mail.python.org/pipermail/speed/2017-April/000554.html > > *but* Antoine Pitrou mentionned that the cloudpickle project uses it. > > Maybe we should try to understand what's wrong with _pickle (C module) > for cloudpickle? That's a good question, Victor. cloudpickle uses three hooks inside pickle.py's Pickler: - the "dispatch" dictionary - overriding the "save_global" method to support saving more objects (such as closures, etc.) - overriding the "save_reduce" method; this one doesn't seem really necessary, perhaps some leftover from previous attempts _pickle.c's Pickler does seem to allow a custom "dispatch_table", but it doesn't allow overriding "save_global". Of course, if _pickle.c were improved to allow such extensions, it would suddenly allow cloudpickle to be much more performant! Regards Antoine. ___ Python-Dev mailing list [email protected] https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Improve test coverage for standard library
Good day, I've noticed that test coverage of standard library tools can be improved and wanted to ask which module is better to start with? I'm kindly asking to point to the module which would be good to start writing tests for and also easy to review for other contributors. Best regards, Artem Muterko ___ Python-Dev mailing list [email protected] https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Improve test coverage for standard library
In general the answer to helping with code coverage is "whatever module motivates you to help". :) So unless a core dev has a specific module that they want to help you write tests for then it's whatever you want to work on. And for easy reference, the code coverage report can be found at https://codecov.io/gh/python/cpython (although it is somewhat inaccurate for any module imported at startup). On Mon, 10 Jul 2017 at 07:54 Artem Muterko wrote: > Good day, > > I've noticed that test coverage of standard library tools can be improved > and wanted to ask which module is better to start with? > > I'm kindly asking to point to the module which would be good to start > writing tests for and also easy to review for other contributors. > > Best regards, > Artem Muterko > ___ > Python-Dev mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/brett%40python.org > ___ Python-Dev mailing list [email protected] https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
