Re: python-ldap-2.3.12: Compile error on CentOS 5.5, i386

2010-08-11 Thread Michael Ströder
Zhang Huangbin wrote:
> 
> On Aug 9, 2010, at 11:43 PM, Michael Ströder wrote:
> 
>> Find a new release of python-ldap:
>>
>>  http://pypi.python.org/pypi/python-ldap/2.3.12
> 
> Compile error on CentOS 5.5, i386:
> [..]
> Modules/constants.c: In function ‘LDAPinit_constants’:
> Modules/constants.c:184: error: ‘LDAP_OPT_X_TLS_CRLFILE’ undeclared (first 
> use in this function)
> Modules/constants.c:184: error: (Each undeclared identifier is reported only 
> once
> Modules/constants.c:184: error: for each function it appears in.)
> error: Setup script exited with error: command 'gcc' failed with exit status 1

Looks like an older OpenLDAP release. Please try the patch below.

Ciao, Michael.

Index: Modules/constants.c
===
RCS file: /cvsroot/python-ldap/python-ldap/Modules/constants.c,v
retrieving revision 1.47
diff -u -r1.47 constants.c
--- Modules/constants.c 7 May 2010 13:22:40 -   1.47
+++ Modules/constants.c 11 Aug 2010 05:14:47 -
@@ -181,7 +181,9 @@
 #ifdef LDAP_OPT_X_TLS_CRLCHECK
   /* only available if OpenSSL supports it => might cause backward
compability problems */
add_int(d,OPT_X_TLS_CRLCHECK);
+#ifdef LDAP_OPT_X_TLS_CRLFILE
add_int(d,OPT_X_TLS_CRLFILE);
+#endif
add_int(d,OPT_X_TLS_CRL_NONE);
add_int(d,OPT_X_TLS_CRL_PEER);
add_int(d,OPT_X_TLS_CRL_ALL);

--
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
___
Python-LDAP-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/python-ldap-dev


Re: python-ldap-2.3.12: Compile error on CentOS 5.5, i386

2010-08-11 Thread Zhang Huangbin

On Aug 12, 2010, at 2:42 AM, Michael Ströder wrote:
> 
> Looks like an older OpenLDAP release. Please try the patch below.
> 
> Ciao, Michael.
> 
> Index: Modules/constants.c
> ===
> RCS file: /cvsroot/python-ldap/python-ldap/Modules/constants.c,v
> retrieving revision 1.47
> diff -u -r1.47 constants.c
> --- Modules/constants.c   7 May 2010 13:22:40 -   1.47
> +++ Modules/constants.c   11 Aug 2010 05:14:47 -
> @@ -181,7 +181,9 @@
> #ifdef LDAP_OPT_X_TLS_CRLCHECK
>   /* only available if OpenSSL supports it => might cause backward
> compability problems */
>   add_int(d,OPT_X_TLS_CRLCHECK);
> +#ifdef LDAP_OPT_X_TLS_CRLFILE
>   add_int(d,OPT_X_TLS_CRLFILE);
> +#endif
>   add_int(d,OPT_X_TLS_CRL_NONE);
>   add_int(d,OPT_X_TLS_CRL_PEER);
>   add_int(d,OPT_X_TLS_CRL_ALL);


This patch fixes it.
Will you release a 2.3.12.1 version for this fix?



--
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
___
Python-LDAP-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/python-ldap-dev