Re: Tkinter menu item underline syntax [RESOLVED]
On Wed, 6 Jan 2021, Terry Reedy wrote: 'underline' has nothing to do with looking up the command in self.callbacks. It is a keyword parameter for the add_command method, and is handled like all other values passed by name, and as you did for the other arguments file_menu.add_command( label='New', underline=0, command=self.callbacks['file->new], accelerator='Ctrl+N' ) Note: PEP 8 style is no spaces around '=' used for keyword arguments. Here is an example from idlelib.editor, 978. menu.add_command(label=ulchars[i] + " " + file_name, command=callback, underline=0) Thank you for the clarification. Rich -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 1/6/2021 4:17 PM, Terry Reedy wrote: On 1/6/2021 4:03 PM, Rich Shepard wrote: On Thu, 7 Jan 2021, Chris Angelico wrote: Are you sure that this works? It's syntactically valid, but I don't think it means what you think it does. ChrisA, I'm always open to learning. There's no error generated ... yet the application doesn' open so it's time to run it through pdb. See my response, sent an hour ago, for how to use 'underline. Reposting: 'underline' has nothing to do with looking up the command in self.callbacks. It is a keyword parameter for the add_command method, and is handled like all other values passed by name, and as you did for the other arguments file_menu.add_command( label='New', underline=0, command=self.callbacks['file->new], accelerator='Ctrl+N' ) Note: PEP 8 style is no spaces around '=' used for keyword arguments. Here is an example from idlelib.editor, 978. menu.add_command(label=ulchars[i] + " " + file_name, command=callback, underline=0) -- Terry Jan Reedy -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, 7 Jan 2021, Peter Otten wrote: Spoiler: unless the name 'underline' is defined you get a NameError: NameError: name 'underline' is not defined If it is defined and self.callbacks is a dict you get a TypeError: TypeError: unhashable type: 'slice' because that's what a colon means in a context like x[a:b] The template I used for the menu doesn't scale to my application so I'm re-writing it from scratch. Thanks, all, Rich -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 06/01/2021 22:03, Grant Edwards wrote:
I'm completely baffled by that. Can somebody explain how this
expression is evaluated?
self.callbacks['file->new', underline: 0]
It appears that the dict callbacks is being accessed with the key of
a tuple comprising a string and a slice.
Huh?
You're completely right:
>>> class C:
def __getitem__(self, index): return index
>>> c = C()
>>> underline = 42
>>> c["foo", underline: 0]
('foo', slice(42, 0, None))
The OP's code will most certainly fail at runtime ;)
--
https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 06/01/2021 22:03, Rich Shepard wrote: On Thu, 7 Jan 2021, Chris Angelico wrote: Are you sure that this works? It's syntactically valid, but I don't think it means what you think it does. ChrisA, I'm always open to learning. There's no error generated ... yet the application doesn' open so it's time to run it through pdb. Spoiler: unless the name 'underline' is defined you get a NameError: NameError: name 'underline' is not defined If it is defined and self.callbacks is a dict you get a TypeError: TypeError: unhashable type: 'slice' because that's what a colon means in a context like x[a:b] From what you posted I would guess that underline is most likely a keyword argument to the add_command() method: file_menu.add_command( label='New', command=self.callbacks['file->new'], underline=0, accelerator='Ctrl+N' ) -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, Jan 7, 2021 at 9:22 AM Grant Edwards wrote: > > On 2021-01-06, Rich Shepard wrote: > > On Wed, 6 Jan 2021, 2qdxy4rzwzuui...@potatochowder.com wrote: > > > >> For the sake of future generations who may run into this issue, can you > >> post the complete, correct call to file_menu.add_command? > > > > This is the working version of the stanza I initially posted: > > > > file_menu.add_command( > > label = 'New', > > command = self.callbacks['file->new', underline: 0], > > accelerator = 'Ctrl+N' > > ) > > I'm completely baffled by that. Can somebody explain how this > expression is evaluated? > >self.callbacks['file->new', underline: 0] > > It appears that the dict callbacks is being accessed with the key of > a tuple comprising a string and a slice. > Heh, you had to try it to make sure it was valid? Me too. Here's how it's parsed: self.callbacks[ # this bit's non-controversial 'file->new' # string literal , # make tuple underline: 0 # slice(underline, 0, None) ] So it takes the name "underline", whatever that is, and it assumes you want a slice from underline to zero. That's all the second dimension of the indexing, where the first is a simple string literal. ChrisA -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 1/6/2021 4:03 PM, Rich Shepard wrote: On Thu, 7 Jan 2021, Chris Angelico wrote: Are you sure that this works? It's syntactically valid, but I don't think it means what you think it does. ChrisA, I'm always open to learning. There's no error generated ... yet the application doesn' open so it's time to run it through pdb. See my response, sent an hour ago, for how to use 'underline. -- Terry Jan Reedy -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 2021-01-06, Rich Shepard wrote: > On Wed, 6 Jan 2021, 2qdxy4rzwzuui...@potatochowder.com wrote: > >> For the sake of future generations who may run into this issue, can you >> post the complete, correct call to file_menu.add_command? > > This is the working version of the stanza I initially posted: > > file_menu.add_command( > label = 'New', > command = self.callbacks['file->new', underline: 0], > accelerator = 'Ctrl+N' > ) I'm completely baffled by that. Can somebody explain how this expression is evaluated? self.callbacks['file->new', underline: 0] It appears that the dict callbacks is being accessed with the key of a tuple comprising a string and a slice. Huh? -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, 7 Jan 2021, Chris Angelico wrote: Cool. Terry had something on the subject in the other thread; I think that's a good place to start. (I don't know much about Tkinter, this line of code just looked odd in general Python syntax.) ChrisA, It's been a long time since I wrote any Python code. Assignments have spaces surrounding equal signs while values to options don't. I think I have the code cleaned now. Regards, Rich -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, Jan 7, 2021 at 8:04 AM Rich Shepard wrote: > > On Thu, 7 Jan 2021, Chris Angelico wrote: > > > Are you sure that this works? It's syntactically valid, but I don't > > think it means what you think it does. > > ChrisA, > > I'm always open to learning. There's no error generated ... yet the > application doesn' open so it's time to run it through pdb. > Cool. Terry had something on the subject in the other thread; I think that's a good place to start. (I don't know much about Tkinter, this line of code just looked odd in general Python syntax.) ChrisA -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, 7 Jan 2021, Chris Angelico wrote: Are you sure that this works? It's syntactically valid, but I don't think it means what you think it does. ChrisA, I'm always open to learning. There's no error generated ... yet the application doesn' open so it's time to run it through pdb. Regards, Rich -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Thu, Jan 7, 2021 at 7:43 AM Rich Shepard wrote: > This is the working version of the stanza I initially posted: > > file_menu.add_command( > label = 'New', > command = self.callbacks['file->new', underline: 0], > accelerator = 'Ctrl+N' > ) > > The label line separated from the command with a comma. The underline option > is a key and separated from its value with a colon. > Are you sure that this works? It's syntactically valid, but I don't think it means what you think it does. ChrisA -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Wed, 6 Jan 2021, 2qdxy4rzwzuui...@potatochowder.com wrote: For the sake of future generations who may run into this issue, can you post the complete, correct call to file_menu.add_command? This is the working version of the stanza I initially posted: file_menu.add_command( label = 'New', command = self.callbacks['file->new', underline: 0], accelerator = 'Ctrl+N' ) The label line separated from the command with a comma. The underline option is a key and separated from its value with a colon. HTH, Rich -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On 2021-01-06 at 11:18:15 -0800, Rich Shepard wrote: > On Wed, 6 Jan 2021, 2qdxy4rzwzuui...@potatochowder.com wrote: > > > I'm not a TKinter expert (nor even a current user), but that line that > > begins with whitespace and "command =" looks suspicious. As far as I can > > see, Python is correct to call it syntactically erroneous. > > Yes, the line above it needed to be terminated by a comma, not \n. > > I found the answer: underline is an option and options are key: value pairs. > So, the correct syntax is underline: 0. Glad you found it. :-) For the sake of future generations who may run into this issue, can you post the complete, correct call to file_menu.add_command? -- https://mail.python.org/mailman/listinfo/python-list
Re: Tkinter menu item underline syntax [RESOLVED]
On Wed, 6 Jan 2021, 2qdxy4rzwzuui...@potatochowder.com wrote: I'm not a TKinter expert (nor even a current user), but that line that begins with whitespace and "command =" looks suspicious. As far as I can see, Python is correct to call it syntactically erroneous. Yes, the line above it needed to be terminated by a comma, not \n. I found the answer: underline is an option and options are key: value pairs. So, the correct syntax is underline: 0. Thanks, Rich -- https://mail.python.org/mailman/listinfo/python-list
