[Python-modules-team] Bug#740159: Add missing cpp dependency

[Stefano Rivera]

Hi Martin (2014.02.26_15:04:10_+0200)
 | RuntimeError: Unable to invoke 'cpp'.  Make sure its path was passed 
 correctly
 | Original error: [Errno 2] No such file or directory

Ah yes, I test with build chroots, which have cpp installed.

 Simple fix attached which adds the missing cpp binary dependency.

In this case, cpp probably shouldn't be a binary dependency, it's only used in
non-default code paths (and tests).

I imagine the biggest user of pycparser is cffi, and it doesn't require
cpp. (Well, it requires gcc at build time, but that's another story)

So, I think I'll add a Suggests, and a ADT dependency.

SR

-- 
Stefano Rivera
  http://tumbleweed.org.za/
  H: +27 21 461 1230 C: +27 72 419 8559

___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#740159: Add missing cpp dependency

[Martin Pitt]

Package: python-pycparser
Version: 2.10+dfsg-1
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch trusty

Hello,

pycparser's autopkgtest currently fails [1]:

| Traceback (most recent call last):
|   File 
/tmp/adt-run.KJzNVw/tree0t-unittests-testtmp/adttmp/tests/test_general.py, 
line 55, in test_no_real_content_after_cpp
| cpp_path=CPPPATH)
|   File /usr/lib/python2.7/dist-packages/pycparser/__init__.py, line 86, in 
parse_file
| text = preprocess_file(filename, cpp_path, cpp_args)
|   File /usr/lib/python2.7/dist-packages/pycparser/__init__.py, line 49, in 
preprocess_file
| ('Original error: %s' % e))
| RuntimeError: Unable to invoke 'cpp'.  Make sure its path was passed correctly
| Original error: [Errno 2] No such file or directory

Simple fix attached which adds the missing cpp binary dependency. I tested that
it now succeeds in an LXC container. Yay tests :-)

Thanks for considering,

Martin

[1] http://ci.debian.net/#package/pycparser
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
diff -Nru pycparser-2.10+dfsg/debian/changelog 
pycparser-2.10+dfsg/debian/changelog
--- pycparser-2.10+dfsg/debian/changelog2014-02-12 17:34:13.0 
+0100
+++ pycparser-2.10+dfsg/debian/changelog2014-02-26 14:01:16.0 
+0100
@@ -1,3 +1,9 @@
+pycparser (2.10+dfsg-1ubuntu2) trusty; urgency=medium
+
+  * Add missing cpp dependency, spotted by autopkgtest.
+
+ -- Martin Pitt martin.p...@ubuntu.com  Wed, 26 Feb 2014 14:01:07 +0100
+
 pycparser (2.10+dfsg-1ubuntu1) trusty; urgency=medium
 
   * Fix build failure with /usr/share/pyshared removed.
diff -Nru pycparser-2.10+dfsg/debian/control pycparser-2.10+dfsg/debian/control
--- pycparser-2.10+dfsg/debian/control  2013-08-08 11:54:43.0 +0200
+++ pycparser-2.10+dfsg/debian/control  2014-02-26 13:56:13.0 +0100
@@ -20,7 +20,7 @@
 
 Package: python-pycparser
 Architecture: all
-Depends: ${misc:Depends}, ${python-ply:Depends}, ${python:Depends}
+Depends: ${misc:Depends}, ${python-ply:Depends}, ${python:Depends}, cpp
 Description: C parser in Python
  pycparser is a complete parser of the C language, written in pure Python using
  the PLY parsing library. It parses C code into an AST and can serve as a
@@ -28,7 +28,7 @@
 
 Package: python3-pycparser
 Architecture: all
-Depends: ${misc:Depends}, ${python3-ply:Depends}, ${python3:Depends}
+Depends: ${misc:Depends}, ${python3-ply:Depends}, ${python3:Depends}, cpp
 Description: C parser in Python 3
  pycparser is a complete parser of the C language, written in pure Python using
  the PLY parsing library. It parses C code into an AST and can serve as a


signature.asc
Description: Digital signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team