Re: [python-win32] adodbapi changing autocommit

2016-10-24 Thread Vernon D. Cole
Wait a bit...  Did I just hear that there is a difference in operation
between starting a connection with autocommit=false and turning autocommit
off during a session?  If so, I think that's a bug.  PEP-249 has no hook
for explicitly starting a transaction, so adodbapi needs to always have
done BeginTrans before any meaningful operation.  Am I missing something?
--
Vernon Cole


On Mon, Oct 24, 2016 at 11:10 AM, Tim Roberts  wrote:

> Max Slimmer wrote:
> > The adodbapi documentation and code implies that with autocommit =
> > False I should only have to call commit (and possibly rollback) and if
> > using the connection as a context manager not even those are required.
> > If autocommit = False is passed on the initial connect the __init__ of
> > the connector handles BeginTrans and subsequent commit and rollbacks
> > also leave me with an open trans.
>
> Ah, I missed that subtle distinction.  Your modification seems reasonable.
>
> --
> Tim Roberts, t...@probo.com
> Providenza & Boekelheide, Inc.
>
> ___
> python-win32 mailing list
> python-win32@python.org
> https://mail.python.org/mailman/listinfo/python-win32
>
___
python-win32 mailing list
python-win32@python.org
https://mail.python.org/mailman/listinfo/python-win32


Re: [python-win32] adodbapi changing autocommit

2016-10-24 Thread Tim Roberts
Max Slimmer wrote:
> The adodbapi documentation and code implies that with autocommit =
> False I should only have to call commit (and possibly rollback) and if
> using the connection as a context manager not even those are required.
> If autocommit = False is passed on the initial connect the __init__ of
> the connector handles BeginTrans and subsequent commit and rollbacks
> also leave me with an open trans.

Ah, I missed that subtle distinction.  Your modification seems reasonable.

-- 
Tim Roberts, t...@probo.com
Providenza & Boekelheide, Inc.

___
python-win32 mailing list
python-win32@python.org
https://mail.python.org/mailman/listinfo/python-win32