[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T104864: [breaking change] Page.namespace() gives inconsistent result

2016-03-26 Thread Xqt 
Xqt added a subscriber: Mpaa.
Xqt merged a task: T131007: Page.namespace() does not return a Namespace() for 
pages in Main ns.

TASK DETAIL
  https://phabricator.wikimedia.org/T104864

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb, Xqt
Cc: Mpaa, Sn1per, gerritbot, XZise, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, 
Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Merged] T131007: Page.namespace() does not return a Namespace() for pages in Main ns

2016-03-26 Thread Xqt 
Xqt closed this task as a duplicate of T104864: [breaking change] 
Page.namespace() gives inconsistent result.

TASK DETAIL
  https://phabricator.wikimedia.org/T131007

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: pywikibot-bugs-list, Aklapper, Mpaa, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T129763: beta wikipedia test builds fail

2016-03-26 Thread jayvdb 
jayvdb added a comment.


  The error "'Non-JSON response received from server wpbeta:en'" occurs in the 
logs
  
  - Sept 23, 2015 with build `#2892` 
`.10` in the 
`site_tests:testSearch` until `#2902` 
`.10` (Sept 
24,2015).  Very specific failure - almost certainly unrelated.
  - `#3074` 
`.12` (Nov 11, 
2015) with complete failure - a very similar build log to the common problems, 
but possibly a completely different cause.
  - All `x.12` builds from `#3097` 
`.12` (December 
11, 2015) onwards - probably all the current problems.
  
  (job `x.10` became `x.12` because two Python 3.5 jobs were added above these 
OAuth jobs in the build matrix.)

TASK DETAIL
  https://phabricator.wikimedia.org/T129763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: Dalba, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T130611: 500 status responses and fatal errors for OAuth authenticated API requests on beta servers

2016-03-26 Thread Tgr 
Tgr added a comment.


  In https://phabricator.wikimedia.org/T130611#2153076, @jayvdb wrote:
  
  > Is this the cause of T129763: beta wikipedia test builds fail 
 ?
  
  
  Yes. The 'lots of 503 errors' thing is the original bug this task was 
intended to fix (`WARNING: Http response status 503 WARNING: Non-JSON response 
received from server wpbeta:en; the server may be down` - a fatal error in the 
OAuth JSON response, example 
); the signature 
errors (`WARNING: API error mwoauth-invalid-authorization: The authorization 
headers in your request are not valid: Invalid signature` - example 
) are caused by 
the secret key change.

TASK DETAIL
  https://phabricator.wikimedia.org/T130611

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: pywikibot-bugs-list, Krenair, Anomie, jayvdb, Tgr, Aklapper, Susannaanas, 
Chippyy, Jay8g



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T131007: Page.namespace() does not return a Namespace() for pages in Main ns

2016-03-26 Thread Peachey88 
Peachey88 removed a subscriber: pywikibot-core.
Peachey88 added a project: pywikibot-core.
Herald added a subscriber: pywikibot-bugs-list.

TASK DETAIL
  https://phabricator.wikimedia.org/T131007

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peachey88
Cc: pywikibot-bugs-list, Aklapper, Mpaa, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T130572: Pywikibot diff highlights entire line when only text is removed

2016-03-26 Thread jayvdb 
jayvdb added a comment.


  Hmm, PS4 indents one of the replaced lines, and marks all of both lines as 
red & green.
  
$ python pwb.py replace -family:test -lang:test 
-page:"User:John_Vandenberg/diff_test" Pywikipediabot Pywiki -user:JVbot-test
>>> User:John Vandenberg/diff test <<<
@@ -1,2 +1,2 @@
- Pywikipediabot foo
- Pywikipediabot
+ Pywiki foo
   + Pywiki

TASK DETAIL
  https://phabricator.wikimedia.org/T130572

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Mpaa, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Mpaa 
Mpaa added a comment.


  I do not think this task is about banning, it is more about meaning of 
@expectedFailure.
  
  In my view, @expectedFailure should not be used to check for a deliberate 
failure.
  To test that in a given condition, a function is correctly raising an 
exception, the test should be written accordingly and pass.
  @expectedFailure should be used when known bugs are present or similar (e.g. 
# TODO), in order to temporarily force the test case to pass and not to have 
the whole build marked as failed.
  And when the issue is solved, it is probably better to remove it.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread jayvdb 
jayvdb added a comment.


  I would be very interesting to see any other project that has banned use of 
`@expectedFailure`.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread jayvdb 
jayvdb added a comment.


  On https://gerrit.wikimedia.org/r/#/c/278456/@xqt said
  
  > expectedFailure does not what is sounds. It also passes for unexpected 
failures and you cannot decide wether
  >  the failure is expected or due to an unknown reason and the test is 
finally worthless.
  
  `@expectedFailure` should only be used if the failure is 100% expected, and 
typically the failure is expected on the last line, and the test method is 
written so that other tests will fail if some earlier part of the test sequence 
has a problem.  The test will become an "unexpected success" if the test passes.
  
  (And we can configure "unexpected success" to be a treated as an error, but 
that only helps if someone is regularly looking for & fixing build breakages.)
  
  > Every test should be expressed in a form that it may fail in expected 
manner e.g. checking for wrong 
  >  results or for raised exceptions etc.
  
  If the test is written so that it is the last line that fails (see above) the 
following are functionally equivalent
  
@expectedFailure
def test_foo(self):
 1 / 0

def test_foo2(self):
 with self.assertRaises(Exception):
 1 / 0
  
  Except that the former has more semantic information, and code checkers 
explicitly fail `self.assertRaises(Exception)` as being too broad.
  
  Of course we can work around that by using 
`self.assertRaises(ZeroDivisionError):` , but that means our tests are then 
explicitly linked to the underlying implementation of why it fails, which often 
isnt desirable because we dont have any control over that.  expectedFailure is 
used to prove something doesnt work, irrespective of why, and often it exists 
to help explain a `# TODO` item by showing what 'should' work.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Xqt 
Xqt edited the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Xqt 
Xqt removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Mpaa 
Mpaa added a comment.


  In https://phabricator.wikimedia.org/T129368#2136801, @gerritbot wrote:
  
  > Change 278456 had a related patch set uploaded (by Mpaa):
  >  Solve usage of expectedFailure for tools_tests.py
  >
  > https://gerrit.wikimedia.org/r/278456
  
  
  This is now tracked in https://phabricator.wikimedia.org/T130985

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, 
Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T130985: Solve usage of expectedFailure for tools_tests.py

2016-03-26 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T130985

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, gerritbot
Cc: gerritbot, Aklapper, pywikibot-bugs-list, Mpaa, Lewizho99, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T130985: Solve usage of expectedFailure for tools_tests.py

2016-03-26 Thread gerritbot 
gerritbot added a comment.


  Change 278456 had a related patch set uploaded (by Mpaa):
  Solve usage of expectedFailure for tools_tests.py
  
  https://gerrit.wikimedia.org/r/278456

TASK DETAIL
  https://phabricator.wikimedia.org/T130985

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, gerritbot
Cc: gerritbot, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Mpaa 
Mpaa added a blocking task: T130985: Solve usage of expectedFailure for 
tools_tests.py.

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T130985: Solve usage of expectedFailure for tools_tests.py

2016-03-26 Thread Mpaa 
Mpaa added a blocked task: T129368: Usages of unittest.expectedFailure should 
be solved.

TASK DETAIL
  https://phabricator.wikimedia.org/T130985

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Aklapper, pywikibot-bugs-list, Mpaa, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T130985: Solve usage of expectedFailure for tools_tests.py

2016-03-26 Thread Mpaa 
Mpaa created this task.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  Solve usage of expectedFailure for tools_tests.py

TASK DETAIL
  https://phabricator.wikimedia.org/T130985

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Aklapper, pywikibot-bugs-list, Mpaa, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T130908: Use of djvutext.py is throwing an error

2016-03-26 Thread Mpaa 
Mpaa closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T130908

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: gerritbot, Mpaa, Aklapper, pywikibot-bugs-list, Billinghurst, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T130921: Enable page_tests.TestPageProtect.test_protect

2016-03-26 Thread Xqt 
Xqt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T130921

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: gerritbot, Aklapper, pywikibot-bugs-list, Xqt, Lewizho99, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unblock] T129368: Usages of unittest.expectedFailure should be solved

2016-03-26 Thread Xqt 
Xqt closed blocking task T130921: Enable 
page_tests.TestPageProtect.test_protect as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T129368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T106954: watchlist.py should handle invalid titles

2016-03-26 Thread Xqt 
Xqt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T106954

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: gerritbot, XZise, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unblock] T126930: Handle InvalidTitle Error in preloading pages

2016-03-26 Thread Xqt 
Xqt closed blocking task T106954: watchlist.py should handle invalid titles as 
"Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T126930

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: gerritbot, Aklapper, pywikibot-bugs-list, Xqt, Lewizho99, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs