[Pywikipedia-bugs] [Maniphest] [Edited] T189965: test_query_modules is failing

2018-03-17 Thread Dalba
Dalba updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Note: `test_query_modules` is recorded using `vcrpy`. (T184081)TASK DETAILhttps://phabricator.wikimedia.org/T189965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Edited] T189965: test_query_modules is failing

2018-03-17 Thread Dalba
Dalba updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```
Note: `test_query_modules` is recorded using `vcrpy`.TASK DETAILhttps://phabricator.wikimedia.org/T189965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T189965: test_query_modules is failing

2018-03-17 Thread Dalba
Dalba triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T189965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Created] T189965: test_query_modules is failing

2018-03-17 Thread Dalba
Dalba created this task.Dalba added projects: Pywikibot-tests, Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONhttps://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/build/job/yvvrjqu82idl5ycm#L4792

==
ERROR: test_query_modules (tests.api_tests.TestParaminfoModules)
Test loading all query modules.
--
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 1950, in submit
body=body, headers=headers)
  File "c:\projects\pywikibot-g4xqx\pywikibot\tools\__init__.py", line 1520, in wrapper
return obj(*__args, **__kw)
  File "c:\projects\pywikibot-g4xqx\pywikibot\comms\http.py", line 321, in request
r = fetch(baseuri, method, params, body, headers, **kwargs)
  File "c:\projects\pywikibot-g4xqx\pywikibot\comms\http.py", line 521, in fetch
error_handling_callback(request)
  File "c:\projects\pywikibot-g4xqx\pywikibot\comms\http.py", line 408, in error_handling_callback
raise request.data
  File "c:\projects\pywikibot-g4xqx\pywikibot\comms\http.py", line 387, in _http_process
**http_request.kwargs)
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\requests\sessions.py", line 508, in request
resp = self.send(prep, **send_kwargs)
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\requests\sessions.py", line 618, in send
r = adapter.send(request, **kwargs)
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\requests\adapters.py", line 440, in send
timeout=timeout
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\urllib3\connectionpool.py", line 601, in urlopen
chunked=chunked)
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\urllib3\connectionpool.py", line 380, in _make_request
httplib_response = conn.getresponse(buffering=True)
  File "c:\projects\pywikibot-g4xqx\env\lib\site-packages\vcr\stubs\__init__.py", line 232, in getresponse
self.cassette.record_mode)
vcr.errors.CannotOverwriteExistingCassetteException: No match for the request () was found. Can't overwrite existing cassette ('c:\\projects\\pywikibot-g4xqx\\tests\\cassettes\\wikipedia.en/TestParaminfoModules.test_query_modules.yaml') in your current record mode ('once').
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\tests\api_tests.py", line 491, in test_query_modules
self.site._paraminfo.fetch(self.site._paraminfo.query_modules)
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 570, in fetch
self._fetch(modules)
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 646, in _fetch
result = request.submit()
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 2349, in submit
self._data = super(CachedRequest, self).submit()
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 1974, in submit
self.wait()
  File "c:\projects\pywikibot-g4xqx\pywikibot\data\api.py", line 2203, in wait
raise TimeoutError("Maximum retries attempted without success.")
pywikibot.exceptions.TimeoutError: Maximum retries attempted without success.
--

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/build/job/1vhh32esd7f2i38m#L5457

==
ERROR: test_query_modules (tests.api_tests.TestParaminfoModules)
Test loading all query modules.
--
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\tests\api_tests.py", line 491, in test_query_modules

[Pywikipedia-bugs] [Maniphest] [Commented On] T188843: Category_redirect.py: PageGenerator: 'query' not found in api response.

2018-03-17 Thread Mpaa
Mpaa added a comment.
IMO, add a new function for this and mark filterredir=True as deprecated.TASK DETAILhttps://phabricator.wikimedia.org/T188843EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, MpaaCc: Mpaa, zhuyifei1999, Chicocvenancio, Aklapper, Riley_Huntley, pywikibot-bugs-list, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Closed] T130625: param/type of the class constructor aren't shown in the documentation

2018-03-17 Thread Xqt
Xqt closed this task as "Resolved".Xqt claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T130625EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, gerritbot, Tokenzero, Aklapper, pywikibot-bugs-list, valhallasw, jayvdb, Xqt, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, TomT0m, Dvorapa, Avicennasis, Wong128hk, Luke081515, Dinoguy1000, Dalba, fbstj, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T130625: param/type of the class constructor aren't shown in the documentation

2018-03-17 Thread gerritbot
gerritbot added a comment.
Change 420168 merged by jenkins-bot:
[pywikibot/core@master] [doc] connect 'autodoc-skip-member' hook

https://gerrit.wikimedia.org/r/420168TASK DETAILhttps://phabricator.wikimedia.org/T130625EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Zoranzoki21, gerritbot, Tokenzero, Aklapper, pywikibot-bugs-list, valhallasw, jayvdb, Xqt, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, TomT0m, Dvorapa, Avicennasis, Wong128hk, Luke081515, Dinoguy1000, Dalba, fbstj, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T106121: RFC removing old code / code cleanup

2018-03-17 Thread Xqt
Xqt added a comment.

In T106121#4045429, @Dalba wrote:
That's a good point. I also would like to add that we might not always agree on what is and what is not a breaking change and how often we should bump the version (another source of arguing). For example I consider changing requests requirement a breaking change...


This was not a breaking change by the bot framework but from EventStreams web service itself. pwb may run with older versions of requests but newer is needed for the sseclient working with the newly EventStreams. Anyway it doesn't care currently.

Creating a new release monthly after tests pass would be a good period I guess. On the other hand bugfixes for highly used framework parts e.g. regressions could be a good reason to do it earlier (https://gerrit.wikimedia.org/r/#/c/420170/ for example would be a candidate for it).

Actually I think we can use a hard-coded timestamp as version. It should not matter if the version differs a few days from the exact release date. Perhaps that could be resolved by changing the way are setup.py works.

I made a proposal for it and still prefer new versioning .TASK DETAILhttps://phabricator.wikimedia.org/T106121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, Dvorapa, gerritbot, zhuyifei1999, JeanFred, MZMcBride, Ladsgroup, Magul, TerraCodes, Legoktm, Luke081515, Jay8g, Dalba, Lokal_Profil, StudiesWorld, Multichill, valhallasw, jayvdb, XZise, Ricordisamoa, Aklapper, Xqt, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, rafidaslam, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, TomT0m, Avicennasis, Wong128hk, fbstj, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T188231: listpages logging fails with UnicodeEncodeError

2018-03-17 Thread Xqt
Xqt added a comment.
@Dalba:

C:\pwb\GIT\core>pwb.py shell
Welcome to the Pywikibot interactive shell!
>>> import sys
>>> sys.stdout.encoding
'utf-8'
>>> sys.stdin.encoding
'utf-8'
>>> import pywikibot
>>> pywikibot.stdout('   6 Sękowo (Nowy Tomyśl)')
   6 Sękowo (Nowy Tomyśl)
--- Logging error ---
Traceback (most recent call last):
  File "C:\Program Files (x86)\Python36-32\lib\logging\__init__.py", line 994, i
n emit
stream.write(msg)
  File "C:\Program Files (x86)\Python36-32\lib\encodings\cp1252.py", line 19, in
 encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u0119' in position
83: character maps to 
Call stack:
  File "C:\pwb\GIT\core\pwb.py", line 264, in 
if not main():
  File "C:\pwb\GIT\core\pwb.py", line 257, in main
run_python_file(filename, [filename] + args, argvu, file_package)
  File "C:\pwb\GIT\core\pwb.py", line 120, in run_python_file
main_mod.__dict__)
  File ".\scripts\shell.py", line 37, in 
main(*args)
  File ".\scripts\shell.py", line 28, in main
code.interact("""Welcome to the Pywikibot interactive shell!""", local=env)
  File "C:\Program Files (x86)\Python36-32\lib\code.py", line 302, in interact
console.interact(banner, exitmsg)
  File "C:\Program Files (x86)\Python36-32\lib\code.py", line 233, in interact
more = self.push(line)
  File "C:\Program Files (x86)\Python36-32\lib\code.py", line 259, in push
more = self.runsource(source, self.filename)
  File "C:\Program Files (x86)\Python36-32\lib\code.py", line 75, in runsource
self.runcode(code)
  File "C:\Program Files (x86)\Python36-32\lib\code.py", line 91, in runcode
exec(code, self.locals)
  File "", line 1, in 
  File "C:\pwb\GIT\core\pywikibot\logging.py", line 148, in stdout
logoutput(text, decoder, newline, STDOUT, **kwargs)
  File "C:\pwb\GIT\core\pywikibot\logging.py", line 109, in logoutput
logger.log(_level, text, extra=context, **kwargs)
Message: '   6 Sękowo (Nowy Tomyśl)'
Arguments: ()
>>> sys.version
'3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]'
>>>TASK DETAILhttps://phabricator.wikimedia.org/T188231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, Dalba, Aklapper, pywikibot-bugs-list, valhallasw, Xqt, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T189635: Pywikibot-category works only on the first page of a generator

2018-03-17 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T189635EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Dalba, zhuyifei1999, Aklapper, Ff300, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Chicocvenancio, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Wong128hk, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Claimed] T189635: Pywikibot-category works only on the first page of a generator

2018-03-17 Thread Xqt
Xqt claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T189635EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dalba, zhuyifei1999, Aklapper, Ff300, pywikibot-bugs-list, Chicocvenancio, Jrbranaa, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Wong128hk, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T159651: Iterating Wikidata can be inefficient because APISite.data_repository() isn't cached

2018-03-17 Thread gerritbot
gerritbot added a comment.
Change 420164 merged by jenkins-bot:
[pywikibot/core@master] Cache APISite.data_repository() using CachedRequest

https://gerrit.wikimedia.org/r/420164TASK DETAILhttps://phabricator.wikimedia.org/T159651EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, Mpaa, Aklapper, matej_suchanek, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Vali.matei, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Volker_E, GWicke, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T159651: Iterating Wikidata can be inefficient because APISite.data_repository() isn't cached

2018-03-17 Thread Xqt
Xqt triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T159651EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, XqtCc: gerritbot, Mpaa, Aklapper, matej_suchanek, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Vali.matei, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Volker_E, GWicke, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T130625: param/type of the class constructor aren't shown in the documentation

2018-03-17 Thread gerritbot
gerritbot added a comment.
Change 420168 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [doc] connect 'autodoc-skip-member' hook

https://gerrit.wikimedia.org/r/420168TASK DETAILhttps://phabricator.wikimedia.org/T130625EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Zoranzoki21, gerritbot, Tokenzero, Aklapper, pywikibot-bugs-list, valhallasw, jayvdb, Xqt, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, TomT0m, Dvorapa, Avicennasis, Wong128hk, Luke081515, Dinoguy1000, Dalba, fbstj, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T189635: Pywikibot-category works only on the first page of a generator

2018-03-17 Thread matej_suchanek
matej_suchanek added a project: Regression.
TASK DETAILhttps://phabricator.wikimedia.org/T189635EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Dalba, zhuyifei1999, Aklapper, Ff300, pywikibot-bugs-list, Chicocvenancio, Jrbranaa, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, Wong128hk, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Claimed] T159651: Iterating Wikidata can be inefficient because APISite.data_repository() isn't cached

2018-03-17 Thread matej_suchanek
matej_suchanek claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T159651EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: gerritbot, Mpaa, Aklapper, matej_suchanek, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Vali.matei, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Volker_E, GWicke, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T159651: Iterating Wikidata can be inefficient because APISite.data_repository() isn't cached

2018-03-17 Thread gerritbot
gerritbot added a comment.
Change 420164 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[pywikibot/core@master] Cache APISite.data_repository() using CachedRequest

https://gerrit.wikimedia.org/r/420164TASK DETAILhttps://phabricator.wikimedia.org/T159651EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mpaa, Aklapper, matej_suchanek, pywikibot-bugs-list, Darkminds3113, Magul, Tbscho, rafidaslam, MayS, Vali.matei, Mdupont, JJMC89, Avicennasis, Volker_E, GWicke, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T159651: Iterating Wikidata can be inefficient because APISite.data_repository() isn't cached

2018-03-17 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T159651EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mpaa, Aklapper, matej_suchanek, pywikibot-bugs-list, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Vali.matei, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Volker_E, GWicke, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T130625: param/type of the class constructor aren't shown in the documentation

2018-03-17 Thread Xqt
Xqt added a comment.
Showing derived class attributes like __module__ or __weakref__ might be ok after this patch but showinf the __dict__ if the class derive from object directly Looks strange maybe because it is not formated enough.TASK DETAILhttps://phabricator.wikimedia.org/T130625EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, gerritbot, Tokenzero, Aklapper, pywikibot-bugs-list, valhallasw, jayvdb, Xqt, Majesticalreaper22, Ahmed123, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Ivana_Isadora, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, TomT0m, Dvorapa, Avicennasis, Wong128hk, Luke081515, Dinoguy1000, Dalba, fbstj, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs