[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Aklapper added a comment. https://codein.withgoogle.com/tasks/5448776681521152/TASK DETAILhttps://phabricator.wikimedia.org/T200399WORKBOARDhttps://phabricator.wikimedia.org/project/board/3408/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Zoranzoki21, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
Aklapper renamed this task from "Remove disambiguation bracket in labels when creating new items for articles" to "Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata".Aklapper updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONE.g. `Georgia (country)` -> `Georgia` Only do it when handling articles (ns0). ---[Wikidata](https://www.wikidata.org/) is a common database used by Wikimedia projects. Pywikibot has a script named `scripts/newitem.py` that creates items in this database for newly created pages. Wikidata is the database behind Wikipedia.However page titles can have brackets in it. This task is to remove these brackets from the name of the newly created items, Pywikibot has a script named `scripts/newitem.py` that creates items in this database for newly created pagesonly if the page is in the principal [namespace](https://www.mediawiki.org/wiki/Help:Namespaces) (that means `ns: 0` as [0 is used for articles](https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces)). However page titles can have brackets in it. This task is to remove these brackets from the name of the newly created items, only if the page is in the principal namespace (ns: 0, that's articles).Example: `Georgia (country)` → `Georgia`TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Zoranzoki21, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T148121: [CGI template easy task] Find and fix syntax errors in translated messages
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Aklapper added a comment. https://codein.withgoogle.com/tasks/4808323892248576/ | https://codein.withgoogle.com/tasks/5866610746195968/TASK DETAILhttps://phabricator.wikimedia.org/T148121WORKBOARDhttps://phabricator.wikimedia.org/project/board/3408/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Ebe123, matej_suchanek, Liuxinyu970226, MtDu, PratyyaGhosh, Xqt, pywikibot-bugs-list, Psychoslave, Nikerabbit, Nemo_bis, jayvdb, Aklapper, Wonnral, Bright1055, Baloch007, Toppole69, Mine0901, harikiran, Jayprakash12345, SacredWKnight, Beeyan, D3r1ck01, Srdjan_m, MuhammadShuaib, LNDDYL, Gryllida, Shizhao, Arrbee, KartikMistry, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T148121: [CGI template easy task] Find and fix syntax errors in translated messages
Aklapper updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* https://translatewiki.net/wiki/Special:Search can be used for [regex](https://en.wikipedia.org/wiki/Regular_expression) search (via [MediaWiki's CirrusSearch extension](https://www.mediawiki.org/wiki/Help:CirrusSearch) and can [filter for MediaWiki messages](https://translatewiki.net/w/i.php?title=Special%3ASearch="" style="padding: 0 2px; color: #33; background: rgba(251, 175, 175, .7);">|filter for MediaWiki messages)TASK DETAILhttps://phabricator.wikimedia.org/T148121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Ebe123, matej_suchanek, Liuxinyu970226, MtDu, PratyyaGhosh, Xqt, pywikibot-bugs-list, Psychoslave, Nikerabbit, Nemo_bis, jayvdb, Aklapper, Wonnral, Bright1055, Baloch007, Toppole69, Mine0901, harikiran, Jayprakash12345, SacredWKnight, Beeyan, D3r1ck01, Srdjan_m, MuhammadShuaib, LNDDYL, Gryllida, Shizhao, Arrbee, KartikMistry, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T148121: [CGI template easy task] Find and fix syntax errors in translated messages
Aklapper updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONhttps://translatewiki.net/ contains source and translated messages for many projects, including MediaWiki and many extensions.
The source messages often contain syntax that must be preserved in the translated message, per https://translatewiki.net/wiki/Localisation_guidelines; [[https://www.mediawiki.org/wiki/Help:Extension:Translate/Components#Message_checkers|checkers]] are designed to prevent mistakes.
Translators occasionally either omit or corrupt the syntax in the translation.
This task is to find and fix one translated message in a Wikimedia repository that has incorrect syntax.
== UI search ==
https://translatewiki.net/wiki/Special:SearchTranslations helps find messages searching either the source or the translation, optionally filtered by language and/or repository.
https://translatewiki.net/wiki/Special:Search can be used for [[https://www.mediawiki.org/wiki/Help:CirrusSearch|regex search]] and can [[https://translatewiki.net/w/i.php?title=Special%3ASearch="" for MediaWiki messages]].
== Manual search ==
To find syntax errors in translated messages, fetch the repository containing the translations.
Then use tools to look for problems. The simplest tools to use are generic text search programs like `grep`, or .
For example, `git clone https://github.com/wikimedia/mediawiki`.
In the [[https://github.com/wikimedia/mediawiki/tree/master/languages/i18n | languages/i18n ]] read the `en.json` (English) and `qqq.json` (Description) files to learn about each message. Look for syntax which might become broken by a translator.
The variable syntax is `$1`, `$2`, etc. Sometimes translators add a space in the middle, like `$ 1`
```
$ git grep '\$ 1'
azb.json: "blockedtext": "' 'ایستیفادهچی آدی و یا آی پی عنوانینیز قاباغی باغلانیب دیر.'\n\nسیزی باغلایان$ 1. الیله اولوب دیر \nباغلاماق سببی:' $ 2.\n\n* باغلانمانین باشلانان زامانی: $ 8\n* باغلانمانین قورتولان زامانی: $ 6\n* باغلانما مدتی: $ 7\n\nگؤستریلن سببه گؤره ائنگئللئنمئنیزین اویغون اولمادیغینی دوشونورسونوزسه، $ 1 یا دا باشقا بیر [[{{MediaWiki:Grouppage-sysop}}|مدیر]] ایله بو وضعیتی گؤروشه بیلرسینیز. [[Special:Preferences|ترجیح لرینیز]] قیسمینده اعتبارلی بیر ائ-پوچت اونوانی گیرمئدیسئنیز \"ایستیفادهچییه ائ-پوچت گؤندر\" خصوصیتینی ایستیفاده ائده، ترجیهلرینیز ایمیل عنوانینیزی علاوه ایمیل گؤندرمک حقوقونا صاحب اولاجاقسینیز.\nبو آنکی باغلانما عنوانینیز $ 3، ائنگئللئنمئ نؤمرهنیز # $ 5.\nبیر ایدارهچیلر وضعیتینیز حاقیندا معلومات آلماق ایستدیگینیزده و یا هر هانسی بیر سورگودا بو معلوماتلار لازیم اولاجاق، خاهیش ائدیریک نوت ائدین.",
azb.json: "autoblockedtext": "\n' 'ایستیفادهچی آدی و یا آی پی عنوانینیز قاباغی باغلانیب دیر.'\n\nسیزی باغلایان$ 1. الیله اولوب دیر \nباغلاماق سببی:' $ 2.\n\n* باغلانمانین باشلانان زامانی: $ 8\n* باغلانمانین قورتولان زامانی: $ 6\n* باغلانما مدتی: $ 7\n\nگؤستریلن سببه گؤره ائنگئللئنمئنیزین اویغون اولمادیغینی دوشونورسونوزسه، $ 1 یا دا باشقا بیر [[{{MediaWiki:Grouppage-sysop}}|مدیر]] ایله بو وضعیتی گؤروشه بیلرسینیز. [[Special:Preferences|ترجیح لرینیز]] قیسمینده اعتبارلی بیر ائ-پوچت اونوانی گیرمئدیسئنیز \"ایستیفادهچییه ائ-پوچت گؤندر\" خصوصیتینی ایستیفاده ائده، ترجیهلرینیز ایمیل عنوانینیزی علاوه ایمیل گؤندرمک حقوقونا صاحب اولاجاقسینیز.\nبو آنکی باغلانما عنوانینیز $ 3، ائنگئللئنمئ نؤمرهنیز # $ 5.\nبیر ایدارهچیلر وضعیتینیز حاقیندا معلومات آلماق ایستدیگینیزده و یا هر هانسی بیر سورگودا بو معلوماتلار لازیم اولاجاق، خاهیش ائدیریک نوت ائدین.",
azb.json: "file-info-png-repeat": "$1 {{PLURAL:$ 1|دفعه| دفعه}} اویناتیلدی",
khw.json: "databaseerror-function": "فنکشن: $ 1",
khw.json: "databaseerror-error": "خرابی: $ 1",
luz.json: "copyright": "مطلب دومن $ 1 هس نکه خلاف هونو ذکر وابی.",
ses.json: "hiddencategories": "Moɲoo woo {{PLURAL:$1|dumi tugante$ 1}} no m'a may:",
sq.json:"databaseerror-query": "\nPyetje: $ 1",
sq.json:"no-null-revision": "I pamundur krijimi rishikimi i ri për faqen bosh \"$ 1\"",
sw.json:"apihelp-no-such-module": "Moduli \"$ 1\" haikupatikana.",
ur.json:"databaseerror-function": "فنکشن: $ 1",
ur.json:"databaseerror-error": "خرابی: $ 1",
```
Another approach is to look for keywords.
For example, the source English message "viewcount" is `"This page has been accessed {{PLURAL:$1|once|$1 times}}."`, which uses the [[ https://www.mediawiki.org/wiki/Help:Magic_words | PLURAL magic word]] which implements [[https://en.wikipedia.org/wiki/Grammatical_number|grammatical number]]. See also [[https://translatewiki.net/wiki/Plural|Plural]] on translatewiki.net.
Using grep we can see all of the translations that have omitted the "PLURAL quickly:
```lang=bash
$ cd languages/i18n
$ grep '"viewcount"' *.json | egrep -v '(qqq.json|PLURAL)'
cv.json: "viewcount": "Ку страницăна $1 хут пăхнă.",
ff.json: "viewcount": "Ngoo hello yillaama laabi $1.",
gan-hans.json: "viewcount": "个页拖人眵嘞$1回。",
gan-hant.json: "viewcount": "箇頁拕人眵哩$1回。",
gn.json: "viewcount": "Esta página ha sido
[Pywikipedia-bugs] [Maniphest] [Unassigned] T148121: [CGI template easy task] Find and fix syntax errors in translated messages
Aklapper removed Nemo_bis as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T148121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Ebe123, matej_suchanek, Liuxinyu970226, MtDu, PratyyaGhosh, Xqt, pywikibot-bugs-list, Psychoslave, Nikerabbit, Nemo_bis, jayvdb, Aklapper, Wonnral, Bright1055, Baloch007, Toppole69, Mine0901, harikiran, Jayprakash12345, SacredWKnight, Beeyan, D3r1ck01, Srdjan_m, MuhammadShuaib, LNDDYL, Gryllida, Shizhao, Arrbee, KartikMistry, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T178061: Reduce (API) warning clutter in login.py after clean installation
Dvorapa added a subtask: T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it. TASK DETAILhttps://phabricator.wikimedia.org/T178061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, Dvorapa, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
Dvorapa added a parent task: T178061: Reduce (API) warning clutter in login.py after clean installation. TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T206385: Pywikibot sets non-executable file's mode to 700
Dvorapa added a parent task: T178061: Reduce (API) warning clutter in login.py after clean installation. TASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urbanecm, DvorapaCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T178061: Reduce (API) warning clutter in login.py after clean installation
Dvorapa added a subtask: T206385: Pywikibot sets non-executable file's mode to 700. TASK DETAILhttps://phabricator.wikimedia.org/T178061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, Dvorapa, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T178061: Reduce (API) warning clutter in login.py after clean installation
Dvorapa renamed this task from "Reduce API warning clutter in login.py after clean installation" to "Reduce (API) warning clutter in login.py after clean installation". TASK DETAILhttps://phabricator.wikimedia.org/T178061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, Dvorapa, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
gerritbot added a comment. Change 464950 had a related patch set uploaded (by Dvorapa; owner: Dvorapa): [pywikibot/core@master] [bugfix] Set pywikibot.lwp mode to 600 immediately upon creation https://gerrit.wikimedia.org/r/464950TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
Dvorapa added a comment. Asked here: https://bugs.python.org/issue34915TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206385: Pywikibot sets non-executable file's mode to 700
gerritbot added a comment. Change 464943 merged by jenkins-bot: [pywikibot/core@master] Change default file mode for private files to 600 https://gerrit.wikimedia.org/r/464943TASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urbanecm, gerritbotCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T206385: Pywikibot sets non-executable file's mode to 700
Framawiki closed this task as "Resolved".Framawiki added a comment. Thanks !TASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urbanecm, FramawikiCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
Dvorapa added a comment. The issue is inside the Python library itself (http.cookiejar): https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/comms/http.py$97 -> https://github.com/python/cpython/blob/3.7/Lib/http/cookiejar.py#L1872. The library nicely creates (saves) file in 644 mode. The library doesn't have any parameter for permissions change, therefore we can a) fill in a Python issue (all versions in 2.x and 3.x are incorrect) or b) create an empty file with correct permissions before.TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
Dvorapa added a comment. The issue is in the following line: https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/login.py$210 The line creates a file with 644, then pywikibot/data/api.py chmod's it to 600. The line should be changed to something like https://stackoverflow.com/questions/5624359/write-file-with-specific-permissions-in-python in order to create file with 600 already.TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T206387: Pywikibot creates pywikibot.lwp with 644 mode by default and permits everyone to read it
Urbanecm created this task.Urbanecm added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.Restricted Application added a project: User-Urbanecm. TASK DESCRIPTIONPywikibot creates pywikibot.lwp with 644 mode by default. Checks that were implemented eariler automatically changes the mode on next run of any script which triggers the run (I believe login is the only one action). This should be changed, so the checks will trigger only if user manually changes the mode (then a warning will be more than appropriate). See this, which was executed right after I freshly clonned PWB and generated user files. testovaci@notebook:~$ python ~/pywikibot/pwb.py login -family:species -lang:species WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/user-password.py had 600 mode; converted to 700 mode. warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode)) Logging in to species:species as UrbanecmBot@BotTest WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/pywikibot.lwp had 664 mode; converted to 600 mode. warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode)) Logged in on species:species as UrbanecmBot.TASK DETAILhttps://phabricator.wikimedia.org/T206387EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrbanecmCc: Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T206385: Pywikibot sets non-executable file's mode to 700
gerritbot added a comment. Change 464943 had a related patch set uploaded (by Urbanecm; owner: Urbanecm): [pywikibot/core@master] Change default file mode for private files to 600 https://gerrit.wikimedia.org/r/464943TASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urbanecm, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T206385: Pywikibot sets non-executable file's mode to 700
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Urbanecm, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Triaged] T206385: Pywikibot sets non-executable file's mode to 700
Urbanecm triaged this task as "Low" priority.Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board. TASK DETAILhttps://phabricator.wikimedia.org/T206385WORKBOARDhttps://phabricator.wikimedia.org/project/board/2098/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrbanecmCc: gerritbot, Aklapper, pywikibot-bugs-list, Urbanecm, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T206385: Pywikibot sets non-executable file's mode to 700
Urbanecm created this task.Urbanecm added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.Restricted Application added a project: User-Urbanecm. TASK DESCRIPTIONHi, I figured out PWB automatically converts mode of user-password.py to 700 althrough 600 would be more appropriate, See this example: testovaci@notebook:~$ python ~/pywikibot/pwb.py login -family:species -lang:species WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/user-password.py had 600 mode; converted to 700 mode. warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode)) Logging in to species:species as UrbanecmBot@BotTest WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/pywikibot.lwp had 664 mode; converted to 600 mode. warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode)) Logged in on species:species as UrbanecmBot. MartinTASK DETAILhttps://phabricator.wikimedia.org/T206385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UrbanecmCc: Aklapper, pywikibot-bugs-list, Urbanecm, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T206367: Translating #Pywikibot to Serbian Latin is not possible
Framawiki added a project: Pywikibot. TASK DETAILhttps://phabricator.wikimedia.org/T206367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, Aklapper, Petar.petkovic, Zoranzoki21, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, JakeTheDeveloper, Devin-Henrickson, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Nemo_bis, Masti, Nikerabbit, Alchimista, Rxy, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
