[Pywikipedia-bugs] [Maniphest] [Commented On] T175451: Add script autocompletion support to pwb.py

2019-03-11 Thread Nikhil07prakash
Nikhil07prakash added a comment.


  @Dvorapa Can I take up this task?

TASK DETAIL
  https://phabricator.wikimedia.org/T175451

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikhil07prakash
Cc: Nikhil07prakash, Zoranzoki21, Xqt, Framawiki, Aklapper, 
pywikibot-bugs-list, Dvorapa, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495739 **merged** by jenkins-bot:
  [pywikibot/core@master] mysql: remove traces of 'oursql' dependency
  
  https://gerrit.wikimedia.org/r/495739

TASK DETAIL
  https://phabricator.wikimedia.org/T89976

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, gerritbot
Cc: hashar, gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, 
jayvdb, Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T142021: Error mysqlquery

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495739 **merged** by jenkins-bot:
  [pywikibot/core@master] mysql: remove traces of 'oursql' dependency
  
  https://gerrit.wikimedia.org/r/495739

TASK DETAIL
  https://phabricator.wikimedia.org/T142021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa, gerritbot
Cc: gerritbot, Milimetric, Dvorapa, Herzi.Pinki, Mpaa, valhallasw, Aklapper, 
pywikibot-bugs-list, Vladis13, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T217948: newitem.py -touch crashes on missing i18n

2019-03-11 Thread Dvorapa
Dvorapa added subscribers: Xqt, Dvorapa.
Dvorapa added a project: Pywikibot.
Dvorapa added a comment.


  Yeah, this message seems missing in i18n

TASK DETAIL
  https://phabricator.wikimedia.org/T217948

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, JAnD, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T217195: Add script misspelling support to pwb.py

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495457 **merged** by jenkins-bot:
  [pywikibot/core@master] pwb.py: Add ability to display similar scripts when 
misspelled
  
  https://gerrit.wikimedia.org/r/495457

TASK DETAIL
  https://phabricator.wikimedia.org/T217195

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Nikhil07prakash, Framawiki, Aklapper, pywikibot-bugs-list, 
Dvorapa, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Soteriaspace, 
RazeSoldier, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Tbscho, MayS, 
Ivanhercaz, Lewizho99, Mdupont, JJMC89, Maathavan, TerraCodes, Avicennasis, 
MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL

2019-03-11 Thread Dvorapa
Dvorapa added a comment.


  Oursql was not needed anymore, but I would leave MySQLdb fallback perhaps.

TASK DETAIL
  https://phabricator.wikimedia.org/T89976

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, Dvorapa
Cc: hashar, gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, 
jayvdb, Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL

2019-03-11 Thread hashar
hashar added a comment.


  Note that pywikibot now defaults to use PyMySQL which is the pure python 
module and defaults to it. That has been the case since October 2018.
  
  I have send a couple patches to clean up the code of mentions to `oursql` and 
remove support for `MySQLdb` has a fall back.

TASK DETAIL
  https://phabricator.wikimedia.org/T89976

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, hashar
Cc: hashar, gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, 
jayvdb, Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495740 had a related patch set uploaded (by Hashar; owner: Hashar):
  [pywikibot/core@master] mysql: drop support for MySQLdb module
  
  https://gerrit.wikimedia.org/r/495740

TASK DETAIL
  https://phabricator.wikimedia.org/T89976

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, gerritbot
Cc: gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, jayvdb, 
Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T142021: Error mysqlquery

2019-03-11 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T142021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa, gerritbot
Cc: gerritbot, Milimetric, Dvorapa, Herzi.Pinki, Mpaa, valhallasw, Aklapper, 
pywikibot-bugs-list, Vladis13, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T89976: mysql support should fall back to dependency on pure python package PyMySQL

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495739 had a related patch set uploaded (by Hashar; owner: Hashar):
  [pywikibot/core@master] mysql: remove traces of 'oursql' dependency
  
  https://gerrit.wikimedia.org/r/495739

TASK DETAIL
  https://phabricator.wikimedia.org/T89976

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa, gerritbot
Cc: gerritbot, Dvorapa, Ricordisamoa, XZise, pywikibot-bugs-list, jayvdb, 
Aklapper, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, 
Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T142021: Error mysqlquery

2019-03-11 Thread gerritbot
gerritbot added a comment.


  Change 495739 had a related patch set uploaded (by Hashar; owner: Hashar):
  [pywikibot/core@master] mysql: remove traces of 'oursql' dependency
  
  https://gerrit.wikimedia.org/r/495739

TASK DETAIL
  https://phabricator.wikimedia.org/T142021

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa, gerritbot
Cc: gerritbot, Milimetric, Dvorapa, Herzi.Pinki, Mpaa, valhallasw, Aklapper, 
pywikibot-bugs-list, Vladis13, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore

2019-03-11 Thread Dvorapa
Dvorapa added a comment.


  Let's describe it better:
  
  - first there is a matrix of supported py versions and two wikis with 
different settings
  - then no pip package installed - only system side packages
  - then a matrix of multiple wikis in the lowest supported py version 
(enwpbeta, zhwpbeta, enwsbeta, wikia, musicbrainz, testwiki, testwd, arwikt, 
wd), sometimes other py version or different environment to make it interesting 
:D + three oauth tests
  - then py3.7 and failing 3.8-dev
  
  Note: py3.7 perhaps should be added into the original matrix instead of 
having a special entry

TASK DETAIL
  https://phabricator.wikimedia.org/T186208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar, Dvorapa
Cc: zhuyifei1999, hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, 
Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, 
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, 
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore

2019-03-11 Thread Dvorapa
Dvorapa added a comment.


  Here is the fixed axis of 20 tests, that are run actually:
  
  | python| FAMILY  | LANGUAGE | OAUTH_DOMAIN   
 | PYSETUP_TEST_EXTRAS | NO_L10N_TESTS | SITE_ONLY | TEST_NO_RC | 
PROD_ONLY | TEST_TIMEOUT |
  | - | --- |  | 
--- | --- | - | 
- | -- | - |  |
  | 2.7   | wikipedia   | en   | None   
 | None| 1 | None  | None   | 1 
| 300  |
  | 3.4   | wikipedia   | en   | None   
 | None| 1 | None  | None   | 1 
| 300  |
  | 3.5   | wikipedia   | en   | None   
 | None| 1 | None  | None   | 1 
| 300  |
  | 3.6   | wikipedia   | en   | None   
 | None| 1 | None  | None   | 1 
| 300  |
  | 2.7   | wikisource  | zh   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 3.4   | wikisource  | zh   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 3.5   | wikisource  | zh   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 3.6   | wikisource  | zh   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 2.7_with_system_site_packages | wikipedia   | nb   | None   
 | 1   | 1 | None  | 1  | 
None  | 300  |
  | 2.7   | wpbeta  | en   | 
"en.wikipedia.beta.wmflabs.org" | None| 1 | 1   
  | None   | None  | 300  |
  | 3.6   | wpbeta  | zh   | 
"zh.wikipedia.beta.wmflabs.org" | None| 1 | 1   
  | None   | None  | 300  |
  | 3.4   | wsbeta  | en   | None   
 | None| 0 | 1 | None   | 
None  | 300  |
  | 2.7   | wikia   | wikia| None   
 | None| 1 | None  | 1  | 
None  | 300  |
  | 3.5   | musicbrainz | en   | None   
 | None| 1 | 1 | None   | 
None  | 300  |
  | 3.4   | wikipedia   | test | 
"test.wikipedia.org"| None| 1 | 1   
  | None   | None  | 300  |
  | 3.4   | wikidata| test | None   
 | None| 1 | 1 | None   | 
None  | 300  |
  | 3.4   | wiktionary  | ar   | None   
 | None| 1 | None  | 1  | 
None  | 300  |
  | 3.6   | wikidata| wikidata | None   
 | None| 1 | 1 | None   | 
None  | 300  |
  | 3.7   | wikipedia   | de   | None   
 | None| 1 | None  | None   | 
None  | 300  |
  | 3.8-dev (allowed failure) | wikipedia   | test | None   
 | None| 1 | 1 | None   | 
None  | 300  |

TASK DETAIL
  https://phabricator.wikimedia.org/T186208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar, Dvorapa
Cc: zhuyifei1999, hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, 
Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, 
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, 
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T186208: Magul's quick tests doesn't run anymore

2019-03-11 Thread Dvorapa
Dvorapa added a subscriber: zhuyifei1999.
Dvorapa added a comment.


  In T186208#5015166 , 
@hashar wrote:
  
  > sudo
  
  
  sudo and xenial are required by Travis to make py3.7 and py3.8 work, you are 
right. On WM CI any setup that can run py3.5-3.8 could be used for the job, 
sudo and xenial are not required.
  
  > global env
  
  I think the 2.7_with_system_side_packages does not install anything using pip 
and use what's installled on the system instead and that's what it differs from 
the others (but I'm not sure, pinging @Xqt, @Dalba, @zhuyifei1999). Anyway this 
test is needed, perhaps you haven't understood its purpose correctly?
  
  TEST_PROD_ONLY is not used globally, see e.g. last build 
https://travis-ci.org/wikimedia/pywikibot, it is used only on some of the 
tests. You are right, this is for tests, that can be run only on production 
wikis (not mw or test). I would leave all the env vars as they are and leave 
this topic of deprecating some env vars to another task(s)
  
  TEST_NO_RC is usually used for sites, which's RC is usually empty. This is 
also needed.
  
  > The global env matrix sets `LANGUAGE` and `FAMILY`
  
  Yeah, remove them, why not!
  
  > The huge combination of 26 axis
  
  Ummm, the number differs from the actual tests, taht are done. See the last 
build: https://travis-ci.org/wikimedia/pywikibot it runs only 20 tests, not 26. 
What's the difference between your table and Travis table?
  
  > script
  >  The super long yaml script is not convenient. It would be nicer to have 
all the logic extracted to a standalone file and just invoke that.
  
  Yeah, we discussed that earlier, I agree.
  
  > OAUTH_DOMAIN
  >  It is set from the matrix, seems to me it is easier to set it in the 
script itself.
  
  I'm not sure I understand what you mean by this.

TASK DETAIL
  https://phabricator.wikimedia.org/T186208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar, Dvorapa
Cc: zhuyifei1999, hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, 
Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, 
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, 
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore

2019-03-11 Thread hashar
hashar added a comment.


  A few things that are worth investigating and probably could use to be 
simplified.
  
  sudo
  
  
  The default is `sudo: false`, a few environments do have `sudo: require` when 
they have `dist: xenial`:
  
include:
- python: '2.7_with_system_site_packages'
  env: LANGUAGE=nb FAMILY=wikipedia PYSETUP_TEST_EXTRAS=1 
PYWIKIBOT_TEST_NO_RC=1
  dist: xenial
  sudo: required
  addons:
apt:
  packages:
- djvulibre-bin
- graphviz
- liblua5.1-0-dev
- python-ipaddr
- python: '3.7'
  env: LANGUAGE=de FAMILY=wikipedia
  dist: xenial
  sudo: required
- python: '3.8-dev'
  env: LANGUAGE=test FAMILY=wikipedia PYWIKIBOT_SITE_ONLY=1
  dist: xenial
  sudo: required
  allow_failures:
- python: '3.8-dev'
  env: LANGUAGE=test FAMILY=wikipedia PYWIKIBOT_SITE_ONLY=1
  dist: xenial
  sudo: required
  
  One sure thing, we can't right know support the env 
'2.7_with_system_site_packages' since the CI job do not have sudo access to 
install extra packages. For the others, I am not sure why sudo is required on 
xenial? Maybe to get python 3.7 or 3.8 dev to be installed?
  
  global env
  ==
  
env:
  global:
- TEST_TIMEOUT=300
- PYWIKIBOT_NO_L10N_TESTS=1

  matrix:
- LANGUAGE=en FAMILY=wikipedia PYWIKIBOT_TEST_PROD_ONLY=1
- LANGUAGE=zh FAMILY=wikisource PYSETUP_TEST_EXTRAS=1 
PYWIKIBOT_TEST_PROD_ONLY=1 PYWIKIBOT_TEST_NO_RC=1
  
  The global env matrix sets `LANGUAGE` and `FAMILY` but they are always set in 
the matrix below. I would drop them from the global and have the `script:` part 
to fail immediately when either is not set.
  
  `PYWIKIBOT_TEST_PROD_ONLY=1` is always set, could be moved up in 
`env.global`. Note the environment variable is only listed in 
`tests.aspects.py`:
  
for data in cls.sites.values():
if ('code' in data and data['code'] in ('test', 'mediawiki')
and 'PYWIKIBOT_TEST_PROD_ONLY' in os.environ and not dry):
raise unittest.SkipTest(
'Site code "{}" and PYWIKIBOT_TEST_PROD_ONLY is set.'
.format(data['code']))
  
  Which seems to indicate tests are skipped when they are marked with 
`code=test` or `code=mediawiki`. Seems to me the variable can be set when 
`LANGUAGE` is set to `test` or `mediawiki` instead of always setting it.
  
  The second global matrix sets `PYWIKIBOT_TEST_NO_RC=1`, seems to be set 
because the test suite does not accommodate for some customization made on 
sites.
  
  `PYSETUP_TEST_EXTRAS` seems to be a huge hack that affects the build a lot 
with a few hacks all other the place.
  
  script
  ==
  
  The super long yaml script is not convenient. It would be nicer to have all 
the logic extracted to a standalone file and just invoke that. Eg:
  
script:
  - citestrunner.sh

TASK DETAIL
  https://phabricator.wikimedia.org/T186208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, Magul, 
Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, 
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, 
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T186208: Magul's quick tests doesn't run anymore

2019-03-11 Thread hashar
hashar added a comment.


  From the `.travis.yml` file. Some global environment variables:
  
env:
  global:
- TEST_TIMEOUT=300
- PYWIKIBOT_NO_L10N_TESTS=1
  
  Then there are two set of globals:
  
env:
  matrix:
- LANGUAGE=en FAMILY=wikipedia PYWIKIBOT_TEST_PROD_ONLY=1
- LANGUAGE=zh FAMILY=wikisource PYSETUP_TEST_EXTRAS=1 
PYWIKIBOT_TEST_PROD_ONLY=1 PYWIKIBOT_TEST_NO_RC=1
  
  Then there are 13 entries in the matrix, one of them is allowing to fail 
(python 3.8-dev). The huge combination of 26 axis ends up being:
  
  | python| FAMILY  | LANGUAGE | OAUTH_DOMAIN   
 | PYSETUP_TEST_EXTRAS | NO_L10N_TESTS | SITE_ONLY | TEST_NO_RC | 
PROD_ONLY | TEST_TIMEOUT |
  | - | --- |  | 
--- | --- | - | 
- | -- | - |  |
  | 2.7_with_system_site_packages | wikipedia   | nb   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 2.7   | wpbeta  | en   | 
"en.wikipedia.beta.wmflabs.org" | None| 1 | 1   
  | None   | 1 | 300  |
  | 3.6   | wpbeta  | zh   | 
"zh.wikipedia.beta.wmflabs.org" | None| 1 | 1   
  | None   | 1 | 300  |
  | 3.4   | wsbeta  | en   | None   
 | None| 0 | 1 | None   | 1 
| 300  |
  | 2.7   | wikia   | wikia| None   
 | None| 1 | None  | 1  | 1 
| 300  |
  | 3.5   | musicbrainz | en   | None   
 | None| 1 | 1 | None   | 1 
| 300  |
  | 3.4   | wikipedia   | test | 
"test.wikipedia.org"| None| 1 | 1   
  | None   | 1 | 300  |
  | 3.4   | wikidata| test | None   
 | None| 1 | 1 | None   | 1 
| 300  |
  | 3.4   | wiktionary  | ar   | None   
 | None| 1 | None  | 1  | 1 
| 300  |
  | 3.6   | wikidata| wikidata | None   
 | None| 1 | 1 | None   | 1 
| 300  |
  | 3.7   | wikipedia   | de   | None   
 | None| 1 | None  | None   | 1 
| 300  |
  | 3.8-dev   | wikipedia   | test | None   
 | None| 1 | 1 | None   | 1 
| 300  |
  | 3.8-dev(failling) | wikipedia   | test | None   
 | None| 1 | 1 | None   | 1 
| 300  |
  | 2.7_with_system_site_packages | wikipedia   | nb   | None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 2.7   | wpbeta  | en   | 
"en.wikipedia.beta.wmflabs.org" | 1   | 1 | 1   
  | 1  | 1 | 300  |
  | 3.6   | wpbeta  | zh   | 
"zh.wikipedia.beta.wmflabs.org" | 1   | 1 | 1   
  | 1  | 1 | 300  |
  | 3.4   | wsbeta  | en   | None   
 | 1   | 0 | 1 | 1  | 1 
| 300  |
  | 2.7   | wikia   | wikia| None   
 | 1   | 1 | None  | 1  | 1 
| 300  |
  | 3.5   | musicbrainz | en   | None   
 | 1   | 1 | 1 | 1  | 1 
| 300  |
  | 3.4   | wikipedia   | test | 
"test.wikipedia.org"| 1   | 1 | 1   
  | 1  | 1 | 300  |
  | 3.4   | wikidata| test | None   
 | 1   | 1 | 1 | 1  | 1 
| 300  |
  | 3.4   | wiktionary  | ar   | None   
 | 1   | 1