[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot
Anomie added a comment. In T132676#6575067 <https://phabricator.wikimedia.org/T132676#6575067>, @Mpaa wrote: > @Anomie is base64 encode supported by api action=upload? Not in itself, but you can use MIME's Content-Transfer-Encoding to encode the data as base64 rather than binary. Since I no longer work for the WMF, I'm not inclined to do much to do their work for them at this time. TASK DETAIL https://phabricator.wikimedia.org/T132676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: AntiCompositeNumber, Fae, Mpaa, Anomie, Avicennasis, MarkTraceur, Multichill, Liuxinyu970226, pywikibot-bugs-list, Matanya, matmarex, czar, Aklapper, Steinsplitter, zhuyifei1999, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T249705: pywikibot encounters an internal API error with Flow on testwiki (but not other wikis)
Anomie added a comment. In T249705#6040712 <https://phabricator.wikimedia.org/T249705#6040712>, @ssastry wrote: > - also shows a bunch of errors on April 6th around 1500 UTC (before the current train rollout to group 0) Also I see it continues to occur on 1.35.0-wmf.26, so again likely not the wmf.27 train. > - unclear if this is necessarily limited to pywikibot since logstash isn't showing us the user-agent string. I just ran into it trying to submit a comment on officewiki with Firefox. Out of annoyance I clicked "save" several more times, and it did finally go through after erroring the first half-dozen times. TASK DETAIL https://phabricator.wikimedia.org/T249705 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Joe, cscott, Jdforrester-WMF, ssastry, kostajh, Aklapper, pywikibot-bugs-list, Dvorapa, NavinRizwi, Zkhalido, Demian, Viztor, 94rain, DannyS712, Lens0021, Wenyi, Jony, 45Jayjay1969, Jayprakash12345, Tbscho, MayS, EnricoCNC, Mdupont, JJMC89, Altostratus, Taiwania_Justo, Avicennasis, SBisson, MGChecker, mys_721tx, Jrf, Dinoguy1000, Gryllida, jeblad, jayvdb, Catrope, Masti, happy5214, Alchimista, Arlolra, Rxy, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T249705: Internal API error with Flow on testwiki
Anomie removed projects: Core Platform Team, MediaWiki-API. TASK DETAIL https://phabricator.wikimedia.org/T249705 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Amorymeltzer, Sethakill, dg711, Agabi10, Pchelolo, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times
Anomie added a comment. No need IMO. T145545 <https://phabricator.wikimedia.org/T145545> exists for the WMF side of things. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc: PeterBowman, Reedy, Urbanecm, Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Kent7301, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times
Anomie added a comment. In general, Wikimedia should probably figure out some way to reconfigure things so it doesn't wind up trying to set both cookies with domain=.wikisource.org and domainless cookies for wikisource.org. It's probably best to use T145545 <https://phabricator.wikimedia.org/T145545> to pursue that. However, it looks like the cookie handling library used by pywikibot is also doing something wrong (at least according to the RFCs), as it should not send the host-only cookie for wikisource.org to zh.wikisource.org. If it's using RFC 2109, "zh.wikisource.org" does not domain-match the cookie for "wikisource.org" because "wikisource.org" doesn't begin with a dot. If it's using RFC 6265, the domainless cookie for "wikisource.org" should have had the host-only-flag set meaning it should not be sent to "zh.wikisource.org". OTOH, it's possible it's being bug-compatible with browsers (RFC 6265 even notes that such a bug exists/existed in some agents in § 4.1.2.3 <https://tools.ietf.org/html/rfc6265#section-4.1.2.3>). As far as pywikibot's tests, you might work around all this by avoiding logging in to both wikisource.org and a subdomain during the same test run, or explicitly logging out of wikisource.org after completing the tests against that site, or otherwise flushing cookies. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc: Reedy, Urbanecm, Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Kent7301, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T224712: Attempt to login fails several times
Anomie added a comment. In T224712#6019636 <https://phabricator.wikimedia.org/T224712#6019636>, @Dvorapa wrote: > When you/Pywikibot interact with any wiki, you only have one centralauth session cookie. But when you visit wikisource.org after you visited *.wikisource.org (zh) (i.e. to check zh families in wikimedia farm), you end up with two centralauth session cookies for: > > - **.**wikisource.org > - wikisource.org Ah ha! That's described in more detail at T145545#2634528 <https://phabricator.wikimedia.org/T145545#2634528>. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc: Reedy, Urbanecm, Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Kent7301, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times
Anomie added a comment. It's hard to copy-paste from screenshots... Hopefully the OCR doesn't mangle things too badly. In T224712#6018928 <https://phabricator.wikimedia.org/T224712#6018928>, @Urbanecm wrote: > F31719968: image.png <https://phabricator.wikimedia.org/F31719968> In this response MediaWiki includes Set-Cookie headers resembling Set-Cookie: zhwikisourceSession=deleted; expires,Thu, 01-3an-1970 00:00:01 GMT; Max-Aged; path=/; secure; HttpOnly Set-Cookie: forceHTTPS=deleted; expires,Thu, 01-Ian-1970 00:00:01 GMT; Max-Aged; path4; domainG.wikisource.org; HttpOnly Set-Cookie: forceHTTPS=deleted; expires,Thu, 01-Ian-1970 00:00:01 GMT; Max-Aged; path4; HttpOnly Set-Cookie: centralauth_User=deleted; expires,Thu, 01-Ian-1970 00:00:01 GMT; Max-Age=0; path4; domainG.wikisource.org; secure; HttpOnly Set-Cookie: centralauth TokenGdeleted; expires,Thu, 01-Ian-1970 00:00:01 GMT; Max-Age=0; path4; domainG.wikisource.org; secure; HttpOnly Set-Cookie: centralauth_SessionGdeleted; expires,Thu, 01-3an-1970 00:00:01 GMT; Max-Age=0; path4; domainG.wikisource.org; secure; HttpOnly Set-Cookie: zhwikisourceSessionG4aqnnbi ; path=/; secure; HttpOnly > F31719972: image.png <https://phabricator.wikimedia.org/F31719972> However in this request you're still sending the centralauth_User, centralauth_Token, and centralauth_Session cookies that you were instructed to delete. That will cause MediaWiki to still attempt to use the specified CentralAuth session, which will fail because that session no longer exists. Hence the rejection of the token. > but either MW should've deleted _both_ occurances of the cookie, What "both"? > My current hypothesis is MediaWiki tries to refresh all session cookies if it spots one (in this case, the CentralAuth one) which is invalid. This could explain the cycle. That's a correct hypothesis. More specifically, it tries to load the CentralAuth session based on the supplied cookies, finds it invalid, and so produces Set-Cookie headers to tell the browser to delete the relevant cookies. Then (when applicable) it creates a new local session and sets the zhwikisourceSession cookie. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc: Reedy, Urbanecm, Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Kent7301, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T224712: Attempt to login fails several times
Anomie removed a project: Core Platform Team Workboards (Clinic Duty Team). Anomie added a comment. Where is this news? All I see is a giant paste showing pywikibot caught in some sort of loop. I see no MediaWiki requests/responses that claim to be showing incorrect behavior. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Anomie Cc: Urbanecm, Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Kent7301, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Legoktm, eprodromou, Agabi10 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T130911: redirect.py fails for RuntimeError
Anomie removed a project: Core Platform Team. TASK DETAIL https://phabricator.wikimedia.org/T130911 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Anomie Cc: alanajjar, Meno25, Anomie, Dvorapa, jayvdb, gerritbot, Aklapper, Xqt, pywikibot-bugs-list, Zkhalido, WDoranWMF, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Jackmcbarn, Rxy, Krenair, Legoktm, holger.knust, EvanProdromou, Agabi10, Pchelolo ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T224712: Attempt to login fails several times
Anomie added a comment. In T224712#5920305 <https://phabricator.wikimedia.org/T224712#5920305>, @Dvorapa wrote: > @Anomie @Jdforrester-WMF I broke Pywikibot login loop and found out the issue with zh.wikisource.org. It seems API sometimes reacts weirdly to action=login requests. For `format=json=Pywikibot-test=login=5=[secure]=77c559a0bf34eaf6755aaebca7a56ba25e5693bf+\` API responds with `API warning (login): Fetching a token via "action=login" is deprecated. Use "action=query=tokens=login" instead.` and the result contains `NeedToken` and a token, which gives `invalid` if checked by `checktoken`. > [...] > There are two weird things: Why doesn't API accept lgtoken in the first request (token is freshly generated) and why NeedToken gives invalid tokens afterwards (which results with a login loop)? Yes, that was fairly obvious as to what was happening from https://travis-ci.org/wikimedia/pywikibot/jobs/654150636, as it already logged that warning. That's caused by the session being lost on every new request. There are, broadly, three ways the session might be lost: 1. Something in MediaWiki's session handling is broken, as was the case for en.wikisource.beta.wmflabs.org earlier. 2. Something in your client (probably cookie handling) is broken. This can include the client somehow having a stale/corrupt cookie that isn't removed by MediaWiki's attempts to unset it. 3. Some proxy in between your client and MediaWiki is breaking the request somehow. My being unable to reproduce it in locally (several times now over a few days) makes #1 seem less likely, as does the fact that there's no "Unbreak Now!" task open about this affecting human users. But that doesn't completely rule it out. Being able to examine the actual HTTP request and response headers for all requests during the failed login would go a long way towards investigating #2, which is why I asked for that. Unfortunately the log you provided does not seem to contain that information. TASK DETAIL https://phabricator.wikimedia.org/T224712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Anomie Cc: Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T224712: Attempt to login fails several times
Anomie moved this task from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board. Anomie added a comment. In T224712#5913343 <https://phabricator.wikimedia.org/T224712#5913343>, @Dvorapa wrote: > Beta Cluster is fixed, but still fails for zh.wikisource.org, see: Can't reproduce (with non-Pywikibot code), login to zh.wikisource.org works fine for me. If you still think it's a problem in MediaWiki or Wikimedia's infrastructure, you should supply the HTTP requests and responses to verify that cookies and such are being handled correctly. TASK DETAIL https://phabricator.wikimedia.org/T224712 WORKBOARD https://phabricator.wikimedia.org/project/board/4149/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo, Anomie Cc: Jdforrester-WMF, Pchelolo, Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, WDoranWMF, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T245989: Wikidata API fails with timeout when asking for 5 RC redirects
Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-API board. Anomie edited projects, added Core Platform Team Workboards (Clinic Duty Team), DBA; removed Core Platform Team. Anomie added a comment. The query in question is SELECT rc_id,rc_timestamp,rc_namespace,rc_title,rc_cur_id,rc_type,rc_deleted,rc_this_oldid,rc_last_oldid,rc_minor,rc_type,rc_bot,rc_old_len,rc_new_len,rc_logid,rc_log_type,rc_log_action,rc_params,(SELECT GROUP_CONCAT(ctd_name SEPARATOR ',') FROM `change_tag` JOIN `change_tag_def` ON ((ct_tag_id=ctd_id)) WHERE ct_rc_id=rc_id ) AS `ts_tags`,page_is_redirect,comment_rc_comment.comment_text AS `rc_comment_text`,comment_rc_comment.comment_data AS `rc_comment_data`,comment_rc_comment.comment_id AS `rc_comment_cid`,actor_rc_user.actor_user AS `rc_user`,actor_rc_user.actor_name AS `rc_user_text`,rc_actor FROM `recentchanges` LEFT JOIN `page` ON ((rc_namespace=page_namespace) AND (rc_title=page_title)) JOIN `comment` `comment_rc_comment` ON ((comment_rc_comment.comment_id = rc_comment_id)) JOIN `actor` `actor_rc_user` ON ((actor_rc_user.actor_id = rc_actor)) WHERE rc_type IN (0,1,3,6) AND (page_is_redirect = 1) ORDER BY rc_timestamp DESC,rc_id DESC LIMIT 6 It looks like it's another situation where the database decides to pick a poor plan: wikiadmin@10.64.16.85(wikidatawiki)> explain SELECT rc_id,rc_timestamp,rc_namespace,rc_title,rc_cur_id,rc_type,rc_deleted,rc_this_oldid,rc_last_oldid,rc_minor,rc_type,rc_bot,rc_old_len,rc_new_len,rc_logid,rc_log_type,rc_log_action,rc_params,(SELECT GROUP_CONCAT(ctd_name SEPARATOR ',') FROM `change_tag` JOIN `change_tag_def` ON ((ct_tag_id=ctd_id)) WHERE ct_rc_id=rc_id ) AS `ts_tags`,page_is_redirect,comment_rc_comment.comment_text AS `rc_comment_text`,comment_rc_comment.comment_data AS `rc_comment_data`,comment_rc_comment.comment_id AS `rc_comment_cid`,actor_rc_user.actor_user AS `rc_user`,actor_rc_user.actor_name AS `rc_user_text`,rc_actor FROM `recentchanges` LEFT JOIN `page` ON ((rc_namespace=page_namespace) AND (rc_title=page_title)) JOIN `comment` `comment_rc_comment` ON ((comment_rc_comment.comment_id = rc_comment_id)) JOIN `actor` `actor_rc_user` ON ((actor_rc_user.actor_id = rc_actor)) WHERE rc_type IN (0,1,3,6) AND (page_is_redirect = 1) ORDER BY rc_timestamp DESC,rc_id DESC LIMIT 6; +--+++++--+-+---+-+-+ | id | select_type| table | type | possible_keys | key | key_len | ref | rows| Extra | +--+++++--+-+---+-+-+ |1 | PRIMARY| page | ref| name_title,page_redirect_namespace_len | page_redirect_namespace_len | 1 | const | 5662884 | Using temporary; Using filesort | |1 | PRIMARY| recentchanges | ref| rc_name_type_patrolled_timestamp,rc_ns_actor,rc_actor,rc_namespace_title_timestamp | rc_namespace_title_timestamp | 261 | wikidatawiki.page.page_namespace,wikidatawiki.page.page_title | 1 | Using where | |1 | PRIMARY| actor_rc_user | eq_ref | PRIMARY | PRIMARY | 8 | wikidatawiki.recentchanges.rc_actor | 1 | | |1 | PRIMARY| comment_rc_comment | eq_ref | PRIMARY | PRIMARY | 8 | wikidatawiki.recentchanges.rc_comment_id | 1 | | |2 | DEPENDENT SUBQUERY | change_tag | ref| change_tag_rc_tag_id,change_tag_tag_id_id | change_tag_rc_tag_id | 5 | wikidatawiki.recentchanges.rc_id | 1 | Using index | |2 | DEPENDENT SUBQUERY | change_tag_def | eq_ref | PRIMARY | PRIMARY
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T224712: Attempt to login fails several times
Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-API
board.
Anomie added a comment.
This seems unlikely to be anything to do with the API itself. More likely for
these symptoms is some failure in the session storage or in the client's cookie
handling.
I can't manage to reproduce locally (and using AnomieBOT's framework rather
that Pywikibot) with en.wikipedia.beta.wmflabs.org, but I was able to using
en.wikisource.beta.wmflabs.org. I note the following sort of thing in the logs
on deployment-fluorine02:
2020-02-21 14:30:02 [Xk-paqwQBHcAAGBrI6MAAABH] deployment-mediawiki-07
enwikisource 1.35.0-alpha objectcache DEBUG: POST:
https://deployment-sessionstore03.deployment-prep.eqiad.wmflabs:8080/sessions/v1/enwikisource%3AMWSession%3Agqtkfu552j6gok6g6054s0irrr1vslj1
2020-02-21 14:30:02 [Xk-paqwQBHcAAGBrI6MAAABH] deployment-mediawiki-07
enwikisource 1.35.0-alpha objectcache WARNING: Error fetching URL
"https://deployment-sessionstore03.deployment-prep.eqiad.wmflabs:8080/sessions/v1/enwikisource%3AMWSession%3Agqtkfu552j6gok6g6054s0irrr1vslj1":
(curl error: 35) SSL connect error
2020-02-21 14:30:02 [Xk-paqwQBHcAAGBrI6MAAABH] deployment-mediawiki-07
enwikisource 1.35.0-alpha objectcache ERROR: Failed to store
enwikisource:MWSession:gqtkfu552j6gok6g6054s0irrr1vslj1 : (0) (curl error: 35)
SSL connect error {"code":0,"error":"(curl error: 35) SSL connect error"}
So it does indeed seem to be a problem in the session storage.
TASK DETAIL
https://phabricator.wikimedia.org/T224712
WORKBOARD
https://phabricator.wikimedia.org/project/board/200/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: Anomie, Dvorapa, Framawiki, Aklapper, pywikibot-bugs-list, Dalba, Xqt,
Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400,
E.S.A-Sheild, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john,
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo,
Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420,
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6,
Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711,
Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Masti,
Alchimista, Rxy, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T245374: WMFTimeoutException on non-existent files
Anomie removed projects: MediaWiki-API, Core Platform Team.
Anomie added a comment.
> Pywikibot is using POST and not GET, but it fails the same. Most recent
attempt resulted in
>
>
{"error":{"code":"internal_api_error_WMFTimeoutException","info":"[XknCBQpAAEsAAJ7w@woAAACH]
Caught exception of type
WMFTimeoutException","errorclass":"WMFTimeoutException"},"servedby":"mw1280"}
>
> Could someone with logstash access look into what's going on with the
media-wiki end?
The exception logged by MediaWiki for that error was
2020-02-16 22:29:22 [XknCBQpAAEsAAJ7w@woAAACH] mw1280 commonswiki
1.35.0-wmf.19 exception ERROR: [XknCBQpAAEsAAJ7w@woAAACH]
/w/api.php?gaifrom=%F0%A9%B5%8F=info|imageinfo|categoryinfo=protection=timestamp|user|comment|url|size|sha1|metadata=max=allimages=query==gaicontinue||userinfo=descending=500=userinfo=blockinfo|hasmsg=5=json=%EF%BC%90%EF%BC%97%E5%BC%8F%E6%A9%9F%E5%8B%95%E6%94%AF%E6%8F%B4%E6%A9%8B%EF%BC%88%E8%A3%85%E5%82%99%E5%93%81%E5%B1%95%E7%A4%BA%E3%83%BB%E6%96%BD%E8%A8%AD%E5%AD%A6%E6%A0%A1%EF%BC%89_(4).jpg
WMFTimeoutException from line 39 of
/srv/mediawiki/wmf-config/set-time-limit.php: the execution time limit of 60
seconds was exceeded
{"exception_id":"XknCBQpAAEsAAJ7w@woAAACH","exception_url":"/w/api.php?gaifrom=%F0%A9%B5%8F=info|imageinfo|categoryinfo=protection=timestamp|user|comment|url|size|sha1|metadata=max=allimages=query==gaicontinue||userinfo=descending=500=userinfo=blockinfo|hasmsg=5=json=%EF%BC%90%EF%BC%97%E5%BC%8F%E6%A9%9F%E5%8B%95%E6%94%AF%E6%8F%B4%E6%A9%8B%EF%BC%88%E8%A3%85%E5%82%99%E5%93%81%E5%B1%95%E7%A4%BA%E3%83%BB%E6%96%BD%E8%A8%AD%E5%AD%A6%E6%A0%A1%EF%BC%89_(4).jpg","caught_by":"mwe_handler"}
[Exception WMFTimeoutException]
(/srv/mediawiki/wmf-config/set-time-limit.php:39) the execution time limit of
60 seconds was exceeded
#0 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiResult.php(370):
{closure}(integer)
#1 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiResult.php(371):
ApiResult::validateValue(array)
#2 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiResult.php(411):
ApiResult::validateValue(array)
#3 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiQueryBase.php(496):
ApiResult->addValue(array, NULL, array)
#4
/srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiQueryImageInfo.php(183):
ApiQueryBase->addPageSubItem(integer, array)
#5 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiQuery.php(255):
ApiQueryImageInfo->execute()
#6 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiMain.php(1586):
ApiQuery->execute()
#7 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiMain.php(522):
ApiMain->executeAction()
#8 /srv/mediawiki/php-1.35.0-wmf.19/includes/api/ApiMain.php(493):
ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.35.0-wmf.19/api.php(84): ApiMain->execute()
#10 /srv/mediawiki/w/api.php(3): require(string)
#11 {main}
Unfortunately that doesn't tell us a whole lot.
When I tried the URL in the description just now, instead of a timeout it
gave an error page stating "Allowed memory size of 692060160 bytes exhausted
(tried to allocate 40960 bytes)". Overall, handling of metadata in ApiImageInfo
is pretty crappy and the whole thing needs a rewrite
<https://phabricator.wikimedia.org/T89971>.
I'm going to untag #MediaWiki-API
<https://phabricator.wikimedia.org/tag/mediawiki-api/> from this task, as the
API part is likely a duplicate of one of the subtasks of T89971
<https://phabricator.wikimedia.org/T89971>.
TASK DETAIL
https://phabricator.wikimedia.org/T245374
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: Anomie, Xqt, Urbanecm, TheSandDoctor, Aklapper, AntiCompositeNumber,
pywikibot-bugs-list, Zkhalido, Viztor, Legado_Shulgin, Wenyi, Davinaclare77,
Qtn1293, Techguru.pc, Th3d3v1ls, Hfbn0, Tbscho, MayS, Zppix, Mdupont, JJMC89,
Dvorapa, Altostratus, Avicennasis, Wong128hk, mys_721tx, jayvdb, faidon, Masti,
Alchimista, Rxy, Jay8g, fgiunchedi, WDoranWMF, holger.knust, EvanProdromou,
DannyS712, Amorymeltzer, Sethakill, dg711, Agabi10, Pchelolo, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Xqt, Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Amorymeltzer, Sethakill, dg711, Agabi10, Pchelolo, jayvdb, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T210657: Handle different Action API uncaught exception error codes in Pywikibot
Anomie added a comment. I don't know of a way to force such errors on Wikimedia sites, as any way of doing so would be considered a bug that we would want to fix. I suppose you could see if there are any open tasks in Phabricator with reproducible test cases. If you have your own wiki set up somewhere for testing, just insert something like throw new RuntimeException( "Testing" ); at the top of the `execute()` method of some API module. TASK DETAIL https://phabricator.wikimedia.org/T210657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Framawiki, zhuyifei1999, Xqt, Aklapper, pywikibot-bugs-list, Multichill, Anomie, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T210657: Handle different Action API uncaught exception error codes in Pywikibot
Anomie added a comment. In T210657#4785525 <https://phabricator.wikimedia.org/T210657#4785525>, @Anomie wrote: > In T210657#4784221 <https://phabricator.wikimedia.org/T210657#4784221>, @Xqt wrote: > >> Is that really right? Can’t see any changes for the code but it was announced that it will be just “internal_api_error” > > The code is not changing yet in 1.33.0-wmf.8, so we can avoid breaking your existing code that's looking for "internal_api_error_". It will change in the future. It has been over a year now. I hope to make that change soon. TASK DETAIL https://phabricator.wikimedia.org/T210657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Framawiki, zhuyifei1999, Xqt, Aklapper, pywikibot-bugs-list, Multichill, Anomie, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T241413: A lot of wikisource urls are redirected to the "mul" site
Anomie closed subtask T242537: A lot of wikisource interwikimap urls are redirected as Declined. TASK DETAIL https://phabricator.wikimedia.org/T241413 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Aklapper, Dvorapa, Liuxinyu970226, Xqt, pywikibot-bugs-list, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T238992: [Feature Request]: Querying image description with Pywikibot API
Anomie removed projects: MediaWiki-API, Core Platform Team.
Anomie added a comment.
In T238992#5791159 <https://phabricator.wikimedia.org/T238992#5791159>, @Mpaa
wrote:
> Because it is not exposed by mediawiki API, afaik.
The core API is not in the business of parsing data out of the wikitext.
The #commonsmetadata <https://phabricator.wikimedia.org/tag/commonsmetadata/>
extension provides an ImageDescription extracted from the `{{Information}}`
template with prop=imageinfo=extmetadata
<https://commons.wikimedia.org/w/api.php?action=query=imageinfo=extmetadata=File:Example.svg>.
#structureddataoncommons
<https://phabricator.wikimedia.org/tag/structureddataoncommons/> may someday
provide a description as structured data (currently it only provides
"captions", I'm not sure of the difference), which would be accessed via
Wikibase API endpoints <https://www.mediawiki.org/wiki/Wikibase/API> such as
action=wbgetentities
<https://commons.wikimedia.org/w/api.php?action=wbgetentities=M937952>.
TASK DETAIL
https://phabricator.wikimedia.org/T238992
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: Anomie, Mpaa, Aklapper, pywikibot-bugs-list, OlehOnyshchcak, Zkhalido,
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus,
Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, WDoranWMF,
holger.knust, EvanProdromou, DannyS712, Amorymeltzer, Sethakill, dg711,
Agabi10, Pchelolo, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Xqt, Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Amorymeltzer, Sethakill, dg711, Agabi10, Pchelolo, jayvdb, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T239213: Conflicting timestamp in file history
Anomie added a comment. Any image with a version showing "No thumbnail" will probably give you the response described in this task. It's not necessary to give more examples of the same. The inability to delete that file is not related to this task, although it may be another side effect of whatever is the reason for the "No thumbnail" version. See, for example, T173374 <https://phabricator.wikimedia.org/T173374> which was filed long before the change that caused the responses causing you trouble here. TASK DETAIL https://phabricator.wikimedia.org/T239213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, daniel, mobrovac, pywikibot-bugs-list, Reedy, Aklapper, Fae, AndreasTraut, Zkhalido, WDoranWMF, Viztor, DannyS712, Wenyi, Jony, Amorymeltzer, RazeSoldier, Jayprakash12345, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Poyekhali, Altostratus, Taiwania_Justo, Avicennasis, Pchelolo, Ixocactus, Wong128hk, mys_721tx, El_Grafo, Dinoguy1000, jayvdb, Dalba, Masti, Alchimista, Steinsplitter, Rxy, Keegan, Legoktm, Tgr ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T239213: Conflicting timestamp in file history
Anomie edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team. TASK DETAIL https://phabricator.wikimedia.org/T239213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, daniel, mobrovac, pywikibot-bugs-list, Reedy, Aklapper, Fae, AndreasTraut, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, WDoranWMF, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Jony, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Dvorapa, Poyekhali, Altostratus, Taiwania_Justo, Avicennasis, Pchelolo, Ixocactus, Wong128hk, mys_721tx, El_Grafo, Dinoguy1000, jayvdb, Dalba, Masti, Alchimista, Steinsplitter, Rxy, Keegan, Legoktm, Tgr, holger.knust, EvanProdromou, Agabi10 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T239213: Conflicting timestamp in file history
Anomie added a comment. In T239213#5692769 <https://phabricator.wikimedia.org/T239213#5692769>, @Reedy wrote: > Though I don't completely agree with the change log of all these things being "meaningless in this context", especially if the UI is showing some of them... T221812: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php <https://phabricator.wikimedia.org/T221812> seems to have been concerned with images that don't exist at all, while this task is about images where the metadata exists in `image` or `oldimage` but the file itself is missing. It's meaningless to display "Unknown user" as the user, the current time as the timestamp, 0 for size, width, and height, and so on for the former, but for the latter those all have valid values. TASK DETAIL https://phabricator.wikimedia.org/T239213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, daniel, mobrovac, pywikibot-bugs-list, Reedy, Aklapper, Fae, AndreasTraut, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, WDoranWMF, holger.knust, EvanProdromou, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Jony, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Dvorapa, Poyekhali, Agabi10, Altostratus, Taiwania_Justo, Avicennasis, Pchelolo, Ixocactus, Wong128hk, mys_721tx, El_Grafo, Dinoguy1000, jayvdb, Dalba, Masti, Alchimista, Steinsplitter, Rxy, Keegan, Legoktm, Tgr ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T78276: allpages filterlanglinks DBQueryError
Anomie added a project: mariadb-optimizer-bug. Restricted Application added a project: Pywikibot. TASK DETAIL https://phabricator.wikimedia.org/T78276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: gerritbot, Anomie, jayvdb, Aklapper, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, WDoranWMF, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Marostegui, Sethakill, WSH1906, Lewizho99, Minhnv-2809, Mdupont, JJMC89, Maathavan, dg711, Dvorapa, Altostratus, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T220999: Slow query "ApiQueryLogEvents::execute" after actor rollout
Anomie added a project: mariadb-optimizer-bug. TASK DETAIL https://phabricator.wikimedia.org/T220999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Dalba, Dvorapa, pywikibot-bugs-list, hashar, Xqt, jcrespo, Marostegui, Aklapper, EvanProdromou, tstarling, Tgr, Anomie, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, WDoranWMF, Meekrab2012, joker88john, DannyS712, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Sethakill, WSH1906, Lewizho99, Minhnv-2809, Maathavan, dg711, jayvdb, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T75370: deletedrevs deprecated
Anomie added a project: Core Platform Team Workboards (Clinic Duty Team). TASK DETAIL https://phabricator.wikimedia.org/T75370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Anomie Cc: Anomie, IoannisKydonis, AndyTechGuy, Dufferzafar, Aklapper, jayvdb, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, Pchelolo, mys_721tx, mobrovac, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie moved this task from Needs details or plan to Needs Code on the MediaWiki-API board. Anomie added a comment. So probably the most consistent thing to do here is to pass it through `Title::newFromText( $value, NS_USER )` (then get the IP back out with `->getText()`), like `User::getCanonicalName()` does for registered user names, before running the regexes to determine if it's an IP. TASK DETAIL https://phabricator.wikimedia.org/T232672 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Xqt, Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Amorymeltzer, Sethakill, dg711, Agabi10, Pchelolo, jayvdb, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters
Anomie renamed this task from "API error baduser_rcuser in pywikibot (not for all IP addresses)" to "API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters". TASK DETAIL https://phabricator.wikimedia.org/T232672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T232672: API error baduser_rcuser in pywikibot (not for all IP addresses)
Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-API board. Anomie added a comment. > kizule@kizule:~/development/pywikibot-core$ python3 pwb.py patrol -usercontribs:'213.149.159.237' -ask The value you're passing there is not just an IP address. It's an IP address prefixed with U+200E (LEFT-TO-RIGHT MARK), which makes it an invalid value. The Unicode bidi override characters (U+200E, U+200F, and U+202A–U+202E) are stripped from actual usernames and other page titles, but the API parameter validation does not strip them from IP addresses when validating those. At a glance it looks like other code in MediaWiki that handles IP usernames specially also generally doesn't strip these characters. The API validation code for IP usernames also doesn't trim leading or trailing whitespace, as is done for page titles. I'm undecided whether this code should be updated to do that stripping, or if the non-stripping is acceptable behavior. TASK DETAIL https://phabricator.wikimedia.org/T232672 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Zoranzoki21, pywikibot-bugs-list, WDoranWMF, holger.knust, EvanProdromou, Viztor, DannyS712, Wenyi, Amorymeltzer, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Dvorapa, Agabi10, Altostratus, Avicennasis, Pchelolo, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T137805: API action=login is deprecated
Anomie added a comment. What do you do now, without BotPasswords? Have your test account have the same password everywhere? TASK DETAIL https://phabricator.wikimedia.org/T137805 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: zhuyifei1999, XZise, Paucabot, Zoranzoki21, Pablo-WMDE, Prod, Framawiki, Dvorapa, protonotarios, Hasenlaeufer, Masti, XXN, Jnanaranjan_sahu, Anomie, MaxBioHazard, Huji, Glavkos, Vladis13, MZMcBride, DrTrigon, Aschroet, MarcoAurelio, Jogo.obb, valhallasw, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T221543: Travis test fails for wikidata:wikidata site
Anomie closed this task as a duplicate of T220999: Slow query ApiQueryLogEvents::execute after actor rollout. TASK DETAIL https://phabricator.wikimedia.org/T221543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: hashar, Aklapper, pywikibot-bugs-list, Dvorapa, Dalba, Xqt, WDoranWMF, alaa_wmde, DannyS712, Nandana, Wenyi, Lahi, Gq86, GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Sethakill, Mdupont, JJMC89, dg711, _jensen, rosalieper, Avicennasis, mys_721tx, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Anomie, Masti, Alchimista, Mbch331, Rxy, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Merged] T220999: Slow query "ApiQueryLogEvents::execute" after actor rollout
Anomie merged a task: T221543: Travis test fails for wikidata:wikidata site. Anomie added subscribers: Xqt, hashar, pywikibot-bugs-list, Dvorapa, Dalba. TASK DETAIL https://phabricator.wikimedia.org/T220999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Dalba, Dvorapa, pywikibot-bugs-list, hashar, Xqt, jcrespo, Marostegui, Aklapper, EvanProdromou, tstarling, Tgr, Anomie, WDoranWMF, joker88john, CucyNoiD, NebulousIris, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Sethakill, WSH1906, Lewizho99, Minhnv-2809, Maathavan, dg711, jayvdb, Jay8g, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T221543: Travis test fails for wikidata:wikidata site
Anomie added a comment. From the MediaWiki perspective, this is a duplicate of T220999: Slow query "ApiQueryLogEvents::execute" after actor rollout <https://phabricator.wikimedia.org/T220999>, which should roll out with the train next week unless someone backports it on Monday. I'm going to close this as a duplicate since it doesn't seem there's anything for you to do in pywikibot about it, but feel free to reopen if you disagree. TASK DETAIL https://phabricator.wikimedia.org/T221543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, hashar, Aklapper, pywikibot-bugs-list, Dvorapa, Dalba, Xqt, WDoranWMF, alaa_wmde, DannyS712, Nandana, Wenyi, Lahi, Gq86, GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Sethakill, Mdupont, JJMC89, dg711, _jensen, rosalieper, Avicennasis, mys_721tx, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Masti, Alchimista, Mbch331, Rxy, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T130911: redirect.py fails for RuntimeError
Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-API
board.
Anomie added a comment.
> @Dvorapa added a project: #MediaWiki-API
<https://phabricator.wikimedia.org/tag/mediawiki-api/>.
What exactly do you think is a bug in the API here? Please supply the
queries, the current output, and what you think is wrong with it.
In T130911#4984702 <https://phabricator.wikimedia.org/T130911#4984702>, @Xqt
wrote:
> and again:
>
> C:\pwb\GIT\core>pwb.py redirect.py do -simulate -lang:pa
> Retrieving double redirect special page...
> Retrieving 25 pages from wikipedia:pa.
> [...]
> ERROR: RuntimeError: getredirtarget: No 'redirects' found for page
ਫਾਟਕ:ਇਤਿਹਾਸ.
>
I note that
https://pa.wikipedia.org/w/api.php?action=query=querypage=DoubleRedirects=max=info=2
currently returns, in part,
{
"pageid": 68990,
"ns": 0,
"title": "ਫਾਟਕ:ਇਤਿਹਾਸ",
"contentmodel": "wikitext",
"pagelanguage": "pa",
"pagelanguagehtmlcode": "pa",
"pagelanguagedir": "ltr",
"touched": "2016-03-25T19:42:10Z",
"lastrevid": 291775,
"length": 89,
"redirect": true,
"new": true
},
which is one of those situations where there's a page that's unreachable by
title, as "ਫਾਟਕ:ਇਤਿਹਾਸ" should be in namespace 100. See
https://pa.wikipedia.org/w/api.php?action=query=revisions=content=68990|73388=2:
"query": {
"pages": [
{
"pageid": 68990,
"ns": 0,
"title": "ਫਾਟਕ:ਇਤਿਹਾਸ",
"revisions": [
{
"contentformat": "text/x-wiki",
"contentmodel": "wikitext",
"content": "#ਰੀਡਿਰੈਕਟ [[ਵਿਕੀਪੀਡੀਆ:ਫਾਟਕ:ਇਤਿਹਾਸ]]"
}
]
},
{
"pageid": 73388,
"ns": 100,
"title": "ਫਾਟਕ:ਇਤਿਹਾਸ",
"revisions": [
{
"contentformat": "text/x-wiki",
"contentmodel": "wikitext",
"content": ""
}
]
}
]
}
TASK DETAIL
https://phabricator.wikimedia.org/T130911
WORKBOARD
https://phabricator.wikimedia.org/project/board/200/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt, Anomie
Cc: Anomie, Dvorapa, jayvdb, gerritbot, Aklapper, Xqt, pywikibot-bugs-list,
CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22,
Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan,
Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Sethakill,
Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Avicennasis, mys_721tx, Dalba,
Masti, Alchimista, Jackmcbarn, Rxy, Krenair, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212356: API should not return an error on batched deletions
Anomie added a comment. Note the fix should be deployed to Wikimedia wikis with 1.33.0-wmf.12, see https://www.mediawiki.org/wiki/MediaWiki_1.33/Roadmap for a schedule.TASK DETAILhttps://phabricator.wikimedia.org/T212356EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: BPirkle, gerritbot, Anomie, Zoranzoki21, pywikibot-bugs-list, MarcoAurelio, Aklapper, Wenyi, Urfiner, Mahveotm, RazeSoldier, Jayprakash12345, Jrbranaa, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, MGChecker, Wong128hk, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T212356: API should not return an error on batched deletions
Anomie added projects: MW-1.32-release, Regression.Anomie added a comment. Marking as a regression and blocking the 1.32 release.TASK DETAILhttps://phabricator.wikimedia.org/T212356EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Zoranzoki21, pywikibot-bugs-list, MarcoAurelio, Aklapper, Wenyi, Urfiner, Mahveotm, RazeSoldier, Jayprakash12345, Jrbranaa, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, MGChecker, Wong128hk, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T210657: Handle different Action API uncaught exception error codes in Pywikibot
Anomie added a comment. In T210657#4784221, @Xqt wrote: Is that really right? Can’t see any changes for the code but it was announced that it will be just “internal_api_error” The code is not changing yet in 1.33.0-wmf.8, so we can avoid breaking your existing code that's looking for "internal_api_error_". It will change in the future. You should update your code to recognize both "internal_api_error" and "internal_api_error_ExceptionClass" as internal errors, and in either case when the 'errorclass' field is present you should prefer that to the suffix of the code. In T210657#4784324, @Xqt wrote: @Anomie As I can see there is a new key "errors". Is it intended to have these multiple errors for all api errors or for this internal_api_error only. (In that case the whole Request.submit() method of pwb must be rewritten. You get an "errors" array rather than a single "error" object if you supply the errorformat parameter with any value except bc. That will affect all API errors. It's also how you can get errors in languages other than English, see T37074.TASK DETAILhttps://phabricator.wikimedia.org/T210657EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Xqt, Aklapper, pywikibot-bugs-list, Multichill, Anomie, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T210606: retry-after value retrieved from http header looks wrong
Anomie added a comment. Getting a better estimate for Retry-After is T172293. This doesn't seem to really be a bug other than that existing feature request.TASK DETAILhttps://phabricator.wikimedia.org/T210606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Aklapper, pywikibot-bugs-list, Anomie, Multichill, valhallasw, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T205883: site_tests.TestSiteGenerators.test_protectedpages_create fail for en:wiki
Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-API board.Anomie added a comment. I'm not sure there's really an API bug here. Pages that exist aren't supposed to be able to be create-protected, and create-protection on such pages doesn't do anything, so the API doesn't check for them when displaying protections of pages that exist. I note the web UI doesn't display these create-protections either.TASK DETAILhttps://phabricator.wikimedia.org/T205883WORKBOARDhttps://phabricator.wikimedia.org/project/board/200/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Dvorapa, gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Wenyi, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Krenair, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T198721: SearchTestCase.test_search is failing on test.wikipedia.org
Anomie added a comment. Ah, that explains it. They apparently forgot to run maintenance/namespaceDupes.php after adding the namespace.TASK DETAILhttps://phabricator.wikimedia.org/T198721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: JJMC89, MusikAnimal, Anomie, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T198721: SearchTestCase.test_search is failing on test.wikipedia.org
Anomie added a comment. The page "Draft:Testing AFCH" in the "Draft talk" namespace does not exist. But that's not what's being returned here. The page "Draft talk:Draft:Testing AFCH" in the main namespace does exist, presumably due to some bug around July 2015 when it was created. You can see it via the web UI by using the page ID to access it: https://test.wikipedia.org/wiki/?curid=82098.TASK DETAILhttps://phabricator.wikimedia.org/T198721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T194950: Include Wikibase dispatch lag in API "maxlag" enforcing
Anomie added a comment. In T194950#4322078, @Magnus wrote: maxlag does not appear to be documented for the query action... That's because it's a parameter to the "main" module, not the query action.TASK DETAILhttps://phabricator.wikimedia.org/T194950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: Aklapper, gerritbot, pywikibot-bugs-list, ValterVB, Lea_Lacroix_WMDE, Legoktm, Addshore, MisterSynergy, Magnus, daniel, Anomie, Sjoerddebruin, Lydia_Pintscher, Multichill, hoo, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Ricordisamoa, Mbch331___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T195992: API claims query is over 12mb but it is not
Anomie added a comment. Looks like a duplicate of T101400: This result was truncated because it would otherwise be larger than the limit of 12,582,912 bytes .TASK DETAILhttps://phabricator.wikimedia.org/T195992EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Mpaa, Dvorapa, zhuyifei1999, Aklapper, revi, pywikibot-bugs-list, Sethakill, dg711, jayvdb, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T194233: page is a redirect but not a redirect
Anomie added a comment. In T194233#4199135, @zhuyifei1999 wrote: @Anomie While testing how batchcomplete interacts with pageid, I tested the same query for File:Example.jpg on commons, which contains many redirects and multiple file revisions, but I got batchcomplete with only a single imageinfo for each file name: https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=""> I was expecting a continue for the imageinfo query. Is it expected that there is no continuation? ... Ok, imageinfo is weirder than I thought. If there is one page produced by the generator (or specified directly), it continues. If there is more than one, it stops at the limit.TASK DETAILhttps://phabricator.wikimedia.org/T194233EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, AnomieCc: Anomie, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, JJMC89, Magul, Tbscho, MayS, Sethakill, Mdupont, dg711, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T194233: page is a redirect but not a redirect
Anomie added a comment. In T194233#4198809, @zhuyifei1999 wrote: Merging until 'batchcomplete' is not realistic if a certain generator yields too many results No, batchcomplete is specifically designed to do the right thing with generators. If you were to complain about prop=transcludedin rather than generator=transcludedin, you might have a point.TASK DETAILhttps://phabricator.wikimedia.org/T194233EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, AnomieCc: Anomie, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, JJMC89, Magul, Tbscho, MayS, Sethakill, Mdupont, dg711, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T194233: page is a redirect but not a redirect
Anomie added a comment. prop=imageinfo is showing the data for the image associated with File:1979-80 National Football League (Ireland) final.jpg. MediaWiki's logic for finding "the image associated with a title" follows redirects behinds the scenes. So what happens here at the API level is: The first query returns the data for info, categoryinfo, and userinfo, and also the imageinfo for the 2017-02-07T20:14:37Z upload. The second query returns only imageinfo for the 2016-08-23T10:52:33Z upload. No info, no categoryinfo, and no userinfo. The intention is that the results of the two queries should be merged together for the client to have the full picture of the information available for the page. Pywikibot is instead incorrectly thinking that the second query alone gives some sort of full picture. It doesn't help that the imageinfo module is crufty and needs a rewrite to behave a bit more sanely, i.e. to have "current file version for a set of pages" and "all file versions for one page" modes like prop=revisions does. The most correct thing for pywikibot's "backlinks" generator to do is to keep continuing the query and merging the result sets until it gets the batchcomplete flag in the response.TASK DETAILhttps://phabricator.wikimedia.org/T194233EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, AnomieCc: Anomie, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, JJMC89, Magul, Tbscho, MayS, Sethakill, Mdupont, dg711, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T154324: ApiLogin returns failure on re-login by same user
Anomie added a comment. In T154324#4163280, @MarcoAurelio wrote: In T154324#2907447, @Anomie wrote: Is there a reason you need to do this? I find myself sometimes in need to use the delete.py script using my sysop account, and I keep logged it on the web sesion because I want to check what I am doing in real-time. Running delete.py while being logged in in your browser too is not the issue here. The issue here would be if delete.py is trying to log in when delete.py itself is already logged in.TASK DETAILhttps://phabricator.wikimedia.org/T154324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: pywikibot-bugs-list, Framawiki, Dalba, MarcoAurelio, valerio.bozzolan, Krenair, Anomie, Aklapper, RobinHood70, Sethakill, dg711, jayvdb, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T186274: Enable 2FA normal login
Anomie added a comment. If you fail 3 logins on a WMF wiki, I believe it'll send a captcha for additional attempts from that IP or username. If you set up your own wiki to test things on, you can configure things however you like.TASK DETAILhttps://phabricator.wikimedia.org/T186274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Dalba, Masti, Aklapper, pywikibot-bugs-list, Petrb, Framawiki, Anomie, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T173293: pagegenerator -unconnectedpages skips items older than 3 years
Anomie added a comment. ApiQueryQueryPage does not support additional parameters that a random query page might use. That includes the "namespace" parameter being used there. If you're willing to ignore an "Unrecognized parameter: namespace." warning, it does seem to currently work to pass the parameter to the API query anyway (example). I can't promise that will continue working, though, or that if it breaks that it will get fixed.TASK DETAILhttps://phabricator.wikimedia.org/T173293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Mpaa, Aklapper, JAnD, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T171416: send_email returns False when successful
Anomie closed this task as "Resolved".Anomie added a comment. The fix should be deployed with 1.30.0-wmf.11, see https://www.mediawiki.org/wiki/MediaWiki_1.30/Roadmap for the schedule. If it's needed faster, feel free to submit it for SWAT.TASK DETAILhttps://phabricator.wikimedia.org/T171416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Dalba, Anomie, Aklapper, pywikibot-bugs-list, JJMC89, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Sethakill, Lewizho99, Mdupont, Maathavan, dg711, Avicennasis, jayvdb, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T171416: send_email returns False when successful
Anomie claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T171416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Dalba, Anomie, Aklapper, pywikibot-bugs-list, JJMC89, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Sethakill, Lewizho99, Mdupont, Maathavan, dg711, Avicennasis, jayvdb, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T171416: send_email returns False when successful
Anomie added a project: MediaWiki-API.Anomie added a comment. It's a bug in the API, due to the fact that PHP's ternary operator is stupidly left-associative.TASK DETAILhttps://phabricator.wikimedia.org/T171416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Dalba, Anomie, Aklapper, pywikibot-bugs-list, JJMC89, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Sethakill, Lewizho99, Mdupont, Maathavan, dg711, Avicennasis, jayvdb, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T147543: Use assertuser in Pywikibot
Anomie added a comment. To clarify: Both assert=user and assertuser=NAME will prevent logged-out edits. assertuser=NAME will also prevent edits if somehow logged in as any user other than NAME, which is useful in UI _javascript_ in case the user re-logs-in to a different account in a different browser tab in the same session, but probably is not really necessary for pywikibot.TASK DETAILhttps://phabricator.wikimedia.org/T147543EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Xqt, Aklapper, jayvdb, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T164816: Breaking change might occur with mw 1.30
Anomie added a comment. Off the top of my head, I can think of two ways pywikibot might be affected here: It's possible a script might break when ordering by timestamp rather than revid, in the cases where the ordering differs thanks to imports or the like. The revid supplied now must exist, if it doesn't it will raise an error. It's ok if the revid is deleted, even if the user lacks rights to see deleted revision information, or if it belongs to a different page. Whether either of those will actually be a problem for you, I have no idea.TASK DETAILhttps://phabricator.wikimedia.org/T164816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Mpaa, Framawiki, jayvdb, Anomie, Aklapper, Xqt, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T153903: Pywikibot cannot log into a private wiki
Anomie added a comment.
If you're asking me, this isn't on my priority list. The code change itself is #Easy, just add
public function isReadMode() {
// Nothing sensitive here
return false;
}
to ApiQueryUserInfo. The part that's work is running that past Security to verify that the comment is correct (because Security is typically busy with all sorts of stuff, so getting their attention can be a chore).
Or a pywikibot dev could remove the meta=userinfo from the token query, as zhuyifei1999 mentioned.TASK DETAILhttps://phabricator.wikimedia.org/T153903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: MarcoAurelio, Anomie, zhuyifei1999, pywikibot-bugs-list, maiden_taiwan, Aklapper, Magul, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T41492: prop=info doesn't behave consistently when given a Special Page, vs when given a non special page which redirects to a special page (in comparison to an
Anomie closed this task as "Resolved".Anomie claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T41492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Aklapper, Nemo_bis, pywikibot-bugs-list, jayvdb, Magioladitis, Catrope, wikibugs-l-list, Reedy, Adik2382, SwiftyPeep, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Sethakill, Lewizho99, Mdupont, JJMC89, Maathavan, dg711, Grind24, Avicennasis, Reguyla, Sn1per, Xqt, Dinoguy1000, Dalba, Anomie, Masti, Alchimista, Jackmcbarn, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T159523: PWB cannot handle bot tokens returned from action=login
Anomie added a comment.
FYI, the warning you report ("Fetching a token via action="" is deprecated. Use action="" instead.") doesn't actually have anything to do with BotPasswords.
I note that site is serving a "login_session" cookie with the 'secure' flag set even when accessed via HTTP, which they seem to like redirecting non-API requests to. That's not going to work, and would give the "infinite NeedToken" result you report. You may want to double check that you're accessing the API at that site via HTTPS.TASK DETAILhttps://phabricator.wikimedia.org/T159523EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Aklapper, Pywikibugs, Mollgear, pywikibot-bugs-list, Magul, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T152598: Check Pywikibot for Mediawiki api Error code and other message reporting changes
Anomie added a comment. It adds another warning when a deprecation warning is already being output, so if you're trying to ignore all deprecation warnings you'd have to ignore this warning too. I hope you're not hiding deprecation warnings, though. It also changes the "See URL for usage." text that's included in the response when there's an error. If for some very strange reason you're trying to match that text, you'd probably have to adjust for that too.TASK DETAILhttps://phabricator.wikimedia.org/T152598EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: matej_suchanek, zhuyifei1999, Magul, Lokal_Profil, jayvdb, Xqt, Aklapper, Multichill, Anomie, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T153903: Pywikibot cannot log into a private wiki
Anomie added a comment. MediaWiki API provide some sort of dummy output Not going to happen. But there's probably no reason that meta=userinfo should require the 'read' right, I don't see anything in there that seems like it needs that right. If someone wants to go that route, you'd run the idea past Security (in case I'm missing something) and then patch ApiQueryUserInfo.php to return false for isReadMode().TASK DETAILhttps://phabricator.wikimedia.org/T153903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, zhuyifei1999, pywikibot-bugs-list, maiden_taiwan, Aklapper, Magul, Tbscho, MayS, Sethakill, Mdupont, JJMC89, dg711, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T156596: API warning (query): Unrecognized value for parameter "meta": wikibase.
Anomie added a comment. The error Unrecognized value for parameter "meta": wikibase. indicates that the bot is including meta=wikibase in the request to action=""> but the wiki does not have a meta module by that name. You can check the modules available for the meta parameter to action=""> on a wiki using action="">, or programmatically using action="">.TASK DETAILhttps://phabricator.wikimedia.org/T156596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Aklapper, MarcoAurelio, pywikibot-bugs-list, Sethakill, dg711, jayvdb, Legoktm___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T155293: -file and -search does not work together since yesterday
Anomie added a comment. As I said, if you believe it's in the API then show me API queries that are not doing what they're supposed to be doing rather than quoting some random pywikibot script. Without that there's nothing I can do here.TASK DETAILhttps://phabricator.wikimedia.org/T155293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Urbanecm, TerraCodes, Jay8g, Aklapper, pywikibot-bugs-list, Dvorapa, Magul, EBjune, Tbscho, srishakatux, MayS, mschwarzer, Avner, Mdupont, JJMC89, debt, Gehel, Avicennasis, FloNight, Malyacko, Deskana, Gryllida, jayvdb, Dalba, Masti, Alchimista, Rfarrand, Rxy, jeremyb, Qgil___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T155293: -file and -search does not work together since yesterday
Anomie removed a project: MediaWiki-API.Anomie added a comment. There does not seem to be anything here for #MediaWiki-API. If you identify actual queries to api.php that are not behaving as expected due to errors in the API, rather than vague issues that might be in pywikibot or CirrusSearch, feel free to re-add. As it stands, this report does not identify any API queries at all.TASK DETAILhttps://phabricator.wikimedia.org/T155293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, Urbanecm, TerraCodes, Jay8g, Aklapper, pywikibot-bugs-list, Dvorapa, Magul, EBjune, Tbscho, srishakatux, MayS, mschwarzer, Avner, Mdupont, JJMC89, debt, Gehel, Avicennasis, FloNight, Malyacko, Deskana, Gryllida, jayvdb, Dalba, Masti, Alchimista, Rfarrand, Rxy, jeremyb, Qgil___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T151369: test_search_where is failing on Travis
Anomie closed subtask T154663: Some of the search results sometimes don't show up as "Invalid". TASK DETAILhttps://phabricator.wikimedia.org/T151369EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, AnomieCc: Lokal_Profil, Xqt, jayvdb, Dalba, gerritbot, pywikibot-bugs-list, Aklapper, Magul, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T137805: API action=login is deprecated
Anomie added a comment. In T137805#2778915, @MaxBioHazard wrote: When the old login method will be turned off? There are currently no plans to turn it off. However, if something makes the "main account" login process require anything beyond the submission of a username and password field, action="" will just fail. That's why it's deprecated outside of use with BotPasswords, which themselves were created specifically so there would be a way for action="" to reliably keep working for bots instead of requiring that all bots convert to using OAuth. For example, if your password needs to be reset, Special:UserLogin will return a second page asking you to change your password before actually logging you in and action="" will return a response with a similar request, while action="" will just fail. For another example, if you enable two-factor authentication[1] on the bot's account, Special:UserLogin will return a second page asking for the second factor and action="" will return a response with a similar request, while action="" will just fail. For still another example, if failed login attempts from your IP cause a captcha to be displayed on Special:UserLogin, the process for using action="" will signal that and will indicate how to submit the captcha answer, while action="" will not be able to signal it and attempting to log in will just fail because no captcha answer can be supplied. [1] 2FA is technically deployed already, but needs a special user right to be able to turn it on. I guess a wider deployment is stuck on T100375 and its subtasks. In T137805#2754035, @Xqt wrote: There is another message coming in front of that above: WARNING: API warning (login): Fetching a token via action="" is deprecated. Use action="" instead. That's an unrelated warning. Long ago, you could log in with action="" by just providing a username and password. Then it was realized this was a CSRF vulnerability, so now you have to provide a username, password, and a CSRF token to be able to log in. The only way to get this token was to hit action="" without providing a token, in which case you'd get a NeedToken response with the necessary token. Some time later, all token fetching was consolidated into action="" and other methods of fetching a token were deprecated. Again, there are no plans to actually remove the ability to fetch the login token by hitting action="" and getting a NeedToken response any time soon. Someday it might be removed, if the logs behind Special:ApiFeatureUsage indicate that reasonably close to no one is hitting this warning anymore. But it has been hit 85914 times just in the past 24 hours, so that day doesn't seem like it'll be coming any time soon.TASK DETAILhttps://phabricator.wikimedia.org/T137805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie, MaxBioHazard, Huji, Glavkos, Vladis13, MZMcBride, DrTrigon, Udo_T, Aschroet, MarcoAurelio, Jogo.obb, valhallasw, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T142155: Bot can't login. keyError in GetCookie
Anomie added a comment. In T142155#2530987, @Tgr wrote: I'll leave it to @Anomie to decide whether two months is an acceptable delay (once he is back from vacation). No, it's not acceptable. I already gave them seven months as part of the documented deprecation process for the API. But I suppose we may have to accept it anyway. (Not back from vacation, just glancing through email)TASK DETAILhttps://phabricator.wikimedia.org/T142155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Legoktm, AnomieCc: revi, Paladox, Aschroet, zhuyifei1999, Stashbot, gerritbot, DrTrigon, Betacommand, Lokal_Profil, Tgr, Udo_T, Legoktm, JJMC89, Pywikibot-Announce, Yamaha5, jayvdb, Ladsgroup, Xqt, valhallasw, Multichill, Anomie, CodeCat, TerraCodes, Luke081515, He7d3r, Basilicofresco, Jagwar, MarcoAurelio, Dalba, Aklapper, Joutbis, pywikibot-bugs-list, Mdupont___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T67149: Use page properties to find if a category is hidden
Anomie closed subtask T50824: Creating a page in category namespace does not insert row in category table. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T67149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mpaa, AnomieCc: Ricordisamoa, pywikibot-bugs-list, Multichill, Mpaa, Mdupont, jayvdb___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T130915: BrokenRedirect page generator wrongly gives 'redirects' property
Anomie added a comment. In https://phabricator.wikimedia.org/T130915#2154997, @Xqt wrote: > @Anomie Why have these pages a namespace 105 property if this ns does no longer exist? As far as MediaWiki is concerned, a namespace is just a semi-arbitrary number and any number "exists". But if the namespace doesn't have any name configured, various things will break (e.g. pages in the namespace won't be finable in many usual ways, and trying to construct a title for these pages will give nonsensical results as seen here) due to lack of a name mapping for the namespace number. It's similar to the reverse problem when a new namespace is created (or when bugs like https://phabricator.wikimedia.org/T87645 happen), a page exists in the default namespace but can't be accessed in the usual ways because its title now refers to a page in a different namespace. TASK DETAIL https://phabricator.wikimedia.org/T130915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, Sethakill, dg711, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T130915: BrokenRedirect page generator wrongly gives 'redirects' property
Anomie closed this task as "Invalid". Anomie added a comment. I note that particular page actually //is// a redirect. But it's this page <https://ar.wikipedia.org/w/index.php?curid=2677629> in namespace number 105, not the page in namespace 0 <https://ar.wikipedia.org/wiki/11_%D9%81%D8%A8%D8%B1%D8%A7%D9%8A%D8%B1> that you get by attempting to go to the listed title. This looks like it's left over from T98896: Delete a namespace and replace it by the main namespace on ar.wikipedia <https://phabricator.wikimedia.org/T98896>, redirects were left and now have no valid title. You probably won't be able to delete these pages via the web UI, but API action=delete using the `pageid` parameter should be able to do it without trouble. A full list of these pages is below. P2818 List of pages on arwiki in namespaces 104 and 105 <https://phabricator.wikimedia.org/P2818> TASK DETAIL https://phabricator.wikimedia.org/T130915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, dg711, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T129281: Test test_content_format failing due to new member 'application/vnd.php.serialized' on Wikibase repos
Anomie added a comment. You're assuming that it's incorrect for it to be exposed. That is far from evident here, it could well be that the bug was that it wasn't being listed before when it should have been, and something recently accidentally fixed that. TASK DETAIL https://phabricator.wikimedia.org/T129281 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Bene, Aklapper, jayvdb, pywikibot-bugs-list, dg711, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Mbch331, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T130099: pdc-wiki not reachable via API
Anomie changed Security from None to Software security bug. TASK DETAIL https://phabricator.wikimedia.org/T130099 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: valhallasw, Anomie, Aklapper, Xqt, pywikibot-bugs-list, dg711, jayvdb, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T130099: pdc-wiki not reachable via API
Anomie added a comment. In https://phabricator.wikimedia.org/T130099#2128902, @Xqt wrote: > >>> pdc.content[:50] >u'\n\n >>> > It would be nice for that to be expanded upon. There might be useful information in there as to what exactly the error was. TASK DETAIL https://phabricator.wikimedia.org/T130099 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: valhallasw, Anomie, Aklapper, Xqt, pywikibot-bugs-list, dg711, jayvdb, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T130099: pdc-wiki not reachable via API
Anomie added a comment.
To start, it would help if you would provide the actual URL being hit (and
POST data, if applicable) and the actual response received. Accessing
pdc.wikipedia.org seems to work fine when I try it:
$ curl
'https://pdc.wikipedia.org/w/api.php?action=query=userinfo=json'
{"batchcomplete":"","query":{"userinfo":{"id":0,"name":"XX.XX.XX.XX","anon":""}}}
TASK DETAIL
https://phabricator.wikimedia.org/T130099
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: Anomie, Aklapper, Xqt, pywikibot-bugs-list, dg711, jayvdb, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T130099: pdc-wiki not reachable via API
Anomie moved this task to Needs details or plan on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T130099 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, Xqt, pywikibot-bugs-list, dg711, jayvdb, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T129281: Test test_content_format failing due to new member 'application/vnd.php.serialized' on Wikibase repos
Anomie added a comment. The thing being complained about here is the list of accepted values to the `contentformats` parameter to `action=edit`. This list of possible values is fetched from `ContentHandler::getAllContentFormats()`, which queries every handler in `$wgContentHandlers` for `->getSupportedFormats()`, and Wikibase's handlers for "wikibase-item" (`Wikibase\Repo\Content\ItemHandler`) and "wikibase-property" (`Wikibase\Repo\Content\PropertyHandler`) are currently returning "application/vnd.php.serialized" (the value of the constant `CONTENT_FORMAT_SERIALIZED`) as one of their supported formats. I have no idea why that sequence of events might not have been happening in the same way before March 9. TASK DETAIL https://phabricator.wikimedia.org/T129281 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Bene, Aklapper, jayvdb, pywikibot-bugs-list, dg711, Ricordisamoa, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T129281: Test test_content_format failing due to new member 'application/vnd.php.serialized' on Wikibase repos
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T129281 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Bene, Aklapper, jayvdb, pywikibot-bugs-list, dg711, Ricordisamoa, Anomie, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T119316: SearchPageGenerator returns non-existing pages when the search API returns cross-wiki results
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T119316 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, jayvdb, Aklapper, StudiesWorld, binbot, pywikibot-bugs-list, Tgr, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T119316: SearchPageGenerator returns non-existing pages when the search API returns cross-wiki results
Anomie added a subscriber: Anomie. Anomie added a comment. In https://phabricator.wikimedia.org/T119316#1865521, @jayvdb wrote: > `SearchPageGenerator` uses API search > <https://www.mediawiki.org/wiki/API:Search>. > > I see File pages from Commons appearing when I search for "file:...", but not > without file: > > https://en.wikipedia.org/w/api.php?action=query=search=file:Campos%20de%20Cari%C3%B1ena,%20Espa%C3%B1a > > https://en.wikipedia.org/w/api.php?action=query=search=Campos%20de%20Cari%C3%B1ena,%20Espa%C3%B1a > > Is "file:..." required to trigger this behaviour, or can it happen other ways? Add `gsrnamespace=6`, or a list of namespaces including 6. > IMO they should never have been included in the API results by default; the > caller should have to explicitly request that the API search module includes > pages which do not (and never have) existed on the wiki. action=search is intended to work equivalently to Special:Search. And the search //result// does exist on the wiki, thanks to the way shared files work. > Any idea what release the API search module started including non-local file > pages by default? Probably due to the CirrusSearch extension. TASK DETAIL https://phabricator.wikimedia.org/T119316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, jayvdb, Aklapper, StudiesWorld, binbot, pywikibot-bugs-list, Tgr, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T114824: test_allpages_pagesize and test_allpages_protection failures
Anomie added a subscriber: Anomie. Anomie closed this task as "Resolved". Anomie claimed this task. Anomie added a comment. It would be helpful if your test runner were to include more timestamps. Since a later timestamp in the log (line 2120) is 2015-10-05 23:39:33 this is very likely https://wikitech.wikimedia.org/wiki/Incident_documentation/20151005-MediaWiki, so I'm going to resolve this as being due to that. BTW, somewhat earlier in your log I see (line 1685) test_allpages_pagesize (tests.site_tests.TestSiteGenerators) ... WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. WARNING: Waiting 5 seconds before retrying. WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. WARNING: Waiting 10 seconds before retrying. ERROR: Traceback (most recent call last): File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/data/api.py", line 1941, in submit body=body, headers=headers) File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/tools/__init__.py", line 1327, in wrapper return obj(*__args, **__kw) File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/comms/http.py", line 247, in request r = fetch(baseuri, method, body, headers, **kwargs) File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/comms/http.py", line 402, in fetch error_handling_callback(request) File "/home/travis/build/wikimedia/pywikibot-core/pywikibot/comms/http.py", line 320, in error_handling_callback raise request.data ReadTimeout: HTTPSConnectionPool(host='en.wikipedia.org', port=443): Read timed out. (read timeout=30) ERROR 45.561s test_allpages_protection (tests.site_tests.TestSiteGenerators) ... WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. Set gaplimit = ['2'] WARNING: Waiting 5 seconds before retrying. WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. Set gaplimit = ['1'] WARNING: Waiting 10 seconds before retrying. WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. Set gaplimit = ['0'] ERROR 15.439s test_allusers (tests.site_tests.TestSiteGenerators) Test the site.allusers() method. ... WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. Set aulimit = ['5'] WARNING: Waiting 5 seconds before retrying. WARNING: Http response status 500 WARNING: Non-JSON response received from server wikipedia:en; the server may be down. Set aulimit = ['2'] WARNING: Waiting 10 seconds before retrying. 15.149s ok HTTP 500 errors from the API are usually a PHP fatal or an error from some other layer (e.g. varnish). The fact that the next test, test_allusers (tests.site_tests.TestSiteGenerators), was also failing with the same symptoms and then suddenly resolved also points to a non-API cause. TASK DETAIL https://phabricator.wikimedia.org/T114824 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Aklapper, pywikibot-bugs-list, jayvdb, Luke081515, Jay8g, Krenair, Legoktm, greg ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T112416: Unable to continue/finish uploading chunked file
Anomie closed this task as "Invalid". Anomie claimed this task. Anomie added a comment. See explanation of what's going on here in https://phabricator.wikimedia.org/T112405#1637544. The short version is that your first chunk's upload isn't actually succeeding. TASK DETAIL https://phabricator.wikimedia.org/T112416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, matmarex, jayvdb, Matanya, Tgr, Aklapper, Steinsplitter, pywikibot-bugs-list, XZise, Bawolff, Fabrice_Florin, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T111479: Timeout in testApiMethods calling mediawiki_messages
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T111479 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, ori, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, GWicke, GPHemsley, Darkdadaah, Krenair, Legoktm ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T111479: Timeout in testApiMethods calling mediawiki_messages
Anomie added subscribers: ori, Anomie.
Anomie added a project: Performance.
Anomie added a comment.
After digging deep into this issue, the slowness for Arabic-language wikis
compared to other languages is because LanguageAr::normalize() is relatively
slow, multiplied by almost 10 calls.
Digging a little deeper, on PHP 5.5.9-1ubuntu4.11 using FastStringSearch
instead of strtr for ReplacementArray is a fair bit faster for the replacement
array from serialized/normalize-ar.ser. I can't compare the speeds in HHVM due
to https://phabricator.wikimedia.org/T101418.
https://phabricator.wikimedia.org/rMWbdb17a79a4bc8ed8bb65936d96e423d272e91583
landing shortly before this task was opened is almost certainly the immediate
cause.
@ori: This sounds like something you'd want to look into. My most-reduced test
cases are:
$data = unserialize( file_get_contents(
"/srv/mediawiki/php-1.26wmf21/serialized/normalize-ar.ser" ) );
$fss = fss_prep_replace( $data );
for ( $i = 0; $i < 1000; $i++ ) {
fss_exec_replace( $fss, "foo" );
}
versus
$data = unserialize( file_get_contents(
"/srv/mediawiki/php-1.26wmf21/serialized/normalize-ar.ser" ) );
for ( $i = 0; $i < 1000; $i++ ) {
strtr( "foo", $data );
}
The former takes about 0.034 seconds while the latter takes 0.422 seconds when
run with `time php5` on mw1017. Increasing the number of iterations to 10
(which is about where the API query here is at), FSS goes to 0.074s while strtr
jumps to over 20s. HHVM's behavior with strtr is in line with Zend PHP's.
The advantage for FSS seems mainly to be due to the ability to do the
`fss_prep_replace()` once where strtr (presumably) has to do the equivalent for
every iteration. Putting that inside the loop brings the FSS version up to
around 18s for 10 iterations.
TASK DETAIL
https://phabricator.wikimedia.org/T111479
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: Anomie, ori, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, GWicke,
GPHemsley, Darkdadaah, Krenair, Legoktm
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T78276: allpages filterlanglinks DBQueryError
Anomie closed this task as Resolved. Anomie added a comment. The part of this bug that isn't https://phabricator.wikimedia.org/T97797 should be fixed now, although if the DB people have anything to add it would still be welcome. TASK DETAIL https://phabricator.wikimedia.org/T78276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: gerritbot, Anomie, jayvdb, Aklapper, pywikibot-bugs-list, aude, Krenair, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T109929: internal_api_error_BadMethodCallException: [xxx] Exception Caught: Call to a member function getNames() on a non-object (NULL)
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T109929 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Joe, Anomie Cc: Matanya, Anomie, Krenair, Aklapper, pywikibot-bugs-list, jayvdb, RobH, mark, faidon, fgiunchedi, Joe, Dzahn, jeremyb, Legoktm, greg, chasemp, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T109929: internal_api_error_BadMethodCallException: [xxx] Exception Caught: Call to a member function getNames() on a non-object (NULL)
Anomie added a comment. @Joe: FYI, you should be able to grep for 'Call to a member function getNames() on a non-object (NULL)' in /a/mw-log/exception.log on fluorine if you need to look for instances of this issue. The log lines include the host, wiki (dbname), and query. TASK DETAIL https://phabricator.wikimedia.org/T109929 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Joe, Anomie Cc: Matanya, Anomie, Krenair, Aklapper, pywikibot-bugs-list, jayvdb, RobH, mark, faidon, fgiunchedi, Joe, Dzahn, jeremyb, Legoktm, greg, chasemp, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T78276: allpages filterlanglinks DBQueryError
Anomie moved this task to Needs Review on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T78276 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: gerritbot, Anomie, jayvdb, Aklapper, pywikibot-bugs-list, aude, Krenair, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T78276: allpages filterlanglinks DBQueryError
Anomie added a project: Database. Anomie added a comment. Wikidata is https://phabricator.wikimedia.org/T97797. As for the rest, I'm seeing some weirdness in the database. The query here is SELECT /*! STRAIGHT_JOIN */ page_namespace,page_title,page_id,page_content_model FROM `page`,`langlinks` WHERE page_namespace = '0' AND (page_id=ll_from) GROUP BY page_title, page_id ORDER BY page_title LIMIT 6 For both arwiki and frwiktionary, it seems to work fine on db1033: +--+-+---+--+++-+-+-+-+ | id | select_type | table | type | possible_keys | key| key_len | ref | rows| Extra | +--+-+---+--+++-+-+-+-+ |1 | SIMPLE | page | ref | PRIMARY,name_title | name_title | 4 | const | 1245075 | Using where | |1 | SIMPLE | langlinks | ref | ll_from| ll_from| 4 | arwiki.page.page_id | 12 | Using index | +--+-+---+--+++-+-+-+-+ On the rest of the s7 DBs (db1028, db1034, db1041, db1039, db1062), the same query has a different plan: +--+-+---+--+++-+-+-+--+ | id | select_type | table | type | possible_keys | key| key_len | ref | rows| Extra | +--+-+---+--+++-+-+-+--+ |1 | SIMPLE | page | ref | PRIMARY,name_title | name_title | 4 | const | 1161329 | Using where; Using temporary; Using filesort | |1 | SIMPLE | langlinks | ref | ll_from| ll_from| 4 | arwiki.page.page_id | 8 | Using index | +--+-+---+--+++-+-+-+--+ Any ideas, database gurus? I also note that changing the query to just `GROUP BY page_title` makes all the DBs here happy, so that's an option to fix it. TASK DETAIL https://phabricator.wikimedia.org/T78276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, jayvdb, Aklapper, pywikibot-bugs-list, aude, Krenair, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T109929: internal_api_error_BadMethodCallException: [xxx] Exception Caught: Call to a member function getNames() on a non-object (NULL)
Anomie added a subscriber: Anomie. Anomie added a comment. I could reproduce this by directing copies of the erroring queries to mw1230, mw1147, and mw1200; it didn't happen with the same queries directed to different hosts. Nothing in the code looks suspect. I tried using some live hacks on those hosts to see what was going on. The $module-getFinalParams() call from ApiParamInfo was returning the params for ApiMain instead of for the module in question for some unknown reason. But as soon as I touched ApiBase.php the bug was suddenly fixed, which makes me suspect some sort of HHVM code-cache corruption. I haven't touched mw1200 in case someone who knows more about HHVM wants to look into it. To test it from terbium, use this command: curl -H Host: www.wikidata.org 'http://mw1200.eqiad.wmnet/w/api.php?action=paraminfomodules=wbremovequalifiers%7Cwbremovereferences%7Cwbsearchentities%7Cwbsetaliases%7Cwbsetclaim%7Cwbsetclaimvalue%7Cwbsetdescription%7Cwbsetlabel%7Cwbsetqualifier%7Cwbsetreference%7Cwbsetsitelink%7Cwbsgetsuggestionsmaxlag=5format=json' TASK DETAIL https://phabricator.wikimedia.org/T109929 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Krenair, Aklapper, pywikibot-bugs-list, jayvdb, Joe, jeremyb, Legoktm, greg, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T108322: prevent modules with broken paraminfo being deployed to production wikis
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T108322 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Luke081515, greg, Aklapper, jayvdb, pywikibot-bugs-list, scfc, hashar, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T108322: prevent modules with broken paraminfo being deployed to production wikis
Anomie added a subscriber: Anomie. Anomie added a comment. Finally, IMO MediaWiki paraminfo API should also better handle when a broken module is loaded to the live wiki, instead of 503 being considered an appropriate API response. The API should be able to assume that extensions don't register unloadable classes as API modules. Violation of that basic assumption appears to have been the cause in both https://phabricator.wikimedia.org/T100775 and https://phabricator.wikimedia.org/T108317. TASK DETAIL https://phabricator.wikimedia.org/T108322 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Anomie, Luke081515, greg, Aklapper, jayvdb, pywikibot-bugs-list, scfc, hashar, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T108322: prevent modules with broken paraminfo being deployed to production wikis
Anomie moved this task to Needs plan on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T108322 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Luke081515, greg, Aklapper, jayvdb, pywikibot-bugs-list, Anomie, scfc, hashar, Legoktm, Malyacko ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T101502: Slow API list=recentchanges query (DBError: Lost connection to MySQL server during query)
Anomie added a comment.
In https://phabricator.wikimedia.org/T101502#1396381, @jcrespo wrote:
Can someone with a full understanding of the code provide a smallish, but
very representative list of different queries that could be generated from
that piece of code (different namespaces, different wikis, different sizes,
different parameters)?
There aren't really a smallish but very representative set of queries. As
stated in https://phabricator.wikimedia.org/T101502#1341361, there are several
different pieces that could wind up in the WHERE portion ANDed together, which
the client effectively selects independently. And the queries could be on any
wiki, of course. I have no idea which combinations might be most prevalent.
Here's a bit lower-level of a layout of the possibilities:
SELECT
rc_id,rc_timestamp,rc_namespace,rc_title,rc_cur_id,rc_type,rc_deleted,rc_this_oldid,rc_last_oldid,rc_comment,rc_user,rc_user_text,rc_minor,rc_type,rc_bot,rc_old_len,rc_new_len,rc_logid,rc_log_type,rc_log_action,rc_params,page_is_redirect
FROM `recentchanges` FORCE INDEX (rc_timestamp) LEFT JOIN `page` ON
((rc_namespace=page_namespace) AND (rc_title=page_title))
-- rc_type will usually be like this. I don't think it'll ever be omitted,
but could include all known types.
WHERE rc_type IN ('0','1','3')
-- rc_namespace could have anywhere from one namespace to all of them, or
this might be omitted entirely.
-- The bit after the AND might be omitted, although that should be
relatively rare when rc_namespace isn't also omitted.
WHERE rc_namespace IN ('0','1') AND (rc_type != 3 OR (rc_deleted 1) != 1)
-- This sort of thing comes from continuation, and i'd guess would be fairly
common.
WHERE rc_timestamp '2015010100' OR (rc_timestamp = '2015010100'
AND rc_id = 123456)
-- Ranges on rc_timestamp are possible.
WHERE rc_timestamp = '2015010100'
WHERE rc_timestamp = '2014010100'
WHERE rc_timestamp = '2015010100' AND rc_timestamp = '2014010100'
-- Any of these might be included (in any combination), each as = 0 or != 0.
WHERE rc_minor = 0
WHERE rc_bot = 0
WHERE rc_patrolled = 0
WHERE rc_user = 0
-- Can test for a user, by name. The rc_deleted bit might be omitted, but
that'd be uncommon.
WHERE rc_user_text = 'Example' AND (rc_deleted 4) != 4
WHERE rc_user_text != 'Example' AND (rc_deleted 4) != 4
-- Might include this.
WHERE rc_this_oldid = page_latest
-- Might even include this.
INNER JOIN change_tag ON (rc_id=ct_rc_id)
WHERE ct_tag IN ('...')
-- LIMIT could be anything from 2 to 5001. Ordering could be ASC.
ORDER BY rc_timestamp DESC,rc_id DESC LIMIT 6
TASK DETAIL
https://phabricator.wikimedia.org/T101502
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Anomie
Cc: gerritbot, greg, Lydia_Pintscher, hoo, JanZerebecki, aude, aaron, Springle,
hashar, jcrespo, Anomie, pywikibot-bugs-list, Aklapper, jayvdb, Krenair,
Legoktm, Malyacko, P.Copp
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
