[Pywikipedia-bugs] [Maniphest] [Closed] T287332: Tests fail with test.wikipedia.org family
atagar closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T287332 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Reopened] T287332: Tests fail with test.wikipedia.org family
atagar reopened this task as "Open". atagar added a comment. Hi Xqt. Sorry to reopen but changing my user-config.py in the way mentioned above surfaced a new test failure and I think this one is legitimate... % python -m tests.page_tests TestShortLink == ERROR: test_create_short_link (__main__.TestShortLink) Test create_short_link function. -- Traceback (most recent call last): File "/home/atagar/Desktop/pywikibot/pywikibot/login.py", line 110, in __init__ user = code_to_usr.get(site.code) or code_to_usr['*'] KeyError: '*' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/atagar/Desktop/pywikibot/tests/page_tests.py", line 1267, in test_create_short_link meta.login() File "/home/atagar/Desktop/pywikibot/pywikibot/site/_apisite.py", line 389, in login login_manager = api.LoginManager(site=self, user=self.username()) File "/home/atagar/Desktop/pywikibot/pywikibot/tools/_deprecate.py", line 404, in wrapper return obj(*__args, **__kw) File "/home/atagar/Desktop/pywikibot/pywikibot/login.py", line 112, in __init__ raise NoUsernameError( pywikibot.exceptions.NoUsernameError: ERROR: username for meta:meta is undefined. If you have a username for that site, please add a line to user-config.py as follows: usernames['meta']['meta'] = 'myUsername' The problem looks to be that the test is configured to only run the user has 'wikipedia:test' login credentials, but attempts to log into 'meta:meta' instead. I'll shoot you a patch in a sec. TASK DETAIL https://phabricator.wikimedia.org/T287332 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T287332: Tests fail with test.wikipedia.org family
atagar added a comment.
> Just use Site('wikipedia:test') for test.wikipedia.org. The old test_family
just duplicated the same site. (Ok the test family was prior)
Thanks Xqt. My question was how to run our scripts with test.wikipedia.org
but I figured it out. The trick is to change my user-config.py's 'mylang' to
test...
% cat user-config.py
family = 'wikipedia'
mylang = 'test'
usernames['wikipedia']['test'] = 'Atagar-bot'
... etc...
Personally I think this is pretty unintuitive and "How can practice running
scripts with test.wikipedia.org?" would be a good addition if we have a FAQ
somewhere.
Most of my test failures are now resolves so closing.
TASK DETAIL
https://phabricator.wikimedia.org/T287332
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: atagar
Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69,
Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978,
Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD,
Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS,
Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T287332: Tests fail with test.wikipedia.org family
atagar added a comment. > test.wikipedia.org is part of wikipedia_family.py. Therefore the test family was dropped. See T228375 <https://phabricator.wikimedia.org/T228375> Hi Xqt. I read T228375 <https://phabricator.wikimedia.org/T228375> but it doesn't explain how to configure myself to use it. Is this explained somewhere in or readme or site? If not we should probably add it. TASK DETAIL https://phabricator.wikimedia.org/T287332 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T287332: Tests fail with test.wikipedia.org family
atagar added a comment.
Xqt requested that I move information about
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/707869 onto this ticket. The
'drev' value with the family mentioned above is...
[
{
'pageid': 120329,
'revisions': [
{
'revid': 475999,
'parentid': 0,
'user': 'Atagar-bot',
'timestamp': '2021-06-29T00:29:33Z'
}
],
'ns': 0,
'title': 'Pywikibot move test 4'
}
]
Which causes...
% python -m tests.site_tests TestAlldeletedrevisionsAsUser
F.
==
FAIL: test_basic (__main__.TestAlldeletedrevisionsAsUser)
Test the site.alldeletedrevisions() method.
--
Traceback (most recent call last):
File "pywikibot/tests/site_tests.py", line 1616, in test_basic
self.assertTrue(all('revisions' in data
AssertionError: False is not true
TASK DETAIL
https://phabricator.wikimedia.org/T287332
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: atagar
Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69,
Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978,
Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD,
Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS,
Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Edited] T287332: Tests fail with test.wikipedia.org family
atagar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T287332 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Created] T287332: Tests fail with test.wikipedia.org family
atagar created this task.
atagar added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION
Commit 66d88aa
<https://phabricator.wikimedia.org/rPWBC66d88aa9c91c0e6f5fd96f45e7afca6ff4c89e4c>
removed our test.wikipedia.org family. I'm unsure why we did that, so I ran
generate_family_file.py to safely run our scripts against without breaking live
pages. Unfortunately doing so breaks our tests.
Here's my family config...
% cat pywikibot/families/test_family.py
"""
This family file was auto-generated by generate_family_file.py script.
Configuration parameters:
url = https://test.wikipedia.org/
name = test
Please do not commit this to the Git repository!
"""
from pywikibot import family
class Family(family.Family): # noqa: D101
name = 'test'
langs = {
'en': 'test.wikipedia.org',
}
def scriptpath(self, code):
return {
'en': '/w',
}[code]
def protocol(self, code):
return {
'en': 'https',
}[code]
And here's the test failures...
% time python -m unittest
...
==
ERROR: test_preload_langlinks_count (tests.site_tests.TestPagePreloading)
Test preloading continuation works.
--
Traceback (most recent call last):
File "/usr/lib/python3.8/unittest/mock.py", line 1325, in patched
return func(*newargs, **newkeywargs)
File "/home/atagar/Desktop/pywikibot/tests/site_tests.py", line 3144, in
test_preload_langlinks_count
pages = list(gen)
File "/home/atagar/Desktop/pywikibot/pywikibot/site/_generators.py", line
195, in preloadpages
api.update_page(page, pagedata, rvgen.props)
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3145,
in update_page
_update_langlinks(page, pagedict['langlinks'])
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3069,
in _update_langlinks
links = [pywikibot.Link.langlinkUnsafe(link['lang'], link['*'],
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3069,
in
links = [pywikibot.Link.langlinkUnsafe(link['lang'], link['*'],
File "/home/atagar/Desktop/pywikibot/pywikibot/page/__init__.py", line
5610, in langlinkUnsafe
link._site = pywikibot.Site(lang, source.family.name)
File "/home/atagar/Desktop/pywikibot/pywikibot/tools/_deprecate.py", line
404, in wrapper
return obj(*__args, **__kw)
File "/home/atagar/Desktop/pywikibot/pywikibot/__init__.py", line 1207,
in Site
_sites[key] = interface(code=code, fam=fam, user=user)
File "/home/atagar/Desktop/pywikibot/pywikibot/tools/_deprecate.py", line
487, in wrapper
return obj(*new_args, **new_kwargs)
File "/home/atagar/Desktop/pywikibot/pywikibot/site/_apisite.py", line
115, in __init__
super().__init__(code, fam, user)
File "/home/atagar/Desktop/pywikibot/pywikibot/tools/_deprecate.py", line
487, in wrapper
return obj(*new_args, **new_kwargs)
File "/home/atagar/Desktop/pywikibot/pywikibot/site/_basesite.py", line
90, in __init__
raise UnknownSiteError(error_msg)
pywikibot.exceptions.UnknownSiteError: Language 'af' does not exist in
family test
==
ERROR: test_preload_langlinks_normal (tests.site_tests.TestPagePreloading)
Test preloading langlinks works.
--
Traceback (most recent call last):
File "/home/atagar/Desktop/pywikibot/tests/site_tests.py", line 3123, in
test_preload_langlinks_normal
for count, page in enumerate(gen):
File "/home/atagar/Desktop/pywikibot/pywikibot/site/_generators.py", line
195, in preloadpages
api.update_page(page, pagedata, rvgen.props)
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3145,
in update_page
_update_langlinks(page, pagedict['langlinks'])
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3069,
in _update_langlinks
links = [pywikibot.Link.langlinkUnsafe(link['lang'], link['*'],
File "/home/atagar/Desktop/pywikibot/pywikibot/data/api.py", line 3069,
in
links = [pywikibot.Link.langlinkUnsafe(link['lang'], link['*'],
File "/home/atagar/Desktop/pywikibot/pywikibot/page/__init__.py", line
5610, in langlinkUnsafe
link._site = pywikibot
[Pywikipedia-bugs] [Maniphest] [Triaged] T286403: Consistently supply type hints
atagar triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T286403 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Closed] T281200: Clean up tools classes
atagar closed this task as "Resolved". atagar claimed this task. atagar added a comment. They've all been merged or dropped. Resolving. TASK DETAIL https://phabricator.wikimedia.org/T281200 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Created] T286403: Consistently supply type hints
atagar created this task. atagar added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Often pywikibot supplies type hints, but often it doesn't. This is a tracking ticket for consistently supplying type hints throughout our library. When finished I'll likely look into integrating mypy into our tests to prevent regression. TASK DETAIL https://phabricator.wikimedia.org/T286403 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Created] T285723: movepages requres pre-cached credentials
atagar created this task.
atagar added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION
Unlike add_text.py which logs you in if credentials are not cached,
movepages.py errors...
% python pwb.py movepages -from:"Pywikibot move test" -to:"Pywikibot move
test 2"
Moving page [[en:Pywikibot move test]] to [[Pywikibot move test 2]]
WARNING: No user is logged in on site test:en
Traceback (most recent call last):
File "pwb.py", line 399, in
if not main():
File "pwb.py", line 391, in main
run_python_file(filename,
File "pwb.py", line 106, in run_python_file
exec(compile(source, filename, 'exec', dont_inherit=True),
File "./scripts/movepages.py", line 258, in
main()
File "./scripts/movepages.py", line 247, in main
bot.moveOne(page, pair[1])
File "./scripts/movepages.py", line 78, in moveOne
page.move(
File "pywikibot/tools/_deprecate.py", line 404, in wrapper
return obj(*__args, **__kw)
File "pywikibot/tools/_deprecate.py", line 487, in wrapper
return obj(*new_args, **new_kwargs)
File "pywikibot/page/__init__.py", line 1719, in move
return self.site.movepage(self, newtitle, reason,
File "pywikibot/site/_decorators.py", line 89, in callee
raise UserRightsError('User "{}" does not have required '
pywikibot.exceptions.UserRightsError: User "None" does not have required
user
right "move"
CRITICAL: Exiting due to uncaught exception
With the patch <https://gerrit.wikimedia.org/r/c/pywikibot/core/+/701695> we
output...
% python pwb.py movepages -from:"Pywikibot move test" -to:"Pywikibot move
test 2"
WARNING: No user is logged in on site test:en
Logging in to test:en as Atagar-bot@all
WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing
list at
<https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce>
for notice of API deprecations and breaking changes. Use
[[Special:ApiFeatureUsage]] to see usage of deprecated features by your
application.
WARNING: API warning (login): Fetching a token via "action=login" is
deprecated. Use "action=query=tokens=login" instead.
ERROR: Received incorrect login token. Forcing re-login.
Moving page [[en:Pywikibot move test]] to [[Pywikibot move test 2]]
Sleeping for 6.8 seconds, 2021-06-27 16:27:28
TASK DETAIL
https://phabricator.wikimedia.org/T285723
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: atagar
Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH,
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89,
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Closed] T281202: Deprecation policy
atagar closed this task as "Resolved". atagar added a comment. Gotcha. I think we've concluded this ticket so closing. Feel free to reopen if you'd like to further discuss anything. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, Xqt, Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T281202: Deprecation policy
atagar added a comment. > But I am also fine with your proposal and it might be better to have one big change with 7.0 than douzands every month. I explicitly aggree with your points above. Great! Thanks Xqt. :) > But what about deprendencies? Does it need to increase the major release too? My understanding is that yes, it should. For example Stem (my Tor project) supported Python 2.6+ in its 1.x series and raised its requirement to Python 3.6+ <https://gitweb.torproject.org/stem.git/commit/?id=a396f57c> upon version 2.0 because that was the oldest Python release that wasn't EOL. When we release Pywikibot 7.0.0 we should consider bumping any dependency versions that are particularly old or lack features we want (like the setuptools features you mentioned). > The earliest date for 7.0 is after 6.5. Probably 7.0 comes in September. I do not want to increase the major release every month. What would be a good frequent? Quarterly, yearly? Very much agreed. Major version bumps should be infrequent since they can necessitate code changes from our users. Yearly or every couple years seems like a good cadence to me but this is wholly up to you. > if we have major release changes less than quarterly, a DeprecationWarning is appropriate again As discussed above I don't think DeprecationWarnings are useful but if you'd like to resume using them for something then happy to discuss. > Can we increase the update_script.py script to show the problems? Oh interesting. I didn't know about update_script.py. Maybe we should file another ticket to expand update_script.py to include conversions for all our codebase's present deprecations? I'm not sure what you had in mind but this could certainly be a useful upgrade tool if we keep it up to date. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, Xqt, Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T284798: Configure Gerrit to cherry-pick
atagar added a project: Pywikibot. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T284798 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: pywikibot-bugs-list, Aklapper, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T281202: Deprecation policy
atagar added a comment. Xqt merged our FutureWarning patch but hasn't said if he approves of the above (ie. to begin enforcing a symantic versioning policy). Since he merges most patches this will be a lost cause without his agreement so leaving this open to get his thoughts. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, Xqt, Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T281202: Deprecation policy
atagar added a comment. I amended our deprecation policy <https://www.mediawiki.org/wiki/Manual:Pywikibot/Development/Guidelines#Deprecation_Policy> in the following ways... 1. Copy the description of semantic versioning I wrote for Tor. We now explain what version numbers convey in terms of backward compatibility. 2. Drop the description of DeprecationWarnings vs FutureWarnings. 3. Drop the "Deprecations might be expedited when necessary" clause. If we break backward compatibility we should bump our major version number. 4. State that prior to version 6.3.1 we did not use any particular versioning scheme since we haven't been following semantic versioning's policy for code removal. Xqt, would you mind taking a look? To be very clear if we adopt this policy we should do the following... 1. **All deprecated code will be removed upon Pywikibot 7.0.0.** 2. **No deprecated code will be removed until then.** This includes code deprecated all the way back in 3.1. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, Xqt, Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Reopened] T281202: Deprecation policy
atagar reopened this task as "Open". atagar added a comment. Hi Xqt. Sorry to reopen but on reflection I'd like to propose a different policy. **Change 1: Use symantic versioning <https://stem.torproject.org/change_log.html#versioning>** (ie, code that is deprecated in version 5.3 gets removed upon 6.0) Reason 1: Symantic versioning is more intuitive. Minor version bumps (5.3 => 5.7) assure backward compatibility whereas major version bumps (5.7 => 6.0) do not. Reason 2: It's far more commonly used, especially since Python itself uses it. **Change 2: Only use FutureWarnings** Reason: DeprecationWarnings are unhelpful since effectively nobody sees them. If these are ok with you I'll update our wiki and change our 'future_warning' default to True. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T277396: Lint test to match function signature and documentation
atagar added a comment. Hi Xqt. It's a bit unclear to me what the task is... > lint checker that would look at the function's signature (i.e. parameter names) and compares with the function documentation Does this mean this aims for a lint check for the following? def my_function(my_arg): """ Some neat stuff. :param wrong_name: blah """ If so I'd be happy to take a look, but I'd think Sphinx would already exhibit a warning for that. TASK DETAIL https://phabricator.wikimedia.org/T277396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, Dvorapa, Ebrahim, Xqt, DannyS712, Aklapper, Huji, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T281202: Deprecation policy
atagar added a comment. Hi Xqt, I added a deprecation policy to our guidelines <https://www.mediawiki.org/wiki/Manual:Pywikibot/Development/Guidelines#Deprecation_Policy>. When I get external link permission <https://www.mediawiki.org/wiki/Project:Village_Pump> I'll link the tools functions to their API docs. Would you mind reviewing this addition? Once we're happy with it this ticket can be closed. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)
atagar added a comment. > Don't see any advantage. Isn't the advantage that epytext is unmaintained as of 2008 and reSt is the documentation format most python projects use? For my part I've extensively worked with Sphinx's reSt whereas pywikibot is the first time I've ever seen epytext. It would be nice for pywikibot newcomers not to need to learn an obsolete documentation format unless we have significant reason to do so. > @param foo: is more readable to for developers than :param: Per chance could this be familiarity rather than readability? `@param` and `:param:` are identically readable to me, and if anything I find the former more jarring because I haven't it within documentation before. TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, jayvdb, Huji, Aklapper, Xqt, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Urstrulykkr, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)
atagar added a comment. >> If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint? > > rstcheck validates the reSt syntax. It does not validate the content. Hi Xqt. Sorry, what I was trying to ask about was why your CR 673836 <https://gerrit.wikimedia.org/r/c/pywikibot/core/+/673836/> was discarded. If darglint is problematic then can we simply drop that for now and merge your reSt conversion? I have quite a bit of experience with Sphinx so I'd be delighted to help get this conversion across the finish line if I can. TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, jayvdb, Huji, Aklapper, Xqt, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Urstrulykkr, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)
atagar added a comment. > Currently the only check is made by sphinx but there is no code validation. If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint? TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, jayvdb, Huji, Aklapper, Xqt, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Urstrulykkr, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T278046: Convert epytext docstrings to reST (sphinx)
atagar added a comment. Hi Xqt. I really like your CR 673836 <https://gerrit.wikimedia.org/r/c/pywikibot/core/+/673836/> and would love to move this along. Unfortunately your CI link no longer works - what kind of errors did you experience and can we reproduce them locally? > I am not happy with darglint docstring checker. Do we presently perform some sort of epytext check? What kind of validation do we need to move forward with your commit? > It introduces a new undocumented yield(s) Does darglint or the ReST conversion cause the problem, and where are you seeing the yields? > Sphinx token and does not handle *args and **kwargs parameter correctly What kind of problem are you seeing? I use Sphinx and haven't experienced a problem documenting kwargs. For example: documentation <https://stem.torproject.org/api/response.html#stem.response.ControlMessage.from_str> (code <https://gitweb.torproject.org/stem.git/tree/stem/response/__init__.py?h=1.8.0#n143>) > and finally it is not possible to keyword token What do you mean by 'keyword token' and what sort of problem are you experiencing? TASK DETAIL https://phabricator.wikimedia.org/T278046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, jayvdb, Huji, Aklapper, Xqt, pywikibot-bugs-list, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Urstrulykkr, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T282962: ui_tests are failing on Travis
atagar added a comment. Hi Xqt. For what it's worth I have the ui_tests inconsistently fail locally (it seems to happen about 70% of the time). The inconsistent nature of the failures will make this hard to troubleshoot so I'd like to wait for CR 678644 <https://gerrit.wikimedia.org/r/c/pywikibot/core/+/678644> to get merged before digging in, in case it fixes this. Once that's merged I'd be happy to take a look. TASK DETAIL https://phabricator.wikimedia.org/T282962 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: atagar, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T281202: Deprecation policy
atagar added a comment. Thanks Xqt! Yesterday I finished evaluating all our deprecations prior to the end of 2019, removing FutureWarnings and changing DeprecationWarnings to FutureWarnings. In retrospect I should've discussed it here before digging in. Sorry about that. > They will be ecalated to a FutureWarning usually after 5 years Could we please make this two years instead? Five is an exceedingly long time to keep our deprecations silent (DeprecationWarnings don't provide any practical value from what I can tell). If two years is acceptable I'll implement a test that tells us when deprecated code can be transitioned to a FutureWarning and FutureWarnings can be removed. > Don't know what is the best way finally. Agreed. Backward compatibility is a balancing act. Java and Ruby exemplify two extremes... - Java offers infinite backward compatibility, but that has led to a painfully cluttered language. - Ruby drops backward compatibility every other release, which makes code support an onerous treadmill. Either extreme is problematic. Personally I used symantic versioning <https://stem.torproject.org/change_log.html#versioning> within tor, but in retrospect that leaned too much toward backward compatibility. We're on the same page about the tradeoffs here. :) If we'd like to do the two stage deprecation you describe (DeprecationWarning => FutureWarning => Removal) we need to track both dates as discussed on CR 693589 <https://gerrit.wikimedia.org/r/c/pywikibot/core/+/693589>. Would you mind if I add a 'future_warning_since' attribute to our deprecation helpers? TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Closed] T283209: Bot vs MultipleSitesBot?
atagar closed this task as "Invalid". atagar added a comment. Thanks for the detailed explanation Xqt! I don't have sufficient familiarity with our frameworks usage to determine the best class hierarchy to provide so I'm going to focus elsewhere for now. I might revisit this in the future. In the meantime I'll simply drop the deprecated bit of this module. TASK DETAIL https://phabricator.wikimedia.org/T283209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Closed] T283214: Test site certificate expired
atagar closed this task as "Invalid". atagar added a comment. That wiki fixed their certificate. Closing. TASK DETAIL https://phabricator.wikimedia.org/T283214 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Xqt, pywikibot-bugs-list, Aklapper, atagar, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Updated] T283214: Test site certificate expired
atagar added a project: Pywikibot. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T283214 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: pywikibot-bugs-list, Aklapper, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Created] T283209: Bot vs MultipleSitesBot?
atagar created this task. atagar added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Two of our pywikibot/bot.py classes (Bot and MultipleSitesBot) are functionally near identical and I need some guidance on what we want to do with them... - **Bot <https://gerrit.wikimedia.org/r/plugins/gitiles/pywikibot/core/+/refs/heads/master/pywikibot/bot.py#1516>** is documented as being for multiple sites, and discouraged in favor of MultipleSitesBot. Its **site** property is either defined by the constructor or `init_page()`. - **MultipleSitesBot <https://gerrit.wikimedia.org/r/plugins/gitiles/pywikibot/core/+/refs/heads/master/pywikibot/bot.py#1663>** has a long deprecated **site** property that is defined by its `init_page()`. If we remove this property the class doesn't have anything (it's just a BaseBot). I **think** we want to... 1. Deprecate **Bot** in favor of **MultipleSitesBot**. 2. Un-deprecate the **MultipleSitesBot** site property and keep it because callers need the latest page instance to reference it. Or maybe we should simply deprecate both classes? I need advise from someone more knowledgeable about what this module aims to provide. Thanks! -Damian TASK DETAIL https://phabricator.wikimedia.org/T283209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Reopened] T281202: Deprecation policy
atagar reopened this task as "Open". atagar added a comment. Hi Xqt. I'm going to reopen this because T106121 <https://phabricator.wikimedia.org/T106121> did not answer this. This ticket is about documenting when deprecated code can be removed. Can we remove deprecated code after a year? Two years? Or is it based on our version number? TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Shalomori123, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8
atagar added a comment. There seems to be a Python 3.5 issue regarding ModuleDeprecationWrapper. Would you like for me to install Python 3.5 to troubleshoot or should we continue with this? Personally I think we should deprecate Python 3.5 support since it reached EoL in September 2020: https://www.python.org/downloads/release/python-3510/ TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, pywikibot-bugs-list, Xqt, Aklapper, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8
atagar added a comment. That's... really odd. I have Python 3.8 and unfortunately installing a deprecated 3.5 interpreter would be a pita. Do you have any idea what's going on or should I try to get one working? TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, pywikibot-bugs-list, Xqt, Aklapper, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8
atagar added a comment.
That's odd. I do get it...
% cat demo.py
import pywikibot
from pywikibot import NoPage # same behavior if imported from
pywikibot.exceptions
from pywikibot.exceptions import NoPageError
pywikibot.handle_args()
site = pywikibot.Site()
page = pywikibot.Page(site, 'Example')
try:
raise NoPage(page)
except NoPageError as e:
print('success: NoPageError caught NoPage:', e)
% python demo.py
demo.py:2: DeprecationWarning: pywikibot.NoPage is deprecated for 5 days;
use pywikibot.exceptions.NoPageError instead.
from pywikibot import NoPage # same behavior if imported from
pywikibot.exceptions
success: NoPageError caught NoPage: Page [[en:Example]] doesn't exist.
TASK DETAIL
https://phabricator.wikimedia.org/T280227
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: atagar
Cc: JJMC89, pywikibot-bugs-list, Xqt, Aklapper, Shalomori123, Lalamarie69,
Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY,
Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi,
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99,
Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb,
Masti, Alchimista
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T280227: Exception names does not follow PEP8
atagar added a comment. Thanks @JJMC89! Great point. Code review updated with a better approach which fixes that. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: JJMC89, pywikibot-bugs-list, Xqt, Aklapper, Shalomori123, Lalamarie69, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T281202: Deprication policy
atagar created this task. atagar added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION I tried to ask on our list <https://lists.wikimedia.org/pipermail/pywikibot/2021-April/010092.html>, but where is pywikibot's deprecation policy defined? We have 130 deprecated pieces of code, some of which is six years old. This ticket is to track two things... 1. Ensure our deprecation is documented somewhere. If it isn't then I'll add it once I know what it is. 2. I'll clean anything that's eligible for removal from our codebase. TASK DETAIL https://phabricator.wikimedia.org/T281202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T281200: Clean up tools classes
atagar created this task. atagar added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION I reviewed our tools module for deprecation and cleanup opportunities. I'm done with that module so filing this to track wrapping up the five reviews I still have outstanding. TASK DETAIL https://phabricator.wikimedia.org/T281200 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T281199: Suppress and assert against bot logs
atagar created this task. atagar added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Our unit tests dump ~536 lines to stdout because bots print their logs. This verbosity makes it difficult to glean important information from our test output. This adds a bot_log contextmanager to capture bot logs and let us assert about their content. This has a couple advantages... 1. Less verbose test output. 2. Better test coverage by ensuring our bots emit the right output. If you like this direction I'll do the same for our other tests, but first I need to confirm that the project owner approves of this. TASK DETAIL https://phabricator.wikimedia.org/T281199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: Aklapper, pywikibot-bugs-list, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T281197: Tox only runs with python 3.5-3.6
atagar added a project: Pywikibot. Restricted Application added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T281197 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: pywikibot-bugs-list, Aklapper, atagar, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T280227: Exception names does not follow PEP8
atagar claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T280227 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: atagar Cc: pywikibot-bugs-list, Xqt, Aklapper, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
