[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2016-01-10 Thread gerritbot 
gerritbot added a comment.

Change 256210 merged by jenkins-bot:
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/256210


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil, gerritbot
Cc: StudiesWorld, Ladsgroup, jayvdb, gerritbot, Aklapper, Lokal_Profil, 
pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-12-12 Thread gerritbot 
gerritbot added a comment.

Change 244834 merged by jenkins-bot:
toJSON assert correct claim type

https://gerrit.wikimedia.org/r/244834


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: StudiesWorld, Ladsgroup, jayvdb, gerritbot, Aklapper, Lokal_Profil, 
pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-10-10 Thread Ladsgroup 
Ladsgroup added a comment.

Make a patch in pywikibase (pywikibot-wikibase) and I will merge it. To give 
credit to you.
My plan is to move non-editing parts of pywikibot related to wikibase into 
another repo and use it from there. Your help would be really appreciated.


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-10-09 Thread gerritbot 
gerritbot added a comment.

Change 244834 had a related patch set uploaded (by John Vandenberg):
toJSON assert correct claim type

https://gerrit.wikimedia.org/r/244834


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-10-01 Thread gerritbot 
gerritbot added a comment.

Change 243043 had a related patch set uploaded (by John Vandenberg):
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/243043


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-22 Thread Lokal_Profil 
Lokal_Profil added a comment.

In https://phabricator.wikimedia.org/T113212#1661682, @jayvdb wrote:

> Interesting; `toJSON` contains `qualifier.isQualifier = True` and 
> `source.isReference = True`.  Those should be asserts!


Should we patch this as well before resolving this task?

Also how is `pywikibot-wikibase` handled? Should pulls be done there as well or 
will that synk up before it goes live (assuming that it is not already)


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread jayvdb 
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.

Interesting; `toJSON` contains `qualifier.isQualifier = True` and 
`source.isReference = True`.  Those should be asserts!


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread gerritbot 
gerritbot added a comment.

Change 239780 merged by jenkins-bot:
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/239780


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil 
Lokal_Profil added a comment.

To clarify. The source of the above error is an false assumption that 
qualifiers don't have a hash property.


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 239780 had a related patch set uploaded (by Lokal Profil):
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/239780


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs