[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
Dalba added a comment. In T145372#3120794, @Xqt wrote: A disadvantage of copying all setting would be that you never could change the default behaviour when required which we did in past in a few cases. The meaning of the user-config setting is to change default settings only and keep the others unchanged and in the scope of the framework itself. That's a good point, I was not considering that.TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DalbaCc: Dalba, gerritbot, jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
Xqt added a comment. I find it more convenient to have these settings uncommented. Syntax highlighting is better and changing the config params can be done only by changing the values, no uncommenting required. A disadvantage of copying all setting would be that you never could change the default behaviour when required which we did in past in a few cases. The meaning of the user-config setting is to change default settings only and keep the others unchanged and in the scope of the framework itself.TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dalba, gerritbot, jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
Dalba added a comment.
In T145372#2629847, @valhallasw wrote:
I think we should copy all settings, but we should probably not actually set them. In other words, one should get a file
## This is mainly intended to support setting the
## X-Wikimedia-Debug header, which is sometimes
## needed to debug issues with Wikimedia sites:
## https://wikitech.wikimedia.org/wiki/Debugging_in_production
##
## Note that these headers will be sent with all requests,
## not just MediaWiki API calls.
# extra_headers = {}
etc.
I find it more convenient to have these settings uncommented. Syntax highlighting is better and changing the config params can be done only by changing the values, no uncommenting required.
I think if someone does not want to have all these settings in their config file probably prefers a minimal version of the user-config as @Xqt has suggested.TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, DalbaCc: Dalba, gerritbot, jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
gerritbot added a comment. Change 312534 had a related patch set uploaded (by Xqt): [bugfix] copy all settings to user-config.py but do not set them https://gerrit.wikimedia.org/r/312534TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
Xqt added a comment. That's indeed a good idea and not just copying the sections. Anyway I prefer to have a minimal config file (e.g. for experienced user or for test stuff) as we had earlier.TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Mdupont, JJMC89, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145372: generate_user_files.py is no longer able to create a small user-config-py
valhallasw added a comment.
I think we should copy all settings, but we should probably not actually set them. In other words, one should get a file
## This is mainly intended to support setting the
## X-Wikimedia-Debug header, which is sometimes
## needed to debug issues with Wikimedia sites:
## https://wikitech.wikimedia.org/wiki/Debugging_in_production
##
## Note that these headers will be sent with all requests,
## not just MediaWiki API calls.
# extra_headers = {}
etc.TASK DETAILhttps://phabricator.wikimedia.org/T145372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: valhallaswCc: jayvdb, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
