[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[zhuyifei1999]

zhuyifei1999 added a comment.


  In T228322#5344565 , @Xqt 
wrote:
  
  > lang property must be resolved from siteinfo whereas code property is 
already given when instantiating the site object. I think 
TestAPIMWException.test_API_error_encoding_ASCII uses a fake http request and 
the siteinfo is never retrieved - am I right?
  
  Does not seem so. It's doing a request, and the request wants the user agent, 
and the user agent wants to have the lang, and the lang requires a request to 
siteinfo. You have a dependency cycle.

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zhuyifei1999
Cc: zhuyifei1999, Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Xqt, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[Dvorapa]

Dvorapa added a comment.


  Is this still an issue? Or at least does this need to be solved to make 
Travis and AppVeyor pass again?

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Dalba, Xqt, Zkhalido, Viztor, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[Xqt]

Xqt added a comment.


  lang property must be resolved from siteinfo whereas code property is already 
given when instantiating the site object. I think 
TestAPIMWException.test_API_error_encoding_ASCII uses a fake http request and 
the siteinfo is never retrieved - am I right?

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Dalba, Xqt, Viztor, DannyS712, Wenyi, 
Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[Xqt]

Xqt added a comment.


  There is an infinite loop in this part of code:
  
File "C:\pwb\GIT\core\pywikibot\site.py", line 1672, in get
  preloaded = self._get_general(key, expiry)
File "C:\pwb\GIT\core\pywikibot\site.py", line 1618, in _get_general
  default_info = self._get_siteinfo(props, expiry)
File "C:\pwb\GIT\core\pywikibot\site.py", line 1541, in _get_siteinfo
  data = request.submit()
File "C:\pwb\GIT\core\pywikibot\data\api.py", line 2234, in submit
  self._data = super(CachedRequest, self).submit()
File "C:\pwb\GIT\core\pywikibot\data\api.py", line 1985, in submit
  paramstring)
File "C:\pwb\GIT\core\pywikibot\data\api.py", line 1744, in _http_request
  body=body, headers=headers)
File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1738, in wrapper
  return obj(*__args, **__kw)
File "C:\pwb\GIT\core\pywikibot\comms\http.py", line 311, in request
  headers['user-agent'] = user_agent(site, format_string)
File "C:\pwb\GIT\core\pywikibot\comms\http.py", line 219, in user_agent
  'lang': site.lang if site else '',
File "C:\pwb\GIT\core\pywikibot\site.py", line 2713, in lang
  return self.siteinfo['lang']
File "C:\pwb\GIT\core\pywikibot\site.py", line 1630, in __getitem__
  return self.get(key, False)  # caches and doesn't force it
File "C:\pwb\GIT\core\pywikibot\site.py", line 1672, in get
  preloaded = self._get_general(key, expiry)

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Dalba, Xqt, Viztor, DannyS712, Wenyi, 
Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[Xqt]

Xqt added a comment.


  Maybe this gives any hint?
  
C:\pwb\GIT\core>py -2 pwb.py api_tests -v 
TestAPIMWException.test_API_error_enco
ding_ASCII
WARNING: C:\pwb\GIT\core\pywikibot\tools\ip.py:71: ImportWarning: Importing 
ipad
dr.IPAddress failed: No module named ipaddr
Importing ipaddress.ip_address failed: No module named ipaddress
Please install ipaddr 2.1.10+ or ipaddress.
  % (_ipaddr_e, _ipaddress_e), ImportWarning)

WARNING: C:\pwb\GIT\core\pywikibot\__init__.py:125: FutureWarning:
Python 2.7.13 will be dropped in 2020.
It is recommended to use Python 3.5 or above.
See T213287 for further information.

  FutureWarning)

tests: max_retries reduced from 15 to 1
test_API_error_encoding_ASCII (__main__.TestAPIMWException)
Test a Page instance as parameter using ASCII chars. ... Traceback (most 
recent
call last):
  File "pwb.py", line 297, in 
if not main():
  File "pwb.py", line 292, in main
run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 96, in run_python_file
main_mod.__dict__)
  File ".\tests\api_tests.py", line 1191, in 
unittest.main()
  File "C:\Python27\lib\unittest\main.py", line 95, in __init__
self.runTests()
  File "C:\Python27\lib\unittest\main.py", line 232, in runTests
self.result = testRunner.run(self.test)
  File "C:\Python27\lib\unittest\runner.py", line 151, in run
test(result)
  File "C:\Python27\lib\unittest\suite.py", line 70, in __call__
return self.run(*args, **kwds)
  File "C:\Python27\lib\unittest\suite.py", line 108, in run
test(result)
  File "C:\Python27\lib\unittest\suite.py", line 70, in __call__
return self.run(*args, **kwds)
  File "C:\Python27\lib\unittest\suite.py", line 108, in run
test(result)
  File "C:\Python27\lib\unittest\case.py", line 393, in __call__
return self.run(*args, **kwds)
  File "C:\Python27\lib\unittest\case.py", line 329, in run
testMethod()
  File ".\tests\api_tests.py", line 115, in test_API_error_encoding_ASCII
page = pywikibot.page.Page(self.site, 'ASCII')
  File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1738, in wrapper
return obj(*__args, **__kw)
  File "C:\pwb\GIT\core\pywikibot\page.py", line 2327, in __init__
super(Page, self).__init__(source, title, ns)
  File "C:\pwb\GIT\core\pywikibot\page.py", line 200, in __init__
self._link = Link(title, source=source, default_namespace=ns)
  File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1738, in wrapper
return obj(*__args, **__kw)
  File "C:\pwb\GIT\core\pywikibot\page.py", line 5915, in __init__
self._defaultns = self._source.namespaces[default_namespace]
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1021, in namespaces
self._namespaces = NamespacesDict(self._build_namespaces())
  File "C:\pwb\GIT\core\pywikibot\site.py", line 2632, in _build_namespaces
for nsdata in self.siteinfo.get('namespaces', cache=False).values():
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1672, in get
preloaded = self._get_general(key, expiry)
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1618, in _get_general
default_info = self._get_siteinfo(props, expiry)
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1541, in _get_siteinfo
data = request.submit()
  File "C:\pwb\GIT\core\pywikibot\data\api.py", line 2234, in submit
self._data = super(CachedRequest, self).submit()
  File "C:\pwb\GIT\core\pywikibot\data\api.py", line 1985, in submit
paramstring)
  File "C:\pwb\GIT\core\pywikibot\data\api.py", line 1744, in _http_request
body=body, headers=headers)
  File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1738, in wrapper
return obj(*__args, **__kw)
  File "C:\pwb\GIT\core\pywikibot\comms\http.py", line 311, in request
headers['user-agent'] = user_agent(site, format_string)
  File "C:\pwb\GIT\core\pywikibot\comms\http.py", line 219, in user_agent
'lang': site.lang if site else '',
  File "C:\pwb\GIT\core\pywikibot\site.py", line 2713, in lang
return self.siteinfo['lang']
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1630, in __getitem__
return self.get(key, False)  # caches and doesn't force it
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1672, in get
preloaded = self._get_general(key, expiry)
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1618, in _get_general
default_info = self._get_siteinfo(props, expiry)
  File "C:\pwb\GIT\core\pywikibot\site.py", line 1541, in _get_siteinfo
data = request.submit()
  File "C:\pwb\GIT\core\pywikibot\data\api.py", line 2234, in submit
self._data = super(CachedRequest, self).submit()
  File 

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[gerritbot]

gerritbot added a comment.


  Change 523985 **merged** by jenkins-bot:
  [pywikibot/core@master] Revert "[bugfix] site.lang is different from 
site.code"
  
  https://gerrit.wikimedia.org/r/523985

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, pywikibot-bugs-list, Dalba, Xqt, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, 
CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, 
Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T228322: Python is killed by recent patch

[gerritbot]

gerritbot added a comment.


  Change 523985 had a related patch set uploaded (by Xqt; owner: Xqt):
  [pywikibot/core@master] Revert "[bugfix] site.lang is different from 
site.code"
  
  https://gerrit.wikimedia.org/r/523985

TASK DETAIL
  https://phabricator.wikimedia.org/T228322

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, pywikibot-bugs-list, Dalba, Xqt, Viztor, DannyS712, Wenyi, 
Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs