[Pywikipedia-bugs] [Maniphest] [Commented On] T354474: API requests when processing pages with XMLDumpPageGenerator

2024-01-06 Thread Mpaa 
Mpaa added a comment.


  It seems OK to me how it is checked today, it is checked via template 
checking and I did not see reference to current text.
  
  I do not understand why it is checked there, as it is also checked in 
page.save().
  It seems redundant to me, but maybe there is some edge case I cannot see.

TASK DETAIL
  https://phabricator.wikimedia.org/T354474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Xqt, Aklapper, pywikibot-bugs-list, Mpaa, mevo, PotsdamLamb, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T354474: API requests when processing pages with XMLDumpPageGenerator

2024-01-06 Thread Xqt 
Xqt added a comment.


  I think it should be checked with get() method only whether bot may edit or 
not. Or with latest_revision. It should be ensured that the latest revision is 
used for the check and not the current Page.text.

TASK DETAIL
  https://phabricator.wikimedia.org/T354474

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Xqt, Aklapper, pywikibot-bugs-list, Mpaa, mevo, PotsdamLamb, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org